Skip to content

Commit a7350ca

Browse files
mrCherry97mrCherry97
authored
test: Run accessibility tests on PR (kyma-project#3729)
* tests: Run accessibility tests on PR * adjust paths * string is not a boolean * idk
1 parent cf1dc75 commit a7350ca

File tree

10 files changed

+86
-59
lines changed

10 files changed

+86
-59
lines changed

‎.github/workflows/accessibility-tests.yml‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,13 @@ on:
77
types: [opened, edited, synchronize, reopened, ready_for_review]
88
paths:
99
- '.github/workflows/accessibility-tests.yml'
10-
- 'tests/integration/tests/accessibility/**'
11-
- 'tests/integration/support/**'
10+
- 'resources/**'
11+
- 'tests/integration/**'
12+
- 'nginx/**'
13+
- 'src/**'
14+
- 'backend/**'
15+
- 'kyma/**'
16+
- 'Dockerfile*'
1217

1318
jobs:
1419
run-accessibility-tests:
@@ -36,11 +41,12 @@ jobs:
3641
shell: bash
3742
env:
3843
ACC_AMP_TOKEN: ${{ secrets.ACC_AMP_TOKEN }}
44+
IS_PR: ${{ github.event_name == 'pull_request' || github.event_name == 'pull_request_target' }}
3945
run: |
4046
k3d kubeconfig get kyma > tests/integration/fixtures/kubeconfig.yaml
4147
export CYPRESS_DOMAIN=http://localhost:3001
4248
cd tests/integration
43-
npm ci && ACC_AMP_TOKEN=$ACC_AMP_TOKEN npm run "test:accesibility"
49+
npm ci && ACC_AMP_TOKEN=$ACC_AMP_TOKEN IS_PR=$IS_PR npm run "test:accesibility"
4450
- name: Uploads artifacts
4551
uses: actions/upload-artifact@v4
4652
if: ${{ always() }}

‎tests/integration/plugins/index.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ module.exports = (on, config) => {
2828
config.env.STORAGE_CLASS_NAME = randomName;
2929
config.env.APP_NAME = randomName;
3030
config.env.ACC_AMP_TOKEN = process.env.ACC_AMP_TOKEN;
31+
config.env.IS_PR = process.env.IS_PR;
3132
config.env.AMP_REPORT_NAME = reportName;
3233

3334
on('task', {

‎tests/integration/tests/accessibility/test-acc-cluster.spec.js‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,10 @@ context('Accessibility test Cluster list and overview', () => {
1212
it('Acc test clusters list', () => {
1313
cy.visit(`${config.clusterAddress}/clusters`)
1414
.runAllAccessibilityTests()
15-
.printAccessibilityTestResults()
16-
.submitAccessibilityConcernsToAMP(
15+
.printAccessibilityTestResults();
16+
17+
if (Cypress.env('IS_PR') !== true)
18+
cy.submitAccessibilityConcernsToAMP(
1719
Cypress.env('AMP_REPORT_NAME'),
1820
'Clusters list',
1921
);
@@ -24,9 +26,10 @@ context('Accessibility test Cluster list and overview', () => {
2426

2527
cy.url().should('match', /overview$/);
2628

27-
cy.runAllAccessibilityTests()
28-
.printAccessibilityTestResults()
29-
.submitAccessibilityConcernsToAMP(
29+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
30+
31+
if (Cypress.env('IS_PR') !== true)
32+
cy.submitAccessibilityConcernsToAMP(
3033
Cypress.env('AMP_REPORT_NAME'),
3134
'Cluster overview',
3235
);

‎tests/integration/tests/accessibility/test-acc-cron-jobs.spec.js‎

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,10 @@ context('Accessibility test Cron Jobs', () => {
3333

3434
cy.contains('ui5-title', 'Cron Jobs').should('be.visible');
3535

36-
cy.runAllAccessibilityTests()
37-
.printAccessibilityTestResults()
38-
.submitAccessibilityConcernsToAMP(
36+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
37+
38+
if (Cypress.env('IS_PR') !== true)
39+
cy.submitAccessibilityConcernsToAMP(
3940
Cypress.env('AMP_REPORT_NAME'),
4041
'Cron Jobs list',
4142
);
@@ -48,9 +49,10 @@ context('Accessibility test Cron Jobs', () => {
4849
.contains('ui5-title', 'Create Cron Job')
4950
.should('be.visible');
5051

51-
cy.runAllAccessibilityTests()
52-
.printAccessibilityTestResults()
53-
.submitAccessibilityConcernsToAMP(
52+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
53+
54+
if (Cypress.env('IS_PR') !== true)
55+
cy.submitAccessibilityConcernsToAMP(
5456
Cypress.env('AMP_REPORT_NAME'),
5557
'Cron Jobs create',
5658
);
@@ -130,9 +132,10 @@ context('Accessibility test Cron Jobs', () => {
130132
.contains('ui5-title', CRON_JOB_NAME)
131133
.should('be.visible');
132134

133-
cy.runAllAccessibilityTests()
134-
.printAccessibilityTestResults()
135-
.submitAccessibilityConcernsToAMP(
135+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
136+
137+
if (Cypress.env('IS_PR') !== true)
138+
cy.submitAccessibilityConcernsToAMP(
136139
Cypress.env('AMP_REPORT_NAME'),
137140
'Cron Jobs details',
138141
);

‎tests/integration/tests/accessibility/test-acc-custom-resoureces.spec.js‎

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ context('Accessibility test Custom Resources', () => {
3434

3535
cy.contains('ui5-title', 'Custom Resources').should('be.visible');
3636

37-
cy.runAllAccessibilityTests()
38-
.printAccessibilityTestResults()
39-
.submitAccessibilityConcernsToAMP(
37+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
38+
39+
if (Cypress.env('IS_PR') !== true)
40+
cy.submitAccessibilityConcernsToAMP(
4041
Cypress.env('AMP_REPORT_NAME'),
4142
'Custom Resources overview',
4243
);
@@ -53,9 +54,10 @@ context('Accessibility test Custom Resources', () => {
5354

5455
cy.url().should('match', /customresources/);
5556

56-
cy.runAllAccessibilityTests()
57-
.printAccessibilityTestResults()
58-
.submitAccessibilityConcernsToAMP(
57+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
58+
59+
if (Cypress.env('IS_PR') !== true)
60+
cy.submitAccessibilityConcernsToAMP(
5961
Cypress.env('AMP_REPORT_NAME'),
6062
'Custom Resources single list',
6163
);
@@ -85,9 +87,10 @@ context('Accessibility test Custom Resources', () => {
8587

8688
cy.contains('ui5-title', 'tcluster-test').should('be.visible');
8789

88-
cy.runAllAccessibilityTests()
89-
.printAccessibilityTestResults()
90-
.submitAccessibilityConcernsToAMP(
90+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
91+
92+
if (Cypress.env('IS_PR') !== true)
93+
cy.submitAccessibilityConcernsToAMP(
9194
Cypress.env('AMP_REPORT_NAME'),
9295
'Tcluster Custom Resource details',
9396
);

‎tests/integration/tests/accessibility/test-acc-extensions.spec.js‎

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,10 @@ context('Accessibility test Extensions view', () => {
4343

4444
cy.wait(500);
4545

46-
cy.runAllAccessibilityTests()
47-
.printAccessibilityTestResults()
48-
.submitAccessibilityConcernsToAMP(
46+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
47+
48+
if (Cypress.env('IS_PR') !== true)
49+
cy.submitAccessibilityConcernsToAMP(
4950
Cypress.env('AMP_REPORT_NAME'),
5051
'Extensions list',
5152
);
@@ -54,9 +55,10 @@ context('Accessibility test Extensions view', () => {
5455
it('Acc test Extensions create', () => {
5556
cy.openCreate();
5657

57-
cy.runAllAccessibilityTests()
58-
.printAccessibilityTestResults()
59-
.submitAccessibilityConcernsToAMP(
58+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
59+
60+
if (Cypress.env('IS_PR') !== true)
61+
cy.submitAccessibilityConcernsToAMP(
6062
Cypress.env('AMP_REPORT_NAME'),
6163
'Extensions create',
6264
);
@@ -74,9 +76,10 @@ context('Accessibility test Extensions view', () => {
7476

7577
cy.clickGenericListLink('pizzas');
7678

77-
cy.runAllAccessibilityTests()
78-
.printAccessibilityTestResults()
79-
.submitAccessibilityConcernsToAMP(
79+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
80+
81+
if (Cypress.env('IS_PR') !== true)
82+
cy.submitAccessibilityConcernsToAMP(
8083
Cypress.env('AMP_REPORT_NAME'),
8184
'Extensions details',
8285
);

‎tests/integration/tests/accessibility/test-acc-modules.spec.js‎

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,10 @@ context('Accessibility test Modules view', () => {
1414
.contains('Modify Modules')
1515
.click();
1616

17-
cy.runAllAccessibilityTests()
18-
.printAccessibilityTestResults()
19-
.submitAccessibilityConcernsToAMP(
17+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
18+
19+
if (Cypress.env('IS_PR') !== true)
20+
cy.submitAccessibilityConcernsToAMP(
2021
Cypress.env('AMP_REPORT_NAME'),
2122
'Modules view',
2223
);
@@ -29,9 +30,10 @@ context('Accessibility test Modules view', () => {
2930

3031
cy.wait(1000);
3132

32-
cy.runAllAccessibilityTests()
33-
.printAccessibilityTestResults()
34-
.submitAccessibilityConcernsToAMP(
33+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
34+
35+
if (Cypress.env('IS_PR') !== true)
36+
cy.submitAccessibilityConcernsToAMP(
3537
Cypress.env('AMP_REPORT_NAME'),
3638
'Add Modules view',
3739
);
@@ -60,9 +62,10 @@ context('Accessibility test Modules view', () => {
6062

6163
cy.wait(1000);
6264

63-
cy.runAllAccessibilityTests()
64-
.printAccessibilityTestResults()
65-
.submitAccessibilityConcernsToAMP(
65+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
66+
67+
if (Cypress.env('IS_PR') !== true)
68+
cy.submitAccessibilityConcernsToAMP(
6669
Cypress.env('AMP_REPORT_NAME'),
6770
'Edit Modules view',
6871
);

‎tests/integration/tests/accessibility/test-acc-namespace-overview.spec.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,10 @@ context('Accessibility test Namespace overview', () => {
1515

1616
cy.createNamespace('acc-test-namespace');
1717

18-
cy.runAllAccessibilityTests()
19-
.printAccessibilityTestResults()
20-
.submitAccessibilityConcernsToAMP(
18+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
19+
20+
if (Cypress.env('IS_PR') !== true)
21+
cy.submitAccessibilityConcernsToAMP(
2122
Cypress.env('AMP_REPORT_NAME'),
2223
'Namespace overview',
2324
);

‎tests/integration/tests/accessibility/test-acc-performance.spec.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@ context('Accessibility test Cluster list and overview', () => {
1717
.contains('Preferences')
1818
.click({ force: true });
1919

20-
cy.runAllAccessibilityTests()
21-
.printAccessibilityTestResults()
22-
.submitAccessibilityConcernsToAMP(
20+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
21+
22+
if (Cypress.env('IS_PR') !== true)
23+
cy.submitAccessibilityConcernsToAMP(
2324
Cypress.env('AMP_REPORT_NAME'),
2425
'Performance panel',
2526
);

‎tests/integration/tests/accessibility/test-acc-pizzas.spec.js‎

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,10 @@ context('Accessibility test Pizza Orders', () => {
7777
.contains('Pizza Orders')
7878
.click();
7979

80-
cy.runAllAccessibilityTests()
81-
.printAccessibilityTestResults()
82-
.submitAccessibilityConcernsToAMP(
80+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
81+
82+
if (Cypress.env('IS_PR') !== true)
83+
cy.submitAccessibilityConcernsToAMP(
8384
Cypress.env('AMP_REPORT_NAME'),
8485
'Pizza Orders list',
8586
);
@@ -88,9 +89,10 @@ context('Accessibility test Pizza Orders', () => {
8889
it('Acc test Pizza Orders create', () => {
8990
cy.contains('ui5-button', 'Create').click();
9091

91-
cy.runAllAccessibilityTests()
92-
.printAccessibilityTestResults()
93-
.submitAccessibilityConcernsToAMP(
92+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
93+
94+
if (Cypress.env('IS_PR') !== true)
95+
cy.submitAccessibilityConcernsToAMP(
9496
Cypress.env('AMP_REPORT_NAME'),
9597
'Pizza Orders create',
9698
);
@@ -103,9 +105,10 @@ context('Accessibility test Pizza Orders', () => {
103105

104106
cy.clickGenericListLink('diavola-order');
105107

106-
cy.runAllAccessibilityTests()
107-
.printAccessibilityTestResults()
108-
.submitAccessibilityConcernsToAMP(
108+
cy.runAllAccessibilityTests().printAccessibilityTestResults();
109+
110+
if (Cypress.env('IS_PR') !== true)
111+
cy.submitAccessibilityConcernsToAMP(
109112
Cypress.env('AMP_REPORT_NAME'),
110113
'Pizza Orders details',
111114
);

0 commit comments

Comments
 (0)