chore: turn on no-unsafe-function-type eslint rule (kyma-project#4437)

awoloszyn22 · web-flow · commit d408844c7fdc · 2025-12-12T14:34:56.000+01:00
diff --git a/src/command-pallette/CommandPalletteUI/CommandPaletteSearchBar.tsx b/src/command-pallette/CommandPalletteUI/CommandPaletteSearchBar.tsx
@@ -14,7 +14,7 @@ import './CommandPaletteSearchBar.scss';
 type CommandPaletteSearchBarProps = {
   slot?: string;
   shouldFocus?: boolean;
-  setShouldFocus?: Function;
+  setShouldFocus?: (_: boolean) => void;
   shellbarRef?: RefObject<HTMLElement>;
 };
 
diff --git a/src/command-pallette/CommandPalletteUI/handlers/clusterResourceHandler.ts b/src/command-pallette/CommandPalletteUI/handlers/clusterResourceHandler.ts
@@ -123,7 +123,7 @@ async function fetchClusterResources(context: CommandPaletteContext) {
 function sendNamespaceSwitchMessage(
   newNamespace: string,
   activeClusterName: string,
-  navigate: Function,
+  navigate: (_: string) => void,
 ) {
   const matchedRoute =
     matchPath(
diff --git a/src/command-pallette/CommandPalletteUI/handlers/crHandler.ts b/src/command-pallette/CommandPalletteUI/handlers/crHandler.ts
@@ -85,7 +85,7 @@ function navigateTo({
 }: {
   matchingNode?: NavNode;
   namespace: string | null;
-  navigate: Function;
+  navigate: (_: string) => void;
   activeClusterName: string;
   crd: CustomResourceDefinition;
   crName?: string;
diff --git a/src/command-pallette/CommandPalletteUI/types.ts b/src/command-pallette/CommandPalletteUI/types.ts
@@ -1,4 +1,4 @@
-import { TFunction } from 'react-i18next';
+import { TFunction } from 'i18next';
 import { NavNode } from 'state/types';
 import { useClustersInfoType } from 'state/utils/getClustersInfo';
 import { K8sResource } from 'types';
@@ -23,7 +23,7 @@ export type CommandPaletteContext = {
   setOpenPreferencesModal: (open: boolean) => void;
   setShowYamlUpload: (show: boolean) => void;
   clustersInfo: useClustersInfoType;
-  navigate: Function;
+  navigate: (_: string) => void;
 };
 
 type CRHelpEntries = {
diff --git a/src/components/KymaCompanion/components/Chat/CodePanel/CodePanel.tsx b/src/components/KymaCompanion/components/Chat/CodePanel/CodePanel.tsx
@@ -82,7 +82,7 @@ interface CodePanelProps {
   language: string;
   withAction?: boolean;
   link?: CodeSegmentLink | null;
-  fetchFn?: Function;
+  fetchFn?: (_: string) => boolean;
 }
 
 export default function CodePanel({
diff --git a/src/components/KymaCompanion/components/Chat/chatHelper.ts b/src/components/KymaCompanion/components/Chat/chatHelper.ts
@@ -246,7 +246,7 @@ export const parseParams = (url: string, resource: string) => {
 export const useDoesNamespaceExist = (
   url: string,
   resource: string,
-  fetchFn?: Function,
+  fetchFn?: (_: string) => boolean,
 ) => {
   const fetch = useFetch();
 
@@ -299,7 +299,7 @@ export const useDoesNamespaceExist = (
 export const useDoesResourceExist = (
   url: string,
   resource: string,
-  fetchFn?: Function,
+  fetchFn?: (_: string) => boolean,
 ) => {
   const fetch = useFetch();
   const { parsedResource, namespace } = parseParams(url, resource);
diff --git a/src/components/Modules/community/CommunityModulesAddModule.tsx b/src/components/Modules/community/CommunityModulesAddModule.tsx
@@ -46,6 +46,7 @@ import { UnsavedMessageBox } from 'shared/components/UnsavedMessageBox/UnsavedMe
 import { createPortal } from 'react-dom';
 import { Description } from 'shared/components/Description/Description';
 import { CommunityModulesSourcesList } from './components/CommunityModulesSourcesList';
+import { TFunction } from 'i18next';
 
 type VersionDisplayInfo = {
   moduleTemplate: {
@@ -130,7 +131,7 @@ function transformDataForDisplay(
 }
 
 async function upload(
-  t: Function,
+  t: TFunction,
   communityModulesTemplatesToUpload: { map: Map<string, ModuleTemplateType> },
   setModulesTemplatesToUpload: React.Dispatch<
     SetStateAction<{ map: Map<string, ModuleTemplateType> }>
@@ -139,7 +140,7 @@ async function upload(
   namespaceNodes: any,
   postRequest: PostFn,
   patchRequest: MutationFn,
-  singleGet: Function,
+  singleGet: (_: any) => Promise<Response>,
   notification: NotificationContextArgs,
   callback: CallbackFn,
 ) {
diff --git a/src/components/Modules/community/CommunityModulesEdit.tsx b/src/components/Modules/community/CommunityModulesEdit.tsx
@@ -33,6 +33,7 @@ import { ModuleTemplatesContext } from 'components/Modules/providers/ModuleTempl
 
 import 'components/Modules/community/CommunityModule.scss';
 import { SetStateAction, useSetAtom } from 'jotai';
+import { TFunction } from 'i18next';
 
 const isModuleInstalled = (
   foundModuleTemplate: ModuleTemplateType,
@@ -98,10 +99,10 @@ function onVersionChange(
 }
 
 function onSave(
-  uploadResources: Function,
-  setIsResourceEdited: Function,
+  uploadResources: () => void,
+  setIsResourceEdited: (_: any) => void,
   notification: NotificationContextArgs,
-  t: Function,
+  t: TFunction,
 ) {
   return () => {
     try {
@@ -124,7 +125,6 @@ function onSave(
 
 function transformDataForDisplay(
   availableCommunityModules: Map<string, VersionInfo[]>,
-  t: Function,
 ): ModuleDisplayInfo[] {
   return Array.from(availableCommunityModules, ([moduleName, versions]) => {
     return {
@@ -205,7 +205,6 @@ export default function CommunityModulesEdit() {
 
   const communityModulesToDisplay = transformDataForDisplay(
     availableCommunityModules,
-    t,
   );
 
   if (isCommunityModulesEnabled) {
diff --git a/src/components/Modules/community/communityModulesHelpers.ts b/src/components/Modules/community/communityModulesHelpers.ts
@@ -178,7 +178,7 @@ export async function postForCommunityResources(post: PostFn, link: string) {
 
 export async function fetchResourcesToApply(
   communityModulesToApply: Map<string, ModuleTemplateType>,
-  setResourcesToApply: Function,
+  setResourcesToApply: (_: { value: any }[]) => void,
   post: PostFn,
 ) {
   const resourcesLinks = [...communityModulesToApply.values()]
diff --git a/src/components/Modules/community/communityModulesInstallHelpers.ts b/src/components/Modules/community/communityModulesInstallHelpers.ts
@@ -21,7 +21,7 @@ export async function installCommunityModule(
   namespaceNodes: any,
   postRequest: PostFn,
   patchRequest: MutationFn,
-  singleGet: Function,
+  singleGet: (_: string) => any,
   callback: CallbackFn,
 ) {
   try {
@@ -95,7 +95,7 @@ async function uploadResources(
   namespaceNodes: any,
   postRequest: PostFn,
   patchRequest: MutationFn,
-  singleGet: Function,
+  singleGet: (_: string) => any,
   kindFilter?: string,
 ): Promise<any[]> {
   let resourcesToUpload: any[] = resources;
@@ -133,7 +133,7 @@ async function uploadResource(
   namespaceNodes: any,
   post: PostFn,
   patchRequest: MutationFn,
-  singleGet: Function,
+  singleGet: (_: string) => any,
 ) {
   const url = await getUrl(
     resource.value,
@@ -167,7 +167,7 @@ async function uploadResource(
 
 async function checkIfResourceExist(
   url: string,
-  singleGet: Function,
+  singleGet: (_: string) => any,
 ): Promise<any> {
   try {
     const response = await singleGet(url);
diff --git a/src/components/Modules/community/components/CommunityModuleVersionSelect.tsx b/src/components/Modules/community/components/CommunityModuleVersionSelect.tsx
@@ -2,7 +2,7 @@ import { FlexBox, Label, Option, Select } from '@ui5/webcomponents-react';
 
 export type ModuleInfoProps = {
   module: ModuleDisplayInfo;
-  onChange: Function;
+  onChange: (_?: string) => void;
 };
 
 export type ModuleDisplayInfo = {
diff --git a/src/components/Modules/components/ModulesListRows.tsx b/src/components/Modules/components/ModulesListRows.tsx
@@ -16,6 +16,7 @@ import { ModuleStatus, resolveType } from './ModuleStatus';
 import { StatusBadge } from 'shared/components/StatusBadge/StatusBadge';
 import { ExternalLink } from 'shared/components/ExternalLink/ExternalLink';
 import ValueState from '@ui5/webcomponents-base/dist/types/ValueState';
+import { TFunction } from 'i18next';
 
 type RowResourceType = {
   name: string;
@@ -247,7 +248,7 @@ function kymaInstallationStateColumn(
   moduleStatus: any,
   managerResourceState: any,
   resourceName: string,
-  t: Function,
+  t: TFunction,
 ) {
   return (
     <>
diff --git a/src/components/Modules/deleteModulesHelpers.tsx b/src/components/Modules/deleteModulesHelpers.tsx
@@ -125,10 +125,10 @@ export const handleItemClick = async (
   kind: string,
   group: string,
   version: string,
-  clusterUrl: Function,
-  getScope: Function,
-  namespaceUrl: Function,
-  navigate: Function,
+  clusterUrl: (_: string) => string,
+  getScope: (_: string, __: string, ___: string) => Promise<any>,
+  namespaceUrl: (_: string, __: {}) => string,
+  navigate: (_: string) => void,
 ) => {
   const isNamespaced = await getScope(group, version, kind);
   const path = `${pluralize(kind.toLowerCase())}`;
@@ -143,7 +143,7 @@ const getResources = async (
   kind: string,
   group: string,
   version: string,
-  singleGet: Function,
+  singleGet: (_: string) => any,
 ): Promise<any> | never => {
   const url =
     group === 'v1'
@@ -170,8 +170,8 @@ const getUrlsByNamespace = (resources: Resource[]) => {
 
 export const generateAssociatedResourcesUrls = async (
   resources: Resource[],
-  singleGet: Function,
-  getScope: Function,
+  singleGet: (_: string) => any,
+  getScope: (_: string, __: string, ___: string) => Promise<any>,
 ) => {
   const allUrls: string[] = [];
 
@@ -219,7 +219,7 @@ export const generateAssociatedResourcesUrls = async (
 
 export const fetchResourceCounts = async (
   resources: Resource[],
-  fetchFn: Function,
+  fetchFn: (_: any) => Promise<Response>,
 ) => {
   const counts: Counts = {};
   for (const resource of resources) {
@@ -282,7 +282,7 @@ export const deleteResources = async (
 };
 
 export const checkIfAllResourcesAreDeleted = async (
-  singleGet: Function,
+  singleGet: (_: string) => any,
   resourcesUrls: string[],
   t: TFunction,
 ) => {
@@ -327,7 +327,7 @@ export const getCommunityResourceUrls = async (
   resources: any,
   clusterNodes: NavNode[],
   namespaceNodes: NavNode[],
-  singleGet: Function,
+  singleGet: (_: string) => any,
 ) => {
   if (!resources?.length) return [];
 
diff --git a/src/components/Modules/hooks.ts b/src/components/Modules/hooks.ts
@@ -108,7 +108,7 @@ export function useGetAllModulesStatuses(modules: any[]) {
 
 export const useFetchModuleData = (
   moduleTemplates: ModuleTemplateListType,
-  selector: Function,
+  selector: (_: ModuleTemplateType) => any,
   label: string,
   moduleTemplatesLoading?: boolean,
 ) => {
diff --git a/src/shared/hooks/useFormNavigation.ts b/src/shared/hooks/useFormNavigation.ts
@@ -8,7 +8,7 @@ export function useFormNavigation() {
   const [{ formOpen }, setIsFormOpen] = useAtom(isFormOpenAtom);
 
   const navigateSafely = useCallback(
-    (action: Function) => {
+    (action: () => void) => {
       // Check if we should show the confirmation dialog
       if (formOpen && isResourceEdited.isEdited) {
         // Store the navigation action for later use if the user confirms
diff --git a/src/state/resourceEditedAtom.ts b/src/state/resourceEditedAtom.ts
@@ -1,6 +1,6 @@
 import { atom } from 'jotai';
 
-export type DiscardFn = {};
+export type DiscardFn = () => void;
 
 export interface IsResourceEditedState {
   isEdited: boolean;

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ interface CodePanelProps {`
`82`	`82`	`language: string;`
`83`	`83`	`withAction?: boolean;`
`84`	`84`	`link?: CodeSegmentLink \| null;`
`85`		`- fetchFn?: Function;`
	`85`	`+ fetchFn?: (_: string) => boolean;`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`export default function CodePanel({`