Skip to content

Commit e09912c

Browse files
authored
fix: Labels in Connect Cluster dialog (kyma-project#4076)
* fix: better labeling * fix: fix id
1 parent 441b37c commit e09912c

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

src/components/BusolaExtensions/BusolaExtensionCreate.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ export default function BusolaExtensionCreate({
106106
key: crd.metadata.name,
107107
text: crd.metadata.name,
108108
}))}
109+
id="combobox-input"
109110
/>
110111
{crd && (
111112
<>

src/components/Clusters/components/AuthForm.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,27 +38,27 @@ const OIDCform = ({ resource, setResource, ...props }) => {
3838
propertyPath="$.issuerUrl"
3939
label={t('clusters.wizard.auth.issuer-url')}
4040
input={Inputs.Text}
41-
accessible-name="issuer-url"
41+
accessible-name={t('clusters.wizard.auth.issuer-url')}
4242
/>
4343
<ResourceForm.FormField
4444
required
4545
propertyPath="$.clientId"
4646
label={t('clusters.wizard.auth.client-id')}
4747
input={Inputs.Text}
48-
accessible-name="client-id"
48+
accessible-name={t('clusters.wizard.auth.client-id')}
4949
/>
5050
<ResourceForm.FormField
5151
propertyPath="$.clientSecret"
5252
label={t('clusters.wizard.auth.client-secret')}
5353
input={Inputs.Text}
54-
accessible-name="client-secret"
54+
accessible-name={t('clusters.wizard.auth.client-secret')}
5555
/>
5656
<TextArrayInput
5757
required
5858
defaultOpen
5959
propertyPath="$.scopes"
6060
title={t('clusters.wizard.auth.scopes')}
61-
accessible-name="scopes"
61+
accessible-name={t('clusters.wizard.auth.scopes')}
6262
/>
6363
</ResourceForm.Wrapper>
6464
);
@@ -142,8 +142,9 @@ export function AuthForm({
142142
)}
143143
<ResourceForm.FormField
144144
label={t('clusters.wizard.auth.using-oidc')}
145-
input={() => (
145+
input={props => (
146146
<Switch
147+
{...props}
147148
className="sap-margin-top-tiny"
148149
checked={useOidc}
149150
onChange={switchAuthVariant}

src/shared/ResourceForm/components/FormField.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,12 @@ export function FormField({
3737
>
3838
{!isListItem && label && (
3939
<FlexBox wrap="Wrap" alignItems="Center" className="bsl-col-md--12">
40-
<Label required={required && !disabled}>{label}</Label>
40+
<Label
41+
forElement={label.replace(' ', '-').toLowerCase()}
42+
required={required && !disabled}
43+
>
44+
{label}
45+
</Label>
4146
{tooltipContent && (
4247
<HintButton
4348
setShowTitleDescription={setOpenPopover}
@@ -58,6 +63,7 @@ export function FormField({
5863
disabled,
5964
className: 'full-width',
6065
accessibleName: label,
66+
id: label.replace(' ', '-').toLowerCase(),
6167
...inputProps,
6268
})}
6369
{inputInfo && (

0 commit comments

Comments
 (0)