Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

170: Add support for Ledger (WIP) #171

Closed
wants to merge 2 commits into from
Closed

170: Add support for Ledger (WIP) #171

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 26, 2021 •
edited by ghost
Loading

PR for #170.

@ghost ghost changed the base branch from develop to master June 26, 2021 23:06
@ghost ghost self-assigned this Jun 26, 2021
@ohmie33
Copy link
Contributor

ohmie33 commented Jun 29, 2021 •
edited
Loading

heya, is this ready to review?

If so I have some questions:

  • How does adding just adding the dependency enable ledger support? maybe a quick description to explain why this works 👍
  • The issue says it should work without metamask, but when i open fleet preview of your pr, it doesn't show me anything other than a QR code when I click on connect? how can I test that your PR works with my ledger for example?

@unbanksy unbanksy changed the base branch from master to develop June 29, 2021 20:16
@Zayen-X Zayen-X linked an issue Jun 30, 2021 that may be closed by this pull request
[Feature] Add support for Ledger #170
Open
@unbanksy unbanksy self-requested a review July 2, 2021 00:14
unbanksy
unbanksy requested changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@unbanksy unbanksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewlias can you resolve merge conflict and we'll get it merged into develop.

@Zayen-X
Copy link
Contributor

Zayen-X commented Oct 5, 2021

Going to close this. Requires a deeper investigation.

@Zayen-X Zayen-X closed this Oct 5, 2021
@Zayen-X Zayen-X deleted the feature/170-add-support-for-ledger branch October 5, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add support for Ledger
3 participants
@ohmie33 @Zayen-X @unbanksy