Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Report error if dashboard charts do not receive data in the required format #2001

Open
0xJem opened this issue Jun 23, 2022 · 2 comments
Assignees
Labels
bug Something isn't working dashboard

Comments

@0xJem
Copy link
Contributor

0xJem commented Jun 23, 2022

If the dashboard charts receive no data (e.g. there's an issue with the subgraph), the entire frontend app crashes (and reports an error in the console).

Instead, the dashboard should report an error next to the affected chart.

For example:

There was an error fetching or processing data for this chart. Please report this on Twitter or the Discord server.

@0xJem 0xJem added bug Something isn't working dashboard labels Jun 23, 2022
@0xJem 0xJem self-assigned this Jun 23, 2022
@0xJem
Copy link
Contributor Author

0xJem commented Jun 23, 2022

Thoughts on the wording @appleseed-iii ?

@appleseed-iii
Copy link
Contributor

Thoughts on the wording @appleseed-iii ?

I think I'd rather direct them to Discord only (rather than Twitter also). But other than that it makes sense.

There was an error fetching or processing data for this chart. Please report this on Twitter or the Discord server.

There was an error fetching or processing data for this chart. Please report this on the Discord server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dashboard
Projects
None yet
Development

No branches or pull requests

2 participants