Skip to content

jQuery already sports 'addClass', 'removeClass', etc. features from 'classies.js` #22

Open
@peterblazejewicz

Description

jQuery is already root dependency for website, so entire classie.js custom client code taken from 3rd party page seems to be not needed:
$.addClass
$.hasClass
$.removeClass
$.toggleClass
classie.js
https://github.com/OmniSharp/OmniSharp.github.io/blob/master/_includes/js.html#L2-L9

If the entire purpose of classie.js is to support other 3rd party script cbpAnimatedHeader.js used to animate top header:
https://github.com/OmniSharp/OmniSharp.github.io/blob/master/js/cbpAnimatedHeader.js
the code could be just rewritten, correctly referencing source of original code in banner.

Let me know what you think as I could do PR rewriting cbpAnimatedHeader.js to custom animate-header.js and removing 3rd party dependency (while retaining banner reference for feature idea)

The page would gain cleaner source code and will be slightly lighter (so will be loading faster).

Thanks!

Edit: I figured out that these JS codes come with freelancer 3rd party template.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions