Feat: Respect Unity gizmos settings when drawing room template settings inspector#132
Open
Necronomison wants to merge 2 commits into
Open
Conversation
…Unity 2022.1 or newer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Right now, despite toggling either the entire gizmos off, or toggling gizmos off specifically for
RoomTemplateSettingsGrid2D, the room outlines continue to draw in the editor scene view.Problem:
The reason this happens is because currently the outline are drawn from a callback hooked into Unity's
SceneView.duringSceneGuicallback, which does not respect gizmos settings.Solution:
To manage this, I've implemented the following checks in the
onSceneGUIPersistentcallback method:RoomTemplateSettingsGrid2D). If so, don't draw (return).Testing: