Skip to content

Commit 5ac7e31

Browse files
Add content descriptions for Like and Dislike buttons (#1383)
Signed-off-by: Amr <[email protected]> Co-authored-by: Amr <[email protected]>
1 parent 18a2032 commit 5ac7e31

File tree

6 files changed

+18
-0
lines changed

6 files changed

+18
-0
lines changed

Diff for: onebusaway-android/src/main/res/layout/activity_feedback.xml

+2
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
android:layout_weight="1"
4141
android:background="@color/alert_icon_info"
4242
android:onClick="likeBtnOnClick"
43+
android:contentDescription="@string/feedback_like_button_description"
4344
android:scaleType="fitEnd"
4445
android:src="@drawable/ic_thumbs_up_custom" />
4546
<!--android:src="@drawable/ic_thumb_up" />-->
@@ -51,6 +52,7 @@
5152
android:layout_weight="1"
5253
android:background="@color/alert_icon_info"
5354
android:onClick="dislikeBtnOnClick"
55+
android:contentDescription="@string/feedback_dislike_button_description"
5456
android:scaleType="fitStart"
5557
android:src="@drawable/ic_thumbs_down_custom" />
5658
<!--android:background="@color/alert_icon_info"-->

Diff for: onebusaway-android/src/main/res/values-es/strings.xml

+4
Original file line numberDiff line numberDiff line change
@@ -1156,4 +1156,8 @@
11561156
<string name="map_option_zoom_out">Alejar</string>
11571157
<string name="map_option_zoom_in">Acercar</string>
11581158
<string name="map_option_layers_close">Cerrar botón de capas del mapa</string>
1159+
1160+
<!-- Destination reminder feedback Activity -->
1161+
<string name="feedback_like_button_description">Sí, me avisaron en el momento oportuno</string>
1162+
<string name="feedback_dislike_button_description">No, no me avisaron en el momento oportuno</string>
11591163
</resources>

Diff for: onebusaway-android/src/main/res/values-fi/strings.xml

+4
Original file line numberDiff line numberDiff line change
@@ -765,4 +765,8 @@
765765
<string name="map_option_zoom_out">Loitontaa</string>
766766
<string name="map_option_zoom_in">Lähentää</string>
767767
<string name="map_option_layers_close">Sulje karttatasojen painike</string>
768+
769+
<!-- Destination reminder feedback Activity -->
770+
<string name="feedback_like_button_description">Kyllä, minulle ilmoitettiin oikeaan aikaan</string>
771+
<string name="feedback_dislike_button_description">Ei, minulle ei ilmoitettu oikeaan aikaan</string>
768772
</resources>

Diff for: onebusaway-android/src/main/res/values-it/strings.xml

+2
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,8 @@
245245
<string name="feedback_msg">Hai ricevuto la notifica di scendere alla fermata al momento giusto?</string>
246246
<string name="feedback_freeText">Scrivi il tuo feedback</string>
247247
<string name="feedback_checkbox_text">Includi registro di sistema (la tua scelta verrà salvata per il futuro)</string>
248+
<string name="feedback_like_button_description">Sì, sono stato avvisato al momento giusto</string>
249+
<string name="feedback_dislike_button_description">No, non sono stato avvisato al momento giusto</string>
248250
<string name="feedback_log_guide">Il tuo feedback sarà inviato a OneBusAway. Se selezioni \&quot;Includi registro di sistema\&quot;, OneBusAway riceverà dal dispositivo la posizione in tempo reale mentre arrivi a destinazione. Questo ci aiuterà a migliorare la funzione promemoria di destinazione.\n\nCambia le tue preferenze per la condivisione del registro di sistema su Impostazioni.</string>
249251

250252
<!-- Destination reminder feedback Preferences -->

Diff for: onebusaway-android/src/main/res/values-pl/strings.xml

+4
Original file line numberDiff line numberDiff line change
@@ -783,4 +783,8 @@
783783
<string name="map_option_zoom_out">Riduci</string>
784784
<string name="map_option_zoom_in">Przybliż</string>
785785
<string name="map_option_layers_close">Zamknij przycisk warstw mapy</string>
786+
787+
<!-- Destination reminder feedback Activity -->
788+
<string name="feedback_like_button_description">Tak, zostałem powiadomiony we właściwym czasie</string>
789+
<string name="feedback_dislike_button_description">Nie, nie zostałem powiadomiony we właściwym czasie</string>
786790
</resources>

Diff for: onebusaway-android/src/main/res/values/strings.xml

+2
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,8 @@
319319
<string name="feedback_msg">Were you notified at the right time to exit at your stop?</string>
320320
<string name="feedback_freeText">Write your feedback</string>
321321
<string name="feedback_checkbox_text">Include system log (your choice will be saved for future trips)</string>
322+
<string name="feedback_like_button_description">Yes, I was notified at the right time</string>
323+
<string name="feedback_dislike_button_description">No, I was not notified at the right time</string>
322324
<string name="feedback_log_guide">Your feedback will be sent to OneBusAway. If you check \"Include system logs\"
323325
, real-time location information from your device recorded as you
324326
approached your destination stop will be shared with OneBusAway so developers can improve

0 commit comments

Comments
 (0)