Refactor : getValidSurveys to Reduce Cognitive Complexity #213
Description
Description:
The function getValidSurveys currently has a high cognitive complexity due to multiple nested if conditions, redundant checks, and an imperative loop structure. Refactoring this function will improve readability, maintainability, and efficiency while keeping the logic intact.
Problems Identified:
- High Cognitive Complexity due to multiple nested conditions.
- Imperative Looping (for loop) instead of using .filter(), making it harder to read.
- Repeated Condition Checks, which can be simplified into a single return statement.
Benefits of Refactoring:
- Improves Readability – The logic is clearer and easier to follow.
- Reduces Nesting – Removes deep if conditions, making it more concise.
- Uses Functional Approach (.filter()) – More idiomatic and efficient in JavaScript.
- Easier to Maintain – Future modifications will be simpler with reduced complexity.
Current Implementation:
Proposed Refactored Version:
