Org: Allow handlers to control ticket reopen decisions.

TYPE: Bugfix

Author: cyrillkuettel

src/onegov/org/layout.py

@@ -1936,7 +1936,7 @@ def editbar_links(self) -> list[Link | LinkGroup] | None:
                     )
 
             elif self.model.state == 'closed':
-                if self.model.handler_code != 'TRP':
+                if self.model.handler.reopenable:
                     links.append(
                         Link(
                             text=_('Reopen ticket'),

src/onegov/org/locale/de_CH/LC_MESSAGES/onegov.org.po

@@ -7764,8 +7764,8 @@ msgstr ""
 msgid "You have closed ticket ${number}"
 msgstr "Sie haben das Ticket ${number} abgeschlossen"
 
-msgid "Time report tickets cannot be reopened"
-msgstr "Zeiterfassungs-Tickets können nicht wieder geöffnet werden"
+msgid "This ticket cannot be reopened"
+msgstr "Dieses Ticket kann nicht wieder geöffnet werden"
 
 msgid "The ticket cannot be re-opened because it's not closed"
 msgstr ""

src/onegov/org/locale/fr_CH/LC_MESSAGES/onegov.org.po

@@ -7776,8 +7776,8 @@ msgstr "Le ticket ne peut pas être clôturé car il est en attente"
 msgid "You have closed ticket ${number}"
 msgstr "Vous avez clôturé ${number} ticket(s)"
 
-msgid "Time report tickets cannot be reopened"
-msgstr "Les tickets de rapport de temps ne peuvent pas être réouverts"
+msgid "This ticket cannot be reopened"
+msgstr "Ce ticket ne peut pas être réouvert"
 
 msgid "The ticket cannot be re-opened because it's not closed"
 msgstr "Le ticket ne peut pas être réouvert car il n'est pas clôturé"

src/onegov/org/locale/it_CH/LC_MESSAGES/onegov.org.po

@@ -7740,8 +7740,8 @@ msgstr "Il biglietto non può essere chiuso perché non è in sospeso"
 msgid "You have closed ticket ${number}"
 msgstr "Hai chiuso il biglietto ${number}"
 
-msgid "Time report tickets cannot be reopened"
-msgstr "I ticket dei rapporti di tempo non possono essere riaperti"
+msgid "This ticket cannot be reopened"
+msgstr "Questo ticket non può essere riaperto"
 
 msgid "The ticket cannot be re-opened because it's not closed"
 msgstr "Il biglietto non può essere riaperto perché non è chiuso"

src/onegov/org/views/ticket.py

@@ -746,8 +746,8 @@ def reopen_ticket(self: Ticket, request: OrgRequest) -> BaseResponse:
     user = request.current_user
     assert user is not None
 
-    if self.handler_code == 'TRP':
-        request.alert(_('Time report tickets cannot be reopened'))
+    if not self.handler.reopenable:
+        request.alert(_('This ticket cannot be reopened'))
         return morepath.redirect(request.link(self))
 
     was_closed = self.state == 'closed'

src/onegov/ticket/handler.py

@@ -250,6 +250,15 @@ def undecided(self) -> bool:
 
         return False
 
+    @property
+    def reopenable(self) -> bool:
+        """Whether or not this ticket can be reopened once closed.
+
+        By default, all tickets can be reopened. Handlers may override
+        this to prevent reopening for specific ticket types.
+        """
+        return True
+
     @property
     def reply_to(self) -> str | None:
         """ An optional email address which will be used as a Reply-To

src/onegov/translator_directory/models/ticket.py

@@ -197,6 +197,10 @@ class TimeReportHandler(Handler):
     handler_title = _('Time Report')
     code_title = _('Time Reports')
 
+    @property
+    def reopenable(self) -> bool:
+        return False
+
     @cached_property
     def translator(self) -> Translator | None:
         return (