Skip to content

Commit 5244308

Browse files
committed
Improve inheritance hierarchy
1 parent 3f49b55 commit 5244308

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

src/onegov/api/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ def batch(self) -> dict[ApiEndpointItem[L, IdT], L]:
509509
result = super().batch
510510
items = tuple(result.values())
511511
if items:
512-
type(items[0]).preload_ancestors(self.session, items)
512+
items[0].preload_ancestors(self.session, items)
513513
return result
514514

515515

src/onegov/org/api.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -450,6 +450,8 @@ def item_links(self, item: Occurrence) -> dict[str, Any]:
450450
}
451451

452452

453+
# NOTE: News is a flat two-level tree (one shared root), so it's not an N+1
454+
# like topics/agencies -- hence plain ApiEndpoint here.
453455
class NewsApiEndpoint(ApiEndpoint[News, int]):
454456
app: OrgApp
455457
request: OrgRequest

0 commit comments

Comments
 (0)