Skip to content

Commit b242671

Browse files
committed
Marks problematic test as xfail
1 parent 05075cd commit b242671

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

tests/onegov/election_day/views/test_views_upload_rest.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -427,6 +427,7 @@ def test_savepoint_rollback_blocked_by_activate_schema(
427427
assert result.scalar() == 1
428428

429429

430+
@pytest.mark.xfail('This tests fails when measuring test durations')
430431
@pytest.mark.parametrize('trigger_sql', [
431432
pytest.param('SELECT 1/0', id='division_by_zero'),
432433
pytest.param(
@@ -476,6 +477,13 @@ def test_infailedsqltransaction_after_corrupt_pool_connection(
476477
# for ROLLBACK TO SAVEPOINT statements; all other statements on INERROR
477478
# connections fail naturally and surface in Sentry.
478479
with pytest.raises(psycopg.errors.InFailedSqlTransaction):
480+
# FIXME: When running the entire test suite synchronously for
481+
# measuring the test durations this will emit a 503 instead
482+
# of raising the application. This is what should happen
483+
# in production, because of `Framework.handle_exception`
484+
# but in testing we use `webtest.Client` to run the requests
485+
# which does not capture exceptions in the way our `Server`
486+
# class does, so we should be seeing the exception...
479487
Client(app).get('/')
480488

481489
# The failure is self-healing: transaction_tween catches the exception,

0 commit comments

Comments
 (0)