Skip to content

Commit d731fa2

Browse files
committed
Add converter for query param browse
1 parent 23b964a commit d731fa2

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

src/onegov/agency/collections/agencies.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,8 @@ class ExtendedAgencyCollection(AdjacencyListCollection[ExtendedAgency]):
3636
def __init__(
3737
self,
3838
session: Session,
39-
# FIXME: These really should be float/int, we just need to add
40-
# convertes to the path configuration...
4139
root_pdf_modified: str | None = None,
42-
browse: str | None = None
40+
browse: int | None = None
4341
) -> None:
4442
super().__init__(session)
4543
self.root_pdf_modified = root_pdf_modified

src/onegov/agency/layout.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ def browsed_agency(self) -> ExtendedAgency | None:
128128
isinstance(self.model, ExtendedAgencyCollection)
129129
and self.model.browse
130130
):
131-
return self.model.by_id(self.model.browse) # type:ignore[arg-type]
131+
return self.model.by_id(self.model.browse)
132132
return None
133133

134134
@cached_property

src/onegov/agency/path.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,12 @@ def get_people(
4444
@AgencyApp.path(
4545
model=ExtendedAgencyCollection,
4646
path='/organizations',
47+
converters={'browse': int}
4748
)
4849
def get_agencies(
4950
app: AgencyApp,
5051
root_pdf_modified: str | None = None,
51-
browse: str | None = None
52+
browse: int | None = None
5253
) -> ExtendedAgencyCollection:
5354
return ExtendedAgencyCollection(app.session(), root_pdf_modified, browse)
5455

src/onegov/agency/views/agencies.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ def push_history_state(response: BaseResponse) -> None:
259259
response.headers.add(
260260
'X-IC-PushURL',
261261
request.class_link(
262-
ExtendedAgencyCollection, {'browse': str(self.id)})
262+
ExtendedAgencyCollection, {'browse': self.id})
263263
)
264264

265265
return render_macro(

0 commit comments

Comments
 (0)