Makes sure cache on get does not get shared between test functions

Author: Daverball

tests/shared/fixtures.py

@@ -404,35 +404,36 @@ def browser(playwright_browser: Browser) -> Iterator[ExtendedBrowser]:
         context.close()
 
 
-@pytest.fixture(scope="session")
-def _redis_url(redis_server: RedisExecutor) -> str:
-    return f'redis://{redis_server.host}:{redis_server.port}/0'
-
 @pytest.fixture(scope="function")
 def redis_pool(
-    _redis_url: str,
+    redis_server: RedisExecutor,
     monkeypatch: pytest.MonkeyPatch
 ) -> Iterator[ConnectionPool]:
+
+    import onegov.core.cache.redis as redis_cache
+
+    url = f'redis://{redis_server.host}:{redis_server.port}/0'
     pool = ConnectionPool.from_url(
-        _redis_url,
+        url,
         # Restore pre 8.0 defaults for these options, since the
         # new defaults cause issues in our tests
         socket_timeout=None,
         socket_connect_timeout=None,
         socket_keepalive=None
     )
-    monkeypatch.setattr('onegov.core.cache.redis.get_pool', lambda url: pool)
+    pool._redis_url = url  # type: ignore[attr-defined]
+    monkeypatch.setattr(redis_cache, 'get_pool', lambda url: pool)
+    # only cache redis cache region per test case
+    monkeypatch.setattr(redis_cache, 'get', lru_cache(maxsize=1024)(
+        redis_cache.get.__wrapped__))
     yield pool
     pool.close()
 
 
 @pytest.fixture(scope="function")
-def redis_url(
-    _redis_url: str,
-    redis_pool: ConnectionPool
-) -> Iterator[str]:
-    yield _redis_url
-    with Redis(connection_pool=redis_pool) as client:
+def redis_url(redis_pool: ConnectionPool) -> Iterator[str]:
+    yield redis_pool._redis_url  # type: ignore[attr-defined]
+    with Redis.from_pool(redis_pool) as client:
         client.flushall()