fix: duplicate history txs (#6095)

Author: weatherstar

packages/kit-bg/src/services/ServiceHistory.ts

@@ -417,25 +417,29 @@ class ServiceHistory extends ServiceBase {
     // Find transactions confirmed through history details query but not in on-chain history, these need to be saved
     let confirmedTxsToSave: IAccountHistoryTx[] = [];
 
-    confirmedTxsToSave = confirmedTxs.map((tx) => {
-      const onChainHistoryTx = onChainHistoryTxs.find(
-        (item) => item.id === tx.id,
-      );
-      if (onChainHistoryTx) {
-        return onChainHistoryTx;
-      }
-      return tx;
-    });
+    confirmedTxsToSave = confirmedTxs
+      .map((tx) => {
+        const onChainHistoryTx = onChainHistoryTxs.find(
+          (item) => item.id === tx.id,
+        );
+        if (onChainHistoryTx) {
+          return onChainHistoryTx;
+        }
+        return tx;
+      })
+      .filter((tx) => tx.decodedTx.status !== EDecodedTxStatus.Pending);
+
+    const finalConfirmedTxs = unionBy(
+      [...confirmedTxsToSave, ...onChainHistoryTxs],
+      (tx) => tx.id,
+    ).filter((tx) => tx.decodedTx.status !== EDecodedTxStatus.Pending);
 
     await this.backgroundApi.simpleDb.localHistory.updateLocalHistoryConfirmedTxs(
       {
         networkId,
         accountAddress,
         xpub,
-        confirmedTxsToSave: unionBy(
-          [...confirmedTxsToSave, ...onChainHistoryTxs],
-          (tx) => tx.id,
-        ),
+        confirmedTxsToSave: finalConfirmedTxs,
       },
     );