Skip to content

Commit 204425e

Browse files
authored
fix(core): fix cosmos signing issue (#603)
1 parent 9c8924a commit 204425e

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

core/src/apps/cosmos/transaction.py

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@
88

99
from .networks import format_amount, formatAmont, getChainName
1010

11+
required_keys = ["account_number", "chain_id", "fee", "memo", "msgs", "sequence"]
12+
_optional_keys = ["timeout_height"]
1113
MessageArgs = namedtuple(
1214
"MessageArgs",
13-
["account_number", "chain_id", "fee", "memo", "msgs", "sequence"],
15+
required_keys,
1416
)
1517

1618
KEY_SUBSTITUTIONS = [
@@ -224,13 +226,18 @@ def deserialize(raw_message: bytes) -> "Transaction":
224226
j = json.loads(raw_message.decode())
225227
except Exception:
226228
raise wire.DataError("invalid JSON")
227-
if any(
228-
k not in j
229-
for k in ["account_number", "chain_id", "fee", "memo", "msgs", "sequence"]
230-
):
229+
if any(k not in j for k in required_keys):
231230
raise wire.DataError("invalid payload")
232-
233-
return Transaction(MessageArgs(**j))
231+
return Transaction(
232+
MessageArgs(
233+
account_number=j["account_number"],
234+
chain_id=j["chain_id"],
235+
fee=j["fee"],
236+
memo=j["memo"],
237+
msgs=j["msgs"],
238+
sequence=j["sequence"],
239+
)
240+
)
234241

235242

236243
class SendTxn:

0 commit comments

Comments
 (0)