fix(legacy): fix OK-16486 & OK-16489 & OK-16484 & OK-16483 & OK-16480 & OK-16346 (#302)

Author: lyxyx

legacy/firmware/algo/parser_impl.c

@@ -707,12 +707,12 @@ static parser_error_t _readTxCommonParams(parser_context_t *c, parser_tx_t *v) {
 
   if (_findKey(c, KEY_COMMON_GEN_ID) == parser_ok) {
     CHECK_ERROR(_readString(c, (uint8_t *)v->genesisID, sizeof(v->genesisID)))
-    DISPLAY_ITEM(IDX_COMMON_GEN_ID, 1, common_num_items)
+    // DISPLAY_ITEM(IDX_COMMON_GEN_ID, 1, common_num_items)
   }
 
   CHECK_ERROR(_findKey(c, KEY_COMMON_GEN_HASH))
   CHECK_ERROR(_readBinFixed(c, v->genesisHash, sizeof(v->genesisHash)))
-  DISPLAY_ITEM(IDX_COMMON_GEN_HASH, 1, common_num_items)
+  // DISPLAY_ITEM(IDX_COMMON_GEN_HASH, 1, common_num_items)
 
   if (_findKey(c, KEY_COMMON_GROUP_ID) == parser_ok) {
     CHECK_ERROR(_readBinFixed(c, v->groupID, sizeof(v->groupID)))

legacy/firmware/aptos.c

@@ -29,7 +29,7 @@ void aptos_get_address_from_public_key(const uint8_t *public_key,
   sha3_Final(&ctx, buf);
   address[0] = '0';
   address[1] = 'x';
-  data2hex((const uint8_t *)buf, SIZE_PUBKEY, address + 2);
+  data2hexaddr((const uint8_t *)buf, SIZE_PUBKEY, address + 2);
 }
 
 void aptos_sign_tx(const AptosSignTx *msg, const HDNode *node,

legacy/firmware/cosmos/parser.c

@@ -194,6 +194,8 @@ __Z_INLINE parser_error_t parser_formatAmountItem(uint16_t amountToken,
       return parser_unexpected_error;
     }
     number_inplace_trimming(bufferUI, 0);
+    const size_t len = strlen(bufferUI);
+    if (bufferUI[len - 1] == '.') bufferUI[len - 1] = '\0';
     snprintf(tmpDenom, sizeof(tmpDenom), " %s", COIN_DEFAULT_DENOM_REPR);
   } else {
     const CosmosNetworkType *n = cosmosnetworkByChainId(cosmos_chain_id);

legacy/firmware/fsm.c

@@ -284,7 +284,7 @@ static bool fsm_layoutAddress(const char *address, const char *desc,
         const char *display_addr = address;
         // strip cashaddr prefix
         if (prefixlen) {
-          display_addr += prefixlen;
+          // display_addr += prefixlen;
         }
         layoutAddress(display_addr, desc, false, ignorecase, address_n,
                       address_n_count, address_is_account);

legacy/firmware/fsm_msg_coin.h

@@ -249,9 +249,8 @@ void fsm_msgGetAddress(const GetAddress *msg) {
     }
 
     bool is_cashaddr = coin->cashaddr_prefix != NULL;
-    bool is_bech32 = msg->script_type == InputScriptType_SPENDWITNESS ||
-                     msg->script_type == InputScriptType_SPENDTAPROOT;
-    if (!fsm_layoutAddress(address, desc, is_cashaddr || is_bech32,
+    bool is_bech32 = msg->script_type == InputScriptType_SPENDTAPROOT;
+    if (!fsm_layoutAddress(address, desc, is_bech32,
                            is_cashaddr ? strlen(coin->cashaddr_prefix) + 1 : 0,
                            msg->address_n, msg->address_n_count, false,
                            msg->has_multisig ? &(msg->multisig) : NULL,

legacy/firmware/language.c

@@ -200,6 +200,8 @@ const char *languages[][2] = {
      "down.",
      "接下来,请根据已写下的助\n记词选择正确的单词"},
     {"Click to Unlock", "按任意键解锁"},
+    // algorand.c
+    {"Close to", "关闭账户并转移资产到"},
     // layout2.c
     {"CoSi commit index #?", ""},
     // layout2.c
@@ -592,6 +594,8 @@ const char *languages[][2] = {
     {"Not in Signing mode", ""},
     // u2f.c
     {"Not registered.", ""},
+    // algorand.c
+    {"Note", "备注"},
     // layout2.c u2f.c u2f.c fsm_msg_common.h
     {"OK", "确认"},
     {"OK or Next", "确认或继续"},
@@ -730,6 +734,7 @@ const char *languages[][2] = {
     {"Re-enter new wipe code:", ""},
     // ethereum.c layout2.c
     {"Really send", "确认发送"},
+    {"Receiver", "接收方"},
     {"Recipient", "接收方"},
     // reset.c
     {"Recovery Phrase", "助记词"},
@@ -741,6 +746,8 @@ const char *languages[][2] = {
     {"Redelegate", "重新委托"},
     // u2f.c
     {"Register", "注册"},
+    // algorand.c
+    {"Rekey to", "重新授权给"},
     // layout2.c
     {"Remaining times:", "剩余次数"},
     //
@@ -895,6 +902,8 @@ const char *languages[][2] = {
     // fsm_msg_coin.h
     {"Transaction must have at least one output", ""},
     {"Transfer", "发送"},
+    // algo
+    {"Txn type", "类型"},
     // ethereum.c
     {"Txtype out of bounds", ""},
     // cosmos.c