fix(legacy): fix OK-22577 (#469)

Author: lyxyx

legacy/firmware/fsm_msg_algorand.h

@@ -33,9 +33,8 @@ void fsm_msgAlgorandGetAddress(AlgorandGetAddress *msg) {
   algorand_get_address_from_public_key(node->public_key + 1, resp->address);
 
   if (msg->has_show_display && msg->show_display) {
-    char desc[16] = {0};
-    strcat(desc, "Algorand");
-    strcat(desc, _("Address:"));
+    char desc[20] = {0};
+    snprintf(desc, 20, "%s %s", "Algorand", _("Address:"));
     if (!fsm_layoutAddress(resp->address, desc, false, 0, msg->address_n,
                            msg->address_n_count, true, NULL, 0, 0, NULL)) {
       return;

legacy/firmware/fsm_msg_conflux.h

@@ -57,9 +57,8 @@ void fsm_msgConfluxGetAddress(const ConfluxGetAddress *msg) {
     return;
   }
   if (msg->has_show_display && msg->show_display) {
-    char desc[16] = {0};
-    strcat(desc, "Conflux");
-    strcat(desc, _("Address:"));
+    char desc[20] = {0};
+    snprintf(desc, 20, "%s %s", "Conflux", _("Address:"));
     if (!fsm_layoutAddress(resp->address, desc, false, 0, msg->address_n,
                            msg->address_n_count, false, NULL, 0, 0, NULL)) {
       return;

legacy/firmware/fsm_msg_ethereum_onekey.h

@@ -185,9 +185,7 @@ void fsm_msgEthereumGetAddressOneKey(const EthereumGetAddressOneKey *msg) {
     } else {
       ASSIGN_ETHEREUM_NAME(chain_name, 0);  // unknown chain
     }
-    strcat(desc, chain_name);
-    strcat(desc, " ");
-    strcat(desc, _("Address:"));
+    snprintf(desc, 32, "%s %s", chain_name, _("Address:"));
     if (!fsm_layoutAddress(resp->address, desc, false, 0, msg->address_n,
                            msg->address_n_count, true, NULL, 0, 0, NULL)) {
       return;

legacy/firmware/fsm_msg_filecoin.h

@@ -39,9 +39,8 @@ void fsm_msgFilecoinGetAddress(const FilecoinGetAddress *msg) {
   }
   if (!get_filecoin_addr(pk, resp)) return;
   if (msg->has_show_display && msg->show_display) {
-    char desc[16] = {0};
-    strcat(desc, "Filecoin");
-    strcat(desc, _("Address:"));
+    char desc[20] = {0};
+    snprintf(desc, 20, "%s %s", "Filecoin", _("Address:"));
     if (!fsm_layoutAddress(resp->address, desc, false, 0, msg->address_n,
                            msg->address_n_count, true, NULL, 0, 0, NULL)) {
       return;

legacy/firmware/fsm_msg_starcoin.h

@@ -35,9 +35,8 @@ void fsm_msgStarcoinGetAddress(const StarcoinGetAddress *msg) {
   starcoin_get_address_from_public_key(node->public_key + 1, resp->address + 2);
 
   if (msg->has_show_display && msg->show_display) {
-    char desc[16] = {0};
-    strcat(desc, "Starcoin");
-    strcat(desc, _("Address:"));
+    char desc[20] = {0};
+    snprintf(desc, 20, "%s %s", "Starcoin", _("Address:"));
     if (!fsm_layoutAddress(resp->address, desc, false, 0, msg->address_n,
                            msg->address_n_count, true, NULL, 0, 0, NULL)) {
       return;