Skip to content

Commit 9be610d

Browse files
authored
fix(core): fix chain_id not showing for unknown networks (#472)
1 parent 3dc3d1b commit 9be610d

File tree

8 files changed

+17
-13
lines changed

8 files changed

+17
-13
lines changed

core/src/apps/ethereum/onekey/get_address.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@ async def get_address(
4343
address=address,
4444
address_n=path,
4545
network=get_display_network_name(network),
46-
evm_chain_id=None if network else msg.chain_id,
46+
evm_chain_id=None
47+
if network is not networks.UNKNOWN_NETWORK
48+
else msg.chain_id,
4749
)
4850

4951
return EthereumAddress(address=address)

core/src/apps/ethereum/onekey/sign_message.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ async def sign_message(
5757
decode_message(msg.message),
5858
address,
5959
verify=False,
60-
evm_chain_id=None if network else msg.chain_id,
60+
evm_chain_id=None if network is not networks.UNKNOWN_NETWORK else msg.chain_id,
6161
)
6262

6363
signature = secp256k1.sign(

core/src/apps/ethereum/onekey/sign_tx.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ async def sign_tx(
9494
if token_id is not None
9595
else None,
9696
token_id=token_id,
97-
evm_chain_id=None if network else msg.chain_id,
97+
evm_chain_id=None if network is not networks.UNKNOWN_NETWORK else msg.chain_id,
9898
)
9999

100100
data = bytearray()

core/src/apps/ethereum/onekey/sign_tx_eip1559.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ async def sign_tx_eip1559(
121121
if token_id is not None
122122
else None,
123123
token_id=token_id,
124-
evm_chain_id=None if network else msg.chain_id,
124+
evm_chain_id=None if network is not networks.UNKNOWN_NETWORK else msg.chain_id,
125125
)
126126
data = bytearray()
127127
data += msg.data_initial_chunk

core/src/apps/ethereum/onekey/verify_message.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,17 +44,15 @@ async def verify_message(ctx: Context, msg: EthereumVerifyMessage) -> Success:
4444
if msg.chain_id:
4545
network = networks.by_chain_id(msg.chain_id)
4646
else:
47-
network = None
48-
ctx.primary_color, ctx.icon_path = get_color_and_icon(
49-
network.chain_id if network else None
50-
)
47+
network = networks.UNKNOWN_NETWORK
48+
ctx.primary_color, ctx.icon_path = get_color_and_icon(network.chain_id)
5149
await confirm_signverify(
5250
ctx,
5351
get_display_network_name(network),
5452
decode_message(msg.message),
5553
address=address,
5654
verify=True,
57-
evm_chain_id=None if network else msg.chain_id,
55+
evm_chain_id=None if network is not networks.UNKNOWN_NETWORK else msg.chain_id,
5856
)
5957
from trezor.lvglui.i18n import gettext as _, keys as i18n_keys
6058

core/src/apps/ethereum/sign_message.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from apps.common.helpers import validate_message
1111
from apps.common.signverify import decode_message
1212

13+
from . import networks
1314
from .helpers import address_from_bytes, get_color_and_icon, get_display_network_name
1415
from .keychain import PATTERNS_ADDRESS, with_keychain_from_path
1516

@@ -50,7 +51,9 @@ async def sign_message(
5051
decode_message(msg.message),
5152
address,
5253
verify=False,
53-
evm_chain_id=None,
54+
evm_chain_id=None
55+
if network is not networks.UNKNOWN_NETWORK
56+
else network.chain_id,
5457
)
5558

5659
signature = secp256k1.sign(

core/src/apps/ethereum/sign_tx.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
from apps.common import paths
1212

13-
from . import tokens
13+
from . import networks, tokens
1414
from .helpers import (
1515
address_from_bytes,
1616
bytes_from_address,
@@ -85,7 +85,7 @@ async def sign_tx(
8585
if token_id is not None
8686
else None,
8787
token_id=token_id,
88-
evm_chain_id=None if network else msg.chain_id,
88+
evm_chain_id=None if network is not networks.UNKNOWN_NETWORK else msg.chain_id,
8989
)
9090

9191
data = bytearray()

core/src/apps/ethereum/sign_tx_eip1559.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
from apps.common import paths
1212

13+
from . import networks
1314
from .helpers import (
1415
address_from_bytes,
1516
bytes_from_address,
@@ -112,7 +113,7 @@ async def sign_tx_eip1559(
112113
if token_id is not None
113114
else None,
114115
token_id=token_id,
115-
evm_chain_id=None if network else msg.chain_id,
116+
evm_chain_id=None if network is not networks.UNKNOWN_NETWORK else msg.chain_id,
116117
)
117118
data = bytearray()
118119
data += msg.data_initial_chunk

0 commit comments

Comments
 (0)