Skip to content

Commit 827a3bf

Browse files
committed
chore: fix gofmt, add CI workflow, prepare v0.1.0
1 parent 84b3e95 commit 827a3bf

5 files changed

Lines changed: 38 additions & 11 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
name: CI
2+
3+
on:
4+
push:
5+
branches: [main]
6+
pull_request:
7+
branches: [main]
8+
9+
jobs:
10+
build:
11+
runs-on: ubuntu-latest
12+
steps:
13+
- uses: actions/checkout@v4
14+
- uses: actions/setup-go@v5
15+
with:
16+
go-version-file: go.mod
17+
- run: go build ./...
18+
- run: go test ./...
19+
- run: go vet ./...
20+
- name: Check formatting
21+
run: test -z "$(gofmt -s -l .)"

internal/rules/cpu.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
// kvm64 (the default) lacks x86-64-v2 extensions required by Talos.
1212
type CPUTypeRule struct{}
1313

14-
func (r *CPUTypeRule) Name() string { return "cpu-type" }
14+
func (r *CPUTypeRule) Name() string { return "cpu-type" }
1515
func (r *CPUTypeRule) Description() string { return "CPU type must be 'host' (kvm64 lacks x86-64-v2)" }
1616
func (r *CPUTypeRule) DefaultSeverity() Severity { return SeverityError }
1717

internal/rules/disk.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
// virtio-scsi-single causes issues with Talos disk detection.
1212
type SCSIHWRule struct{}
1313

14-
func (r *SCSIHWRule) Name() string { return "scsihw" }
14+
func (r *SCSIHWRule) Name() string { return "scsihw" }
1515
func (r *SCSIHWRule) Description() string { return "SCSI HW must be 'virtio-scsi-pci'" }
1616
func (r *SCSIHWRule) DefaultSeverity() Severity { return SeverityError }
1717

internal/rules/memory.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ type MemoryMinRule struct {
1111
MinMiB int
1212
}
1313

14-
func (r *MemoryMinRule) Name() string { return "memory-min" }
14+
func (r *MemoryMinRule) Name() string { return "memory-min" }
1515
func (r *MemoryMinRule) Description() string { return "Minimum memory requirement for Talos nodes" }
1616
func (r *MemoryMinRule) DefaultSeverity() Severity { return SeverityError }
1717

@@ -34,8 +34,10 @@ func (r *MemoryMinRule) Check(vm *proxmox.VMConfig) []Finding {
3434
// Talos has no balloon agent, so ballooning can cause instability.
3535
type BalloonRule struct{}
3636

37-
func (r *BalloonRule) Name() string { return "balloon" }
38-
func (r *BalloonRule) Description() string { return "Memory ballooning should be disabled (Talos has no balloon agent)" }
37+
func (r *BalloonRule) Name() string { return "balloon" }
38+
func (r *BalloonRule) Description() string {
39+
return "Memory ballooning should be disabled (Talos has no balloon agent)"
40+
}
3941
func (r *BalloonRule) DefaultSeverity() Severity { return SeverityWarn }
4042

4143
func (r *BalloonRule) Check(vm *proxmox.VMConfig) []Finding {

internal/rules/network.go

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010
// NetworkModelRule checks that network interfaces use the virtio model.
1111
type NetworkModelRule struct{}
1212

13-
func (r *NetworkModelRule) Name() string { return "network-model" }
13+
func (r *NetworkModelRule) Name() string { return "network-model" }
1414
func (r *NetworkModelRule) Description() string { return "Network interfaces should use virtio model" }
1515
func (r *NetworkModelRule) DefaultSeverity() Severity { return SeverityWarn }
1616

@@ -60,7 +60,7 @@ func replaceNetModel(netCfg string, newModel string) string {
6060
// QEMUAgentRule checks that the QEMU guest agent is enabled.
6161
type QEMUAgentRule struct{}
6262

63-
func (r *QEMUAgentRule) Name() string { return "qemu-agent" }
63+
func (r *QEMUAgentRule) Name() string { return "qemu-agent" }
6464
func (r *QEMUAgentRule) Description() string { return "QEMU guest agent should be enabled" }
6565
func (r *QEMUAgentRule) DefaultSeverity() Severity { return SeverityWarn }
6666

@@ -84,8 +84,10 @@ func (r *QEMUAgentRule) Check(vm *proxmox.VMConfig) []Finding {
8484
// MachineTypeRule checks that the VM uses q35 machine type.
8585
type MachineTypeRule struct{}
8686

87-
func (r *MachineTypeRule) Name() string { return "machine-type" }
88-
func (r *MachineTypeRule) Description() string { return "q35 machine type recommended for modern feature support" }
87+
func (r *MachineTypeRule) Name() string { return "machine-type" }
88+
func (r *MachineTypeRule) Description() string {
89+
return "q35 machine type recommended for modern feature support"
90+
}
8991
func (r *MachineTypeRule) DefaultSeverity() Severity { return SeverityInfo }
9092

9193
func (r *MachineTypeRule) Check(vm *proxmox.VMConfig) []Finding {
@@ -113,8 +115,10 @@ func (r *MachineTypeRule) Check(vm *proxmox.VMConfig) []Finding {
113115
// SerialConsoleRule checks that a serial console is configured for boot debugging.
114116
type SerialConsoleRule struct{}
115117

116-
func (r *SerialConsoleRule) Name() string { return "serial-console" }
117-
func (r *SerialConsoleRule) Description() string { return "Serial console recommended for boot debugging" }
118+
func (r *SerialConsoleRule) Name() string { return "serial-console" }
119+
func (r *SerialConsoleRule) Description() string {
120+
return "Serial console recommended for boot debugging"
121+
}
118122
func (r *SerialConsoleRule) DefaultSeverity() Severity { return SeverityInfo }
119123

120124
func (r *SerialConsoleRule) Check(vm *proxmox.VMConfig) []Finding {

0 commit comments

Comments
 (0)