fix: [SDK-5146] stop clearing dashboard sender on appId assignment

Wiping googleProjectNumber and isInitializedWithRemote on appId write
stalls FCM registration. There is no runtime app ID switch, so snd can
keep using the hydrated sender.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: AR Abdul Azeez

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/config/ConfigModel.kt

@@ -515,13 +515,3 @@ class RemoteLoggingConfigModel(
             setBooleanProperty(::isEnabled.name, value)
         }
 }
-
-internal fun ConfigModel.forgetDashboardSenderIfAppIdDiffers(
-    previousAppId: String?,
-    newAppId: String,
-) {
-    if (!previousAppId.isNullOrEmpty() && previousAppId != newAppId) {
-        googleProjectNumber = null
-        isInitializedWithRemote = false
-    }
-}

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/config/impl/ConfigModelStoreListener.kt

@@ -8,7 +8,6 @@ import com.onesignal.common.threading.suspendifyOnIO
 import com.onesignal.core.internal.backend.IParamsBackendService
 import com.onesignal.core.internal.config.ConfigModel
 import com.onesignal.core.internal.config.ConfigModelStore
-import com.onesignal.core.internal.config.forgetDashboardSenderIfAppIdDiffers
 import com.onesignal.core.internal.startup.IStartableService
 import com.onesignal.debug.internal.logging.Logging
 import com.onesignal.user.internal.jwt.JwtRequirement
@@ -41,8 +40,6 @@ internal class ConfigModelStoreListener(
             return
         }
 
-        val newAppId = args.newValue as? String ?: return
-        _configModelStore.model.forgetDashboardSenderIfAppIdDiffers(args.oldValue as? String, newAppId)
         fetchParams()
     }
 

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt

@@ -18,7 +18,6 @@ import com.onesignal.core.internal.application.IApplicationService
 import com.onesignal.core.internal.application.impl.ApplicationService
 import com.onesignal.core.internal.config.ConfigModel
 import com.onesignal.core.internal.config.ConfigModelStore
-import com.onesignal.core.internal.config.forgetDashboardSenderIfAppIdDiffers
 import com.onesignal.core.internal.config.impl.IdentityVerificationService
 import com.onesignal.core.internal.features.IFeatureManager
 import com.onesignal.core.internal.operations.IOperationRepo
@@ -431,11 +430,7 @@ internal class OneSignalImp : IOneSignal,
                 completeInit(InitState.FAILED)
                 return false
             }
-            val newAppId = result.appId!!
-            val previousAppId =
-                if (configModel.hasProperty(ConfigModel::appId.name)) configModel.appId else null
-            configModel.forgetDashboardSenderIfAppIdDiffers(previousAppId, newAppId)
-            configModel.appId = newAppId
+            configModel.appId = result.appId!! // safe because failed is false
             val forceCreateUser = result.forceCreateUser
 
             updateConfig()

OneSignalSDK/onesignal/core/src/test/java/com/onesignal/core/internal/config/impl/ConfigModelStoreListenerTests.kt

@@ -3,9 +3,7 @@ package com.onesignal.core.internal.config.impl
 import com.onesignal.core.internal.backend.IParamsBackendService
 import com.onesignal.core.internal.backend.ParamsObject
 import com.onesignal.core.internal.backend.RemoteLoggingParamsObject
-import com.onesignal.core.internal.config.ConfigModel
 import com.onesignal.core.internal.config.ConfigModelStore
-import com.onesignal.core.internal.config.forgetDashboardSenderIfAppIdDiffers
 import com.onesignal.debug.LogLevel
 import com.onesignal.mocks.IOMockHelper
 import com.onesignal.mocks.IOMockHelper.awaitIO
@@ -139,28 +137,4 @@ class ConfigModelStoreListenerTests : FunSpec({
         store.model.sdkRemoteFeatureFlags shouldBe listOf("sdk_background_threading")
         store.model.sdkRemoteFeatureFlagMetadata shouldBe """{"sdk_background_threading":{"x":1}}"""
     }
-
-    test("forgetDashboardSenderIfAppIdDiffers keeps sender when appId is unchanged") {
-        val model = ConfigModel()
-        model.appId = "app-a"
-        model.googleProjectNumber = "111"
-        model.isInitializedWithRemote = true
-
-        model.forgetDashboardSenderIfAppIdDiffers("app-a", "app-a")
-
-        model.googleProjectNumber shouldBe "111"
-        model.isInitializedWithRemote shouldBe true
-    }
-
-    test("forgetDashboardSenderIfAppIdDiffers drops sender when appId changes") {
-        val model = ConfigModel()
-        model.appId = "app-a"
-        model.googleProjectNumber = "111"
-        model.isInitializedWithRemote = true
-
-        model.forgetDashboardSenderIfAppIdDiffers("app-a", "app-b")
-
-        model.googleProjectNumber shouldBe null
-        model.isInitializedWithRemote shouldBe false
-    }
 })

OneSignalSDK/onesignal/core/src/test/java/com/onesignal/core/internal/device/FidEnvReaderTests.kt

@@ -77,7 +77,7 @@ class FidEnvReaderTests : FunSpec({
         header.shouldContain("snd=-")
     }
 
-    test("snd stays unknown until dashboard params for this appId have hydrated") {
+    test("snd stays unknown until dashboard params have hydrated") {
         val applicationService = MockHelper.applicationService()
         every { applicationService.appContext } returns context
         val configStore =