refactor: [SDK-5088] read the kill switch through the feature manager

The detector scanned the raw fetched flag list because the kill switch
key had no catalog entry. Now that it has one, DeviceGestureDetector
takes IFeatureManager and asks it for SDK_DEVICE_GESTURE_DISABLED like
every other flag, which also drops the hand-rolled case handling. The
switch still reads present-means-off, and absent still means on.

Author: nan-li

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/gesture/DeviceGestureDetector.kt

@@ -9,8 +9,10 @@ import com.onesignal.common.threading.suspendifyOnMain
 import com.onesignal.core.internal.application.IApplicationLifecycleHandler
 import com.onesignal.core.internal.application.IApplicationService
 import com.onesignal.core.internal.config.ConfigModelStore
+import com.onesignal.core.internal.features.IFeatureManager
 import com.onesignal.core.internal.startup.IStartableService
 import com.onesignal.debug.internal.logging.Logging
+import com.onesignal.features.FeatureFlag
 import com.onesignal.logger.IObservabilityEventRecorder
 import com.onesignal.logger.ObservabilityEvent
 
@@ -26,18 +28,16 @@ import com.onesignal.logger.ObservabilityEvent
  * fires when an activity declaring orientation in `configChanges` rotates. The window is the
  * only rate rule; six cycles inside it takes sustained five-second round trips.
  *
- * Adding [KILL_SWITCH_KEY] to the app's enabled feature keys disables the gesture. Absent
- * means enabled, so a device that has never fetched flags still has it. Reads the raw
- * [com.onesignal.core.internal.config.ConfigModel.sdkRemoteFeatureFlags] list because
- * [com.onesignal.core.internal.features.IFeatureManager] only resolves keys the KMP catalog
- * registers.
+ * [FeatureFlag.SDK_DEVICE_GESTURE_DISABLED] turns the gesture off. Absent means enabled, so a
+ * device that has never fetched flags still has it.
  *
  * Every recognised gesture also records [ObservabilityEvent.DEVICE_GESTURE], with its outcome
  * and the copied ID, so the gesture's usage can be measured.
  */
 internal class DeviceGestureDetector(
     private val applicationService: IApplicationService,
     private val configModelStore: ConfigModelStore,
+    private val featureManager: IFeatureManager,
     private val eventRecorder: IObservabilityEventRecorder,
 ) : IStartableService,
     IApplicationLifecycleHandler {
@@ -112,7 +112,7 @@ internal class DeviceGestureDetector(
             // Not recorded either: nothing about the device may ship before consent.
             config.consentRequired == true && config.consentGiven != true ->
                 Logging.debug("DeviceGestureDetector: gesture detected but privacy consent is not granted")
-            config.sdkRemoteFeatureFlags.any { it.equals(KILL_SWITCH_KEY, ignoreCase = true) } -> {
+            featureManager.isEnabled(FeatureFlag.SDK_DEVICE_GESTURE_DISABLED) -> {
                 Logging.debug("DeviceGestureDetector: gesture detected but disabled remotely")
                 recordGesture(GestureResult.DISABLED)
             }
@@ -167,7 +167,6 @@ internal class DeviceGestureDetector(
         /** Shortest background phase a human can produce; anything faster is synthetic. */
         internal const val MIN_BACKGROUND_DWELL_MS = 250L
 
-        internal const val KILL_SWITCH_KEY = "sdk_device_gesture_disabled"
         private const val CLIP_LABEL = "OneSignal subscription ID"
         private const val CLIP_PREFIX = "os: "
         internal const val NO_SUBSCRIPTION_CLIP_TEXT = CLIP_PREFIX + "no subscription ID yet"

OneSignalSDK/onesignal/core/src/test/java/com/onesignal/core/internal/gesture/DeviceGestureDetectorTests.kt

@@ -8,6 +8,8 @@ import androidx.test.core.app.ApplicationProvider
 import br.com.colman.kotest.android.extensions.robolectric.RobolectricTest
 import com.onesignal.core.internal.application.IApplicationLifecycleHandler
 import com.onesignal.core.internal.application.IApplicationService
+import com.onesignal.core.internal.features.IFeatureManager
+import com.onesignal.features.FeatureFlag
 import com.onesignal.logger.ILogTelemetry
 import com.onesignal.logger.IObservabilityEventRecorder
 import com.onesignal.logger.ObservabilityEvent
@@ -57,7 +59,7 @@ private class RecorderSpy : IObservabilityEventRecorder {
  */
 private class Harness(
     subscriptionId: String? = SUBSCRIPTION_ID,
-    remoteFlags: List<String> = emptyList(),
+    killSwitchOn: Boolean = false,
     consentRequired: Boolean? = null,
     consentGiven: Boolean? = null,
     fireOnSubscribe: Boolean = false,
@@ -84,11 +86,13 @@ private class Harness(
         val configModelStore =
             MockHelper.configModelStore {
                 it.pushSubscriptionId = subscriptionId
-                it.sdkRemoteFeatureFlags = remoteFlags
                 it.consentRequired = consentRequired
                 it.consentGiven = consentGiven
             }
-        detector = DeviceGestureDetector(applicationService, configModelStore, recorder)
+        // Strict mock: only the kill switch flag is answered, so asking for anything else fails the test.
+        val featureManager = mockk<IFeatureManager>()
+        every { featureManager.isEnabled(FeatureFlag.SDK_DEVICE_GESTURE_DISABLED) } returns killSwitchOn
+        detector = DeviceGestureDetector(applicationService, configModelStore, featureManager, recorder)
         detector.monotonicMillis = { nowMs }
         detector.start()
     }
@@ -187,8 +191,7 @@ class DeviceGestureDetectorTests : FunSpec({
     }
 
     test("the remote kill switch suppresses the copy") {
-        // Server casing is preserved in the stored list, so match case-insensitively.
-        val harness = Harness(remoteFlags = listOf("SDK_Device_Gesture_Disabled"))
+        val harness = Harness(killSwitchOn = true)
 
         repeat(6) { harness.cycle() }
         awaitIO()
@@ -285,7 +288,7 @@ class DeviceGestureDetectorTests : FunSpec({
     }
 
     test("the remote kill switch records a disabled result without an ID") {
-        val harness = Harness(remoteFlags = listOf(DeviceGestureDetector.KILL_SWITCH_KEY))
+        val harness = Harness(killSwitchOn = true)
 
         repeat(6) { harness.cycle() }
         awaitIO()