Ignore Firebase Unity libraries

* Example such as com.google.firebase:firebase-messaging-unity:6.2.2
  - We need to omit as these wrapper library versions do not line up with Firebase's native ones

Author: jkasten2

src/main/groovy/com/onesignal/androidsdk/GradleProjectPlugin.groovy

@@ -69,7 +69,10 @@ class GradleProjectPlugin implements Plugin<Project> {
 
         // ### Google Firebase library
         (GROUP_FIREBASE): [
-            version: NO_REF_VERSION
+            version: NO_REF_VERSION,
+            // Do not attempt to align Firebase's Unity libraries
+            // These wrapper libraries have their own version numbers that don't line up
+            omitModulesPostFix: '-unity',
         ],
 
         // ### Android Support Library
@@ -598,6 +601,10 @@ class GradleProjectPlugin implements Plugin<Project> {
         if (omitModules && omitModules.contains(name))
             return false
 
+        def omitModulesPostFix = versionOverride['omitModulesPostFix']
+        if (omitModulesPostFix && name.endsWith(omitModulesPostFix))
+            return false
+
         true
     }
 

src/test/groovy/com/onesignal/androidsdk/GradleTestTemplate.groovy

@@ -108,7 +108,7 @@ class GradleTestTemplate {
         '''.stripIndent()
     }
 
-    static def createGradlePropertiesFile(buildSections) {
+    static void createGradlePropertiesFile(buildSections) {
         def gradlePropertiesFile = testProjectDir.newFile("gradle.properties")
         gradlePropertiesFile << """\
             android.useAndroidX=${buildSections['android.useAndroidX'] ?: false}
@@ -119,6 +119,26 @@ class GradleTestTemplate {
         """.stripIndent()
     }
 
+    // Creates a local maven repo to test local libraries; such as firebase-app-unity
+    static void createM2repository(String group, String module, String version) {
+        final libPath = "m2repository/${group.replace('.', '/')}/${module}/${version}"
+        testProjectDir.newFolder(libPath.split('/'))
+
+        final pomFile = testProjectDir.newFile("${libPath}/${module}-${version}.pom")
+        pomFile << """\
+           <project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+             xmlns="http://maven.apache.org/POM/4.0.0"
+             xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+              <modelVersion>4.0.0</modelVersion>
+              <groupId>${group}</groupId>
+              <artifactId>${module}</artifactId>
+              <version>${version}</version>
+              <packaging>pom</packaging>
+              <dependencies></dependencies>
+            </project>
+        """
+    }
+
     static void createBuildFile(buildSections) {
         testProjectDir = new TemporaryFolder()
         testProjectDir.create()
@@ -151,6 +171,8 @@ class GradleTestTemplate {
             allprojects {
                 repositories {
                     maven { url 'https://maven.google.com' }
+                    // Local maven repo to test local libaries; such as firebase-app-unity
+                    maven { url(uri('m2repository')) }
                     jcenter()
                 }
             }
@@ -264,14 +286,15 @@ class GradleTestTemplate {
                 createSubProject(currentParams)
                 createProguardFile()
 
-                // Test running gradle plugin last on newest version of Gradle only
-//                if (gradleVersion.key == GRADLE_OLDEST_VERSION)
-//                    return
-//                currentParams['onesignalPluginId'] = "id 'com.onesignal.androidsdk.onesignal-gradle-plugin' apply false"
-//                currentParams['applyPlugins'] = "apply plugin: 'com.onesignal.androidsdk.onesignal-gradle-plugin'"
+                // Uncomment to test with only the latest version of Gradle
+//              if (!runLatestGradleOnly(gradleVersion, currentParams))
+//                  return
 
                 buildArguments.removeAll([null])
 
+                if (buildParams['preBuildClosure'])
+                    buildParams['preBuildClosure']()
+
                 def result =
                     GradleRunner.create()
                         .withProjectDir(testProjectDir.root)
@@ -293,4 +316,12 @@ class GradleTestTemplate {
         if (buildSections['onesignalPluginId'] == null)
             buildSections['onesignalPluginId'] = "id 'com.onesignal.androidsdk.onesignal-gradle-plugin'"
     }
+
+    static boolean runLatestGradleOnly(gradleVersion, currentParams) {
+        if (gradleVersion.key == GRADLE_OLDEST_VERSION)
+            return false
+        currentParams['onesignalPluginId'] = "id 'com.onesignal.androidsdk.onesignal-gradle-plugin' apply false"
+        currentParams['applyPlugins'] = "apply plugin: 'com.onesignal.androidsdk.onesignal-gradle-plugin'"
+        true
+    }
 }

src/test/groovy/com/onesignal/androidsdk/MainTest.groovy

@@ -25,7 +25,7 @@ class MainTest extends Specification {
 
         then:
         results.each {
-            assert it.value.contains('com.onesignal:OneSignal:[3.8.3, 3.99.99] -> 3.11.1')
+            assert it.value.contains('com.onesignal:OneSignal:[3.8.3, 3.99.99] -> 3.11.2')
         }
     }
 
@@ -964,6 +964,27 @@ class MainTest extends Specification {
         }
     }
 
+    def 'when firebase-app-unity and firebase-messaging'() {
+        when:
+        def results = runGradleProject([
+            skipGradleVersion: GRADLE_OLDEST_VERSION,
+            compileLines : """\
+                implementation 'com.google.firebase:firebase-messaging:17.0.0'
+                implementation 'com.google.firebase:firebase-app-unity:6.2.2'
+            """,
+            preBuildClosure: {
+                GradleTestTemplate.createM2repository('com.google.firebase', 'firebase-app-unity', '6.2.2')
+            }
+        ])
+
+        then:
+        assert results // Asserting existence and contains 1+ entries
+        results.each {
+            // Ensure we are not trying to update this unity library
+            assert it.value.contains('com.google.firebase:firebase-app-unity:6.2.2\n')
+        }
+    }
+
     // Note: Slow 20 second test, this is doing a full build
     //   This is needed as we are making sure compile and runtime versions are not being miss aligned
     //   Asserts just a double check as Gradle or AGP fails to build when this happens