Merge pull request #629 from OneSignal/fix/pushSubId

[Fix] Push subscription Id and Token on iOS

Author: shepherd-l

OneSignalExample/Assets/OneSignal/CHANGELOG.md

@@ -5,15 +5,18 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Fixed
+- Push subscription Id and Token malloc error on iOS
+
 ## [5.0.0]
 ### Changed
 - Removed `SetLaunchURLsInApp`
 - Removed async from location request permission and updated method name to `RequestPermission`
 - Updated included iOS SDK to [5.0.1](https://github.com/OneSignal/OneSignal-iOS-SDK/releases/tag/5.0.1)
 - Updated included Android SDK to [5.0.0](https://github.com/OneSignal/OneSignal-Android-SDK/releases/tag/5.0.0)
-- Updated default OneSignal Android notificaiton icons to new logo
+- Updated default OneSignal Android notification icons to new logo
 ### Fixed
-- Outcome method calls on Android
+- NoSuchMethodError for outcome methods on Android
 - Completion check for the Copy Android plugin to Assets setup step
 
 ## [5.0.0-beta.3]

OneSignalExample/Assets/OneSignal/Example/OneSignalExampleBehaviour.cs

@@ -135,7 +135,7 @@ public class OneSignalExampleBehaviour : MonoBehaviour {
     /// </summary>
     private void Start() {
         // Enable lines below to debug issues with OneSignal
-        OneSignal.Debug.LogLevel = LogLevel.Verbose;
+        OneSignal.Debug.LogLevel = LogLevel.Info;
         OneSignal.Debug.AlertLevel = LogLevel.Fatal;
 
         _log($"Initializing with appId <b>{appId}</b>");
@@ -230,16 +230,12 @@ public void ToggleConsentGiven() {
     public void SetLogLevel() {
         var newLevel = _nextEnum(OneSignal.Debug.LogLevel);
         _log($"Setting LogLevel to <b>{newLevel}</b>");
-        
-        // LogLevel uses the standard Unity LogType
         OneSignal.Debug.LogLevel = newLevel;
     }
 
     public void SetAlertLevel() {
         var newLevel = _nextEnum(OneSignal.Debug.AlertLevel);
         _log($"Setting AlertLevel to <b>{newLevel}</b>");
-
-        // AlertLevel uses the standard Unity LogType
         OneSignal.Debug.AlertLevel = newLevel;
     }
 

com.onesignal.unity.core/Samples~/OneSignalExampleBehaviour.cs

@@ -230,16 +230,12 @@ public void ToggleConsentGiven() {
     public void SetLogLevel() {
         var newLevel = _nextEnum(OneSignal.Debug.LogLevel);
         _log($"Setting LogLevel to <b>{newLevel}</b>");
-        
-        // LogLevel uses the standard Unity LogType
         OneSignal.Debug.LogLevel = newLevel;
     }
 
     public void SetAlertLevel() {
         var newLevel = _nextEnum(OneSignal.Debug.AlertLevel);
         _log($"Setting AlertLevel to <b>{newLevel}</b>");
-
-        // AlertLevel uses the standard Unity LogType
         OneSignal.Debug.AlertLevel = newLevel;
     }
 

com.onesignal.unity.ios/Runtime/Plugins/iOS/OneSignalUnityBridgeUser.mm

@@ -80,6 +80,7 @@ - (void)onPushSubscriptionDidChangeWithState:(OSPushSubscriptionChangedState*)st
 
 /*
  * Bridge methods
+ * We use strdup because Unity attempts to free the memory after we return the value
  */
 
 extern "C" {
@@ -156,11 +157,11 @@ void _userRemoveTags(const char* tagsJson) {
     }
 
     const char* _pushSubscriptionGetId() {
-        return [OneSignal.User.pushSubscription.id UTF8String];
+        return strdup([OneSignal.User.pushSubscription.id UTF8String]);
     }
 
     const char* _pushSubscriptionGetToken() {
-        return [OneSignal.User.pushSubscription.token UTF8String];
+        return strdup([OneSignal.User.pushSubscription.token UTF8String]);
     }
 
     bool _pushSubscriptionGetOptedIn() {