Skip to content

Commit a7e29a5

Browse files
authored
Merge pull request #531 from OneSignal/release/3.0.4
Release 3.0.4
2 parents d1ff77c + 4fdddf4 commit a7e29a5

File tree

8 files changed

+25
-13
lines changed

8 files changed

+25
-13
lines changed

OneSignalExample/Assets/OneSignal/CHANGELOG.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

77
## [Unreleased]
8+
## [3.0.4]
9+
### Fixed
10+
- Android `DeleteTags` and `RemoveTriggers` calls correctly use a Java array list instead of an array
11+
812
## [3.0.3]
913
### Changed
1014
- Added support for OneSignal Android functionality `promptForPushNotifications`
@@ -154,7 +158,8 @@ If you run into any problems, please don’t hesitate to [open an issue](https:/
154158
- If you are updating from a previous version of the OneSignal Unity SDK please follow the Unity Asset Store instructions in
155159
the [README](https://github.com/OneSignal/OneSignal-Unity-SDK/README.md#unity-asset-store) to ensure a smooth transition.
156160

157-
[Unreleased]: https://github.com/OneSignal/OneSignal-Unity-SDK/compare/3.0.3...HEAD
161+
[Unreleased]: https://github.com/OneSignal/OneSignal-Unity-SDK/compare/3.0.4...HEAD
162+
[3.0.4]: https://github.com/OneSignal/OneSignal-Unity-SDK/compare/3.0.3...3.0.4
158163
[3.0.3]: https://github.com/OneSignal/OneSignal-Unity-SDK/compare/3.0.2...3.0.3
159164
[3.0.2]: https://github.com/OneSignal/OneSignal-Unity-SDK/compare/3.0.1...3.0.2
160165
[3.0.1]: https://github.com/OneSignal/OneSignal-Unity-SDK/compare/3.0.0...3.0.1
+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.0.3
1+
3.0.4

OneSignalExample/ProjectSettings/ProjectSettings.asset

+1-4
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ PlayerSettings:
134134
16:10: 1
135135
16:9: 1
136136
Others: 1
137-
bundleVersion: 3.0.3
137+
bundleVersion: 3.0.4
138138
preloadedAssets: []
139139
metroInputSource: 0
140140
wsaTransparentSwapchain: 0
@@ -525,9 +525,7 @@ PlayerSettings:
525525
switchPlayerConnectionEnabled: 1
526526
switchUseNewStyleFilepaths: 0
527527
switchUseMicroSleepForYield: 1
528-
switchEnableRamDiskSupport: 0
529528
switchMicroSleepForYieldTime: 25
530-
switchRamDiskSpaceSize: 12
531529
ps4NPAgeRating: 12
532530
ps4NPTitleSecret:
533531
ps4NPTrophyPackPath:
@@ -677,7 +675,6 @@ PlayerSettings:
677675
metroFTAName:
678676
metroFTAFileTypes: []
679677
metroProtocolName:
680-
vcxProjDefaultLanguage:
681678
XboxOneProductId:
682679
XboxOneUpdateKey:
683680
XboxOneSandboxId:

com.onesignal.unity.android/Runtime/OneSignalAndroid.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ public override void RemoveTrigger(string key)
170170
=> _sdkClass.CallStatic("removeTriggerForKey", key);
171171

172172
public override void RemoveTriggers(params string[] keys)
173-
=> _sdkClass.CallStatic("removeTriggersForKeys", Json.Serialize(keys));
173+
=> _sdkClass.CallStatic("removeTriggersForKeys", keys.ToArrayList());
174174

175175
public override string GetTrigger(string key) {
176176
var triggerVal = _sdkClass.CallStatic<AndroidJavaObject>("getTriggerValueForKey", key);
@@ -210,7 +210,7 @@ public override async Task<bool> DeleteTag(string key) {
210210

211211
public override async Task<bool> DeleteTags(params string[] keys) {
212212
var proxy = new ChangeTagsUpdateHandler();
213-
_sdkClass.CallStatic("deleteTags", keys.ToList(), proxy);
213+
_sdkClass.CallStatic("deleteTags", keys.ToArrayList(), proxy);
214214
return await proxy;
215215
}
216216

com.onesignal.unity.android/Runtime/Utilities/AndroidJavaObjectExtensions.cs

+10
Original file line numberDiff line numberDiff line change
@@ -111,5 +111,15 @@ public static AndroidJavaObject ToMap(this Dictionary<string, string> source) {
111111
return map;
112112
}
113113

114+
public static AndroidJavaObject ToArrayList(this string[] keys) {
115+
AndroidJavaObject arrayList = new AndroidJavaObject("java.util.ArrayList");
116+
117+
foreach(string key in keys) {
118+
arrayList.Call<bool>("add", key);
119+
}
120+
121+
return arrayList;
122+
}
123+
114124
}
115125
}

com.onesignal.unity.android/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"name": "com.onesignal.unity.android",
33
"displayName": "OneSignal Unity SDK - Android",
4-
"version": "3.0.3",
4+
"version": "3.0.4",
55
"unity": "2018.4",
66
"description": "OneSignal is the market leader in customer engagement, powering mobile push, web push, email, and in-app messages.",
77
"dependencies": {
8-
"com.onesignal.unity.core": "3.0.3"
8+
"com.onesignal.unity.core": "3.0.4"
99
},
1010
"keywords": [
1111
"push-notifications",

com.onesignal.unity.core/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "com.onesignal.unity.core",
33
"displayName": "OneSignal Unity SDK - Core",
4-
"version": "3.0.3",
4+
"version": "3.0.4",
55
"unity": "2018.4",
66
"description": "OneSignal is the market leader in customer engagement, powering mobile push, web push, email, and in-app messages.",
77
"dependencies": {

com.onesignal.unity.ios/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
{
22
"name": "com.onesignal.unity.ios",
33
"displayName": "OneSignal Unity SDK - iOS",
4-
"version": "3.0.3",
4+
"version": "3.0.4",
55
"unity": "2018.4",
66
"description": "OneSignal is the market leader in customer engagement, powering mobile push, web push, email, and in-app messages.",
77
"dependencies": {
8-
"com.onesignal.unity.core": "3.0.3"
8+
"com.onesignal.unity.core": "3.0.4"
99
},
1010
"keywords": [
1111
"push-notifications",

0 commit comments

Comments
 (0)