Skip to content

Commit f8379b4

Browse files
committed
e2e: bump enterSliceMode wait to 500ms for SliceSignUpdater settle
`sliceStepSignRef` is set from `SliceSignUpdater`'s useFrame, which needs the camera projection to stabilize after the URL-driven camera apply. The previous 100ms wasn't enough on CI's slow swiftshader pipeline, leading to flaky failures in slice-direction tests where ArrowRight fired before sign updated.
1 parent caa2bb3 commit f8379b4

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

pkgs/static/e2e/elvis.spec.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,11 @@ async function waitForLoad(page: Page) {
6161
async function enterSliceMode(page: Page) {
6262
await page.locator('body').press('s')
6363
await expect(page.locator('.kbd-mode-indicator-label')).toHaveText('Slice')
64-
// Allow one animation frame for the effective keymap to recompute after mode change
65-
await page.waitForTimeout(100)
64+
// Allow several animation frames so `SliceSignUpdater`'s useFrame can run
65+
// and stabilize `sliceStepSign` based on the current camera projection.
66+
// Without this, ArrowRight may fire while sign is still at its init value
67+
// (1), making sign-dependent slice-direction tests flaky on CI.
68+
await page.waitForTimeout(500)
6669
}
6770

6871
test.describe('Elvis E2E', () => {

0 commit comments

Comments
 (0)