Skip to content

Commit 829f1ff

Browse files
ryan-williamsclaude
andcommitted
ci: pin Node 22 (better-sqlite3 source-compile hangs install on newer lts/*)
`@slidev/cli` depends on the native `better-sqlite3` (added in this fork for the `state.db` event log). `node-version: lts/*` now resolves to a Node LTS with no `better-sqlite3` prebuilt binary, so `nci` falls back to a node-gyp source compile that hangs the runner — CR ran 14 min on install, Smoke hit its 10-min timeout. `pages.yml` already pinned Node 22 and installs in ~21s; pin the rest (cr, smoke, autofix, release, test) to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 49d355f commit 829f1ff

5 files changed

Lines changed: 16 additions & 9 deletions

File tree

.github/workflows/autofix.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,11 @@ jobs:
2020
steps:
2121
- uses: actions/checkout@v6
2222

23-
- name: Use Node.js lts/*
23+
- name: Use Node.js 22
2424
uses: actions/setup-node@v6
2525
with:
26-
node-version: lts/*
26+
# See cr.yml: pin 22, `better-sqlite3` install hangs on newer `lts/*`.
27+
node-version: 22
2728

2829
- name: Setup
2930
run: npm i -g @antfu/ni

.github/workflows/cr.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@ jobs:
2121

2222
- uses: actions/setup-node@v6
2323
with:
24-
node-version: lts/*
24+
# Pinned to 22 (matching pages.yml): `better-sqlite3` has no prebuilt
25+
# binary for newer `lts/*` Nodes, so install falls back to a source
26+
# compile that hangs the runner.
27+
node-version: 22
2528

2629
- run: npm i -g @antfu/ni
2730
- run: nci

.github/workflows/release.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ jobs:
2121

2222
- uses: actions/setup-node@v6
2323
with:
24-
node-version: lts/*
24+
# See cr.yml: pin 22, `better-sqlite3` install hangs on newer `lts/*`.
25+
node-version: 22
2526
registry-url: https://registry.npmjs.org/
2627

2728
- run: npx changelogithub

.github/workflows/smoke.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ jobs:
2828
- name: Use Node.js
2929
uses: actions/setup-node@v6
3030
with:
31-
node-version: lts/*
31+
# See cr.yml: pin 22, `better-sqlite3` install hangs on newer `lts/*`.
32+
node-version: 22
3233

3334
- name: Setup
3435
run: npm i -g @antfu/ni
@@ -68,10 +69,10 @@ jobs:
6869
6970
- uses: actions/checkout@v6
7071

71-
- name: Use Node.js lts/*
72+
- name: Use Node.js 22
7273
uses: actions/setup-node@v6
7374
with:
74-
node-version: lts/*
75+
node-version: 22
7576

7677
- name: Setup
7778
run: npm i -g @antfu/ni

.github/workflows/test.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ jobs:
1818

1919
strategy:
2020
matrix:
21-
node-version: [lts/*]
21+
# Pinned 22 (see cr.yml): `better-sqlite3` install hangs on newer `lts/*`.
22+
node-version: [22]
2223
os: [ubuntu-latest, windows-latest, macos-latest]
2324
# os: [ubuntu-latest, macos-latest]
2425
fail-fast: false
@@ -59,7 +60,7 @@ jobs:
5960

6061
- uses: actions/setup-node@v6
6162
with:
62-
node-version: lts/*
63+
node-version: 22
6364

6465
- name: Setup
6566
run: npm i -g @antfu/ni

0 commit comments

Comments
 (0)