fix: remove double quotes if they exist maybe

Author: rjchow

src/index.test.ts

@@ -68,6 +68,26 @@ describe("parseDocumentStoreResults", () => {
       },
     ]);
   });
+  test("it should correctly handle cases where the TXT record is not double quoted", () => {
+    const sampleRecord = [
+      {
+        name: "example.openattestation.com.",
+        type: 16,
+        TTL: 110,
+        data: "openatts net=ethereum netId=3 addr=0x2f60375e8144e16Adf1979936301D8341D58C36C",
+        dnssec: true,
+      },
+    ];
+    expect(parseDocumentStoreResults(sampleRecord, true)).toStrictEqual([
+      {
+        type: "openatts",
+        net: "ethereum",
+        netId: "3",
+        addr: "0x2f60375e8144e16Adf1979936301D8341D58C36C",
+        dnssec: true,
+      },
+    ]);
+  });
   test("it should return two record items if there are two openatts record", () => {
     const sampleRecord = [
       {

src/index.ts

@@ -84,6 +84,15 @@ const applyDnssecResults = <T>(dnssecStatus: boolean) => (record: T): T => {
   return { ...record, dnssec: dnssecStatus };
 };
 
+/**
+ * Some DNS servers return TXT records with quoted strings, others don't :D
+ * @param record
+ * @returns unquoted DNS record
+ */
+const trimDoubleQuotes = (record: string) => {
+  return record.startsWith('"') ? record.slice(1, -1) : record;
+};
+
 /**
  * Takes a record set and breaks that info array of key value pairs
  * @param recordSet e.g: [{name: "google.com", type: 16, TTL: 3599, data: '"openatts net=ethereum netId=3 addr=0x2f60375e8144e16Adf1979936301D8341D58C36C"}]
@@ -92,7 +101,7 @@ const parseOpenAttestationRecords = (recordSet: IDNSRecord[] = []): GenericObjec
   trace(`Parsing DNS results: ${JSON.stringify(recordSet)}`);
   return recordSet
     .map((record) => record.data)
-    .map((record) => record.slice(1, -1)) // removing leading and trailing quotes
+    .map(trimDoubleQuotes) // removing leading and trailing quotes if they exist
     .filter(isOpenAttestationRecord)
     .map(parseOpenAttestationRecord);
 };