defining payload data type for watch window command

Author: omarArm

src/views/live-watch/live-watch.ts

@@ -141,8 +141,14 @@ export class LiveWatchTreeDataProvider implements vscode.TreeDataProvider<LiveWa
         const modifyCommand = vscode.commands.registerCommand('vscode-cmsis-debugger.liveWatch.modify', async (node) => await this.registerRenameCommand(node));
         const copyCommand = vscode.commands.registerCommand('vscode-cmsis-debugger.liveWatch.copy', async (node) => { await this.registerCopyCommand(node); });
         const addToLiveWatchCommand = vscode.commands.registerCommand('vscode-cmsis-debugger.liveWatch.addToLiveWatchFromTextEditor', async () => { await this.registerAddFromSelectionCommand(); });
-        const addToLiveWatchFromWatchWindowCommand = vscode.commands.registerCommand('vscode-cmsis-debugger.liveWatch.addToLiveWatchFromWatchWindow', async (expression) => { await this.registerAddToLiveWatchFromWatchWindow(expression); });
-        const addToLiveWatchFromVariablesViewCommand = vscode.commands.registerCommand('vscode-cmsis-debugger.liveWatch.addToLiveWatchFromVariablesView', async (payload: { container: DebugProtocol.Scope; variable: DebugProtocol.Variable;}) => { await this.registerAddToLiveWatchFromVariablesView(payload); });
+        /* I am using the same callback function for both watch window and variables view, as they have the same payload structure for now. 
+           However, I believe the payload structure will change for the watch window in the future as the developer who created the PR for contributing to watch window context menu
+           mentioned he used variables' window payload structure for simplicity.
+           Find the PR here:
+           https://github.com/microsoft/vscode/pull/237751
+        */
+        const addToLiveWatchFromWatchWindowCommand = vscode.commands.registerCommand('vscode-cmsis-debugger.liveWatch.addToLiveWatchFromWatchWindow', async (payload: { container: DebugProtocol.Scope; variable: DebugProtocol.Variable; }) => { await this.registerAddToLiveWatchFromVariablesView(payload); });
+        const addToLiveWatchFromVariablesViewCommand = vscode.commands.registerCommand('vscode-cmsis-debugger.liveWatch.addToLiveWatchFromVariablesView', async (payload: { container: DebugProtocol.Scope; variable: DebugProtocol.Variable; }) => { await this.registerAddToLiveWatchFromVariablesView(payload); });
         this._context.subscriptions.push(registerLiveWatchView,
             addCommand,
             deleteAllCommand, deleteCommand, refreshCommand, modifyCommand, copyCommand, addToLiveWatchCommand, addToLiveWatchFromWatchWindowCommand, addToLiveWatchFromVariablesViewCommand);
@@ -201,13 +207,6 @@ export class LiveWatchTreeDataProvider implements vscode.TreeDataProvider<LiveWa
         await this.addToRoots(selectedText);
     }
 
-    private async registerAddToLiveWatchFromWatchWindow(expression: any) {
-        if (!expression) {
-            return;
-        }
-        await this.addToRoots(expression.variable.name);
-    }
-
     private async registerAddToLiveWatchFromVariablesView(payload: { container: DebugProtocol.Scope; variable: DebugProtocol.Variable;}) {
         if (!payload || !payload.variable) {
             return;