Skip to content

Commit 7e9f177

Browse files
authored
Enabled recommended eslint-plugin-security lint rules (#360)
* Enabled recommended eslint-plugin-security lint rules * Enabling scan for test code
1 parent b673bfb commit 7e9f177

File tree

3 files changed

+41
-44
lines changed

3 files changed

+41
-44
lines changed

eslint.config.mjs

Lines changed: 20 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@
1414
* limitations under the License.
1515
*/
1616

17-
import js from '@eslint/js';
18-
import tseslint from 'typescript-eslint';
17+
import js from "@eslint/js";
18+
import tseslint from "typescript-eslint";
19+
import eslintPluginSecurity from "eslint-plugin-security";
1920

2021
export default [
2122
{
@@ -35,7 +36,8 @@ export default [
3536
{
3637
files: ['**/*.ts', '**/*.js'],
3738
plugins: {
38-
"@typescript-eslint": tseslint.plugin
39+
"@typescript-eslint": tseslint.plugin,
40+
security: eslintPluginSecurity,
3941
},
4042
languageOptions: {
4143
ecmaVersion: 9,
@@ -48,52 +50,27 @@ export default [
4850
}
4951
},
5052
rules: {
53+
// TypeScript-specific
5154
"@typescript-eslint/no-unused-vars": [
5255
"warn",
5356
{
5457
"argsIgnorePattern": "^_"
5558
}
5659
],
57-
"block-spacing": [
58-
"error",
59-
"always"
60-
],
61-
"brace-style": [
62-
"error",
63-
"1tbs",
64-
{
65-
"allowSingleLine": true
66-
}
67-
],
68-
"eol-last": [
69-
"error"
70-
],
71-
"indent": [
72-
"error",
73-
4,
74-
{
75-
"SwitchCase": 1
76-
}
77-
],
78-
"linebreak-style": [
79-
"error",
80-
"unix"
81-
],
82-
"no-trailing-spaces": [
83-
"error"
84-
],
85-
"object-curly-spacing": [
86-
"error",
87-
"always"
88-
],
89-
"quotes": [
90-
"error",
91-
"single"
92-
],
93-
"semi": [
94-
"error",
95-
"always"
96-
]
60+
61+
// Security rules
62+
...eslintPluginSecurity.configs.recommended.rules,
63+
64+
// Code style rules
65+
"block-spacing": ["error", "always"],
66+
"brace-style": ["error", "1tbs", { allowSingleLine: true }],
67+
"eol-last": ["error"],
68+
"indent": ["error", 4, { SwitchCase: 1 }],
69+
"linebreak-style": ["error", "unix"],
70+
"no-trailing-spaces": ["error"],
71+
"object-curly-spacing": ["error", "always"],
72+
"quotes": ["error", "single"],
73+
"semi": ["error", "always"],
9774
},
9875
}
9976
];

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,11 +116,12 @@
116116
"@vscode/vsce": "^3.6.0",
117117
"@yarnpkg/lockfile": "^1.1.0",
118118
"eslint": "^9.30.1",
119+
"eslint-plugin-security": "^3.0.1",
119120
"extract-zip": "^2.0.1",
120121
"globby": "^14.1.0",
121122
"jest": "^30.0.4",
122-
"markdownlint-cli": "^0.45.0",
123123
"markdown-link-check": "^3.13.7",
124+
"markdownlint-cli": "^0.45.0",
124125
"node-fetch": "^3.3.2",
125126
"octokit": "^5.0.3",
126127
"tempfile": "^5.0.0",

yarn.lock

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2939,6 +2939,13 @@ escodegen@^2.1.0:
29392939
optionalDependencies:
29402940
source-map "~0.6.1"
29412941

2942+
eslint-plugin-security@^3.0.1:
2943+
version "3.0.1"
2944+
resolved "https://registry.yarnpkg.com/eslint-plugin-security/-/eslint-plugin-security-3.0.1.tgz#bc52904f77c3b74c3942e12bdb0751831a3223d2"
2945+
integrity sha512-XjVGBhtDZJfyuhIxnQ/WMm385RbX3DBu7H1J7HNNhmB2tnGxMeqVSnYv79oAj992ayvIBZghsymwkYFS6cGH4Q==
2946+
dependencies:
2947+
safe-regex "^2.1.1"
2948+
29422949
29432950
version "5.1.1"
29442951
resolved "https://registry.npmjs.org/eslint-scope/-/eslint-scope-5.1.1.tgz"
@@ -5485,6 +5492,11 @@ reduce-flatten@^2.0.0:
54855492
resolved "https://registry.npmjs.org/reduce-flatten/-/reduce-flatten-2.0.0.tgz"
54865493
integrity sha512-EJ4UNY/U1t2P/2k6oqotuX2Cc3T6nxJwsM0N0asT7dhrtH1ltUxDn4NalSYmPE2rCkVpcf/X6R0wDwcFpzhd4w==
54875494

5495+
regexp-tree@~0.1.1:
5496+
version "0.1.27"
5497+
resolved "https://registry.yarnpkg.com/regexp-tree/-/regexp-tree-0.1.27.tgz#2198f0ef54518ffa743fe74d983b56ffd631b6cd"
5498+
integrity sha512-iETxpjK6YoRWJG5o6hXLwvjYAoW+FEZn9os0PD/b6AP6xQwsa/Y7lCVgIixBbUPMfhu+i2LtdeAqVTgGlQarfA==
5499+
54885500
require-directory@^2.1.1:
54895501
version "2.1.1"
54905502
resolved "https://registry.npmjs.org/require-directory/-/require-directory-2.1.1.tgz"
@@ -5548,6 +5560,13 @@ safe-buffer@^5.0.1, safe-buffer@^5.1.0, safe-buffer@~5.2.0:
55485560
resolved "https://registry.npmjs.org/safe-buffer/-/safe-buffer-5.2.1.tgz"
55495561
integrity sha512-rp3So07KcdmmKbGvgaNxQSJr7bGVSVk5S9Eq1F+ppbRo70+YeaDxkw5Dd8NPN+GD6bjnYm2VuPuCXmpuYvmCXQ==
55505562

5563+
safe-regex@^2.1.1:
5564+
version "2.1.1"
5565+
resolved "https://registry.yarnpkg.com/safe-regex/-/safe-regex-2.1.1.tgz#f7128f00d056e2fe5c11e81a1324dd974aadced2"
5566+
integrity sha512-rx+x8AMzKb5Q5lQ95Zoi6ZbJqwCLkqi3XuJXp5P3rT8OEc6sZCJG5AE5dU3lsgRr/F4Bs31jSlVN+j5KrsGu9A==
5567+
dependencies:
5568+
regexp-tree "~0.1.1"
5569+
55515570
"safer-buffer@>= 2.1.2 < 3.0.0":
55525571
version "2.1.2"
55535572
resolved "https://registry.npmjs.org/safer-buffer/-/safer-buffer-2.1.2.tgz"

0 commit comments

Comments
 (0)