Modeling - Simplify GeomGridEval classes (#1031)

- Removed point evaluation methods from surface evaluators (Torus, Sphere, Cylinder, Cone, Plane, BSpline, Bezier, SurfaceOfRevolution, SurfaceOfExtrusion, OffsetSurface, OtherSurface)
- Simplified BSplineSurface and BSplineCurve evaluation implementations with cleaner helper templates
- Updated utility functions to use surface adaptors directly instead of grid evaluators
- Removed corresponding test cases for point-based evaluation methods
- Cleaned up unused includes (`gp_Pnt2d.hxx`) and helper structures (`UVPoint`, `UVPointWithSpan`

Author: dpasukhi

src/ModelingAlgorithms/TKGeomAlgo/IntCurveSurface/IntCurveSurface_PolyhedronUtils.pxx

@@ -14,15 +14,16 @@
 #ifndef IntCurveSurface_PolyhedronUtils_pxx_HeaderFile
 #define IntCurveSurface_PolyhedronUtils_pxx_HeaderFile
 
+#include <Adaptor3d_Surface.hxx>
 #include <Bnd_Box.hxx>
-#include <NCollection_Array1.hxx>
-#include <NCollection_HArray1.hxx>
 #include <GeomGridEval_Surface.hxx>
 #include <gp.hxx>
 #include <gp_Pnt.hxx>
 #include <gp_Vec.hxx>
 #include <gp_XYZ.hxx>
+#include <NCollection_Array1.hxx>
 #include <NCollection_Array2.hxx>
+#include <NCollection_HArray1.hxx>
 #include <Standard_Real.hxx>
 
 //! Utility functions for polyhedron discretization of surfaces.
@@ -622,45 +623,21 @@ inline double ComputeDeflectionWithCenter(const gp_Pnt& theP1,
   return std::abs(P1P.Dot(NormalVector));
 }
 
-//! Compute the maximum deflection over all triangles using batch evaluation.
-//! Uses GeomGridEval_Surface::EvaluatePoints() to batch-evaluate all triangle centroids.
+//! Compute the maximum deflection over all triangles.
+//! Evaluates triangle centroids individually using the surface adaptor.
 //! @tparam PolyhedronType Type of polyhedron class
-//! @param[in] theEval        Pre-initialized grid evaluator
+//! @param[in] theSurface     Surface adaptor for point evaluation
 //! @param[in] thePolyhedron  The polyhedron object (provides Triangle/Point access)
 //! @param[in] theNbTriangles Number of triangles
 //! @return Maximum deflection value
 template <typename PolyhedronType>
-double ComputeMaxDeflection(GeomGridEval_Surface& theEval,
-                            const PolyhedronType& thePolyhedron,
-                            const int             theNbTriangles)
+double ComputeMaxDeflection(const Adaptor3d_Surface& theSurface,
+                            const PolyhedronType&    thePolyhedron,
+                            const int                theNbTriangles)
 {
   if (theNbTriangles <= 0)
     return 0.0;
 
-  // Collect all triangle centroid UV pairs
-  NCollection_Array1<gp_Pnt2d> aCentroidUVs(1, theNbTriangles);
-
-  for (int i = 1; i <= theNbTriangles; ++i)
-  {
-    int i1, i2, i3;
-    thePolyhedron.Triangle(i, i1, i2, i3);
-
-    double u1, v1, u2, v2, u3, v3;
-    thePolyhedron.Point(i1, u1, v1);
-    thePolyhedron.Point(i2, u2, v2);
-    thePolyhedron.Point(i3, u3, v3);
-
-    const double uCenter = (u1 + u2 + u3) / 3.0;
-    const double vCenter = (v1 + v2 + v3) / 3.0;
-    aCentroidUVs.SetValue(i, gp_Pnt2d(uCenter, vCenter));
-  }
-
-  // Batch evaluate all centroids
-  NCollection_Array1<gp_Pnt> aCenterPoints = theEval.EvaluatePoints(aCentroidUVs);
-  if (aCenterPoints.IsEmpty())
-    return 0.0;
-
-  // Compute max deflection using pre-evaluated center points
   double tol = 0.0;
   for (int i = 1; i <= theNbTriangles; ++i)
   {
@@ -672,7 +649,13 @@ double ComputeMaxDeflection(GeomGridEval_Surface& theEval,
     const gp_Pnt P2 = thePolyhedron.Point(i2, u2, v2);
     const gp_Pnt P3 = thePolyhedron.Point(i3, u3, v3);
 
-    const double tol1 = ComputeDeflectionWithCenter(P1, P2, P3, aCenterPoints.Value(i));
+    const double uCenter = (u1 + u2 + u3) / 3.0;
+    const double vCenter = (v1 + v2 + v3) / 3.0;
+
+    gp_Pnt aCenter;
+    theSurface.D0(uCenter, vCenter, aCenter);
+
+    const double tol1 = ComputeDeflectionWithCenter(P1, P2, P3, aCenter);
     if (tol1 > tol)
       tol = tol1;
   }

src/ModelingAlgorithms/TKGeomAlgo/IntCurveSurface/IntCurveSurface_ThePolyhedronOfHInter.cxx

@@ -103,7 +103,7 @@ void IntCurveSurface_ThePolyhedronOfHInter::Init(const occ::handle<Adaptor3d_Sur
                          static_cast<bool*>(C_MyIsOnBounds),
                          TheBnd);
 
-  double tol = PolyUtils::ComputeMaxDeflection(anEval, *this, NbTriangles());
+  double tol = PolyUtils::ComputeMaxDeflection(*Surface, *this, NbTriangles());
   DeflectionOverEstimation(tol * 1.2);
   FillBounding();
 
@@ -132,7 +132,7 @@ void IntCurveSurface_ThePolyhedronOfHInter::Init(const occ::handle<Adaptor3d_Sur
                             static_cast<bool*>(C_MyIsOnBounds),
                             TheBnd);
 
-  double tol = PolyUtils::ComputeMaxDeflection(anEval, *this, NbTriangles());
+  double tol = PolyUtils::ComputeMaxDeflection(*Surface, *this, NbTriangles());
   DeflectionOverEstimation(tol * 1.2);
   FillBounding();
 

src/ModelingAlgorithms/TKGeomAlgo/IntPatch/IntPatch_Polyhedron.cxx

@@ -129,8 +129,8 @@ IntPatch_Polyhedron::IntPatch_Polyhedron(const occ::handle<Adaptor3d_Surface>& S
     }
   }
 
-  // Compute max deflection using batch evaluation
-  double tol = PolyUtils::ComputeMaxDeflection(anEval, *this, NbTriangles());
+  // Compute max deflection using surface adaptor
+  double tol = PolyUtils::ComputeMaxDeflection(*Surface, *this, NbTriangles());
   tol *= DEFLECTION_COEFF;
 
   DeflectionOverEstimation(tol);
@@ -200,8 +200,8 @@ IntPatch_Polyhedron::IntPatch_Polyhedron(const occ::handle<Adaptor3d_Surface>& S
     }
   }
 
-  // Compute max deflection using batch evaluation
-  double tol = PolyUtils::ComputeMaxDeflection(anEval, *this, NbTriangles());
+  // Compute max deflection using surface adaptor
+  double tol = PolyUtils::ComputeMaxDeflection(*Surface, *this, NbTriangles());
   tol *= DEFLECTION_COEFF;
 
   DeflectionOverEstimation(tol);

src/ModelingAlgorithms/TKHLR/HLRBRep/HLRBRep_ThePolyhedronOfInterCSurf.cxx

@@ -102,7 +102,7 @@ void HLRBRep_ThePolyhedronOfInterCSurf::Init(HLRBRep_Surface* Surface,
                          static_cast<bool*>(C_MyIsOnBounds),
                          TheBnd);
 
-  double tol = PolyUtils::ComputeMaxDeflection(anEval, *this, NbTriangles());
+  double tol = PolyUtils::ComputeMaxDeflection(Surface->Surface(), *this, NbTriangles());
   DeflectionOverEstimation(tol * 1.2);
   FillBounding();
 
@@ -131,7 +131,7 @@ void HLRBRep_ThePolyhedronOfInterCSurf::Init(HLRBRep_Surface*                  S
                             static_cast<bool*>(C_MyIsOnBounds),
                             TheBnd);
 
-  double tol = PolyUtils::ComputeMaxDeflection(anEval, *this, NbTriangles());
+  double tol = PolyUtils::ComputeMaxDeflection(Surface->Surface(), *this, NbTriangles());
   DeflectionOverEstimation(tol * 1.2);
   FillBounding();