Skip to content

Commit 0551504

Browse files
authored
[csharp-netcore]Fixed the null serialization issue for dotnet47 (#7884)
* Fixed the null serialization issue for dotnet47 * c# codeing style * Updated the sample for csharp netcore * corrected the typos
1 parent bc76d8e commit 0551504

File tree

32 files changed

+160
-32
lines changed

32 files changed

+160
-32
lines changed

modules/openapi-generator/src/main/resources/csharp-netcore/modelAnyOf.mustache

+5-1
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,11 @@
208208
/// <returns>The object converted from the JSON string</returns>
209209
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
210210
{
211-
return {{classname}}.FromJson(JObject.Load(reader).ToString(Formatting.None));
211+
if(reader.TokenType != JsonToken.Null)
212+
{
213+
return {{classname}}.FromJson(JObject.Load(reader).ToString(Formatting.None));
214+
}
215+
return null;
212216
}
213217

214218
/// <summary>

modules/openapi-generator/src/main/resources/csharp-netcore/modelOneOf.mustache

+5-1
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,11 @@
237237
/// <returns>The object converted from the JSON string</returns>
238238
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
239239
{
240-
return {{classname}}.FromJson(JObject.Load(reader).ToString(Formatting.None));
240+
if(reader.TokenType != JsonToken.Null)
241+
{
242+
return {{classname}}.FromJson(JObject.Load(reader).ToString(Formatting.None));
243+
}
244+
return null;
241245
}
242246

243247
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient-net47/src/Org.OpenAPITools/Model/Fruit.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
254254
/// <returns>The object converted from the JSON string</returns>
255255
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
256256
{
257-
return Fruit.FromJson(JObject.Load(reader).ToString(Formatting.None));
257+
if(reader.TokenType != JsonToken.Null)
258+
{
259+
return Fruit.FromJson(JObject.Load(reader).ToString(Formatting.None));
260+
}
261+
return null;
258262
}
259263

260264
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient-net47/src/Org.OpenAPITools/Model/FruitReq.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
263263
/// <returns>The object converted from the JSON string</returns>
264264
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
265265
{
266-
return FruitReq.FromJson(JObject.Load(reader).ToString(Formatting.None));
266+
if(reader.TokenType != JsonToken.Null)
267+
{
268+
return FruitReq.FromJson(JObject.Load(reader).ToString(Formatting.None));
269+
}
270+
return null;
267271
}
268272

269273
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient-net47/src/Org.OpenAPITools/Model/GmFruit.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
242242
/// <returns>The object converted from the JSON string</returns>
243243
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
244244
{
245-
return GmFruit.FromJson(JObject.Load(reader).ToString(Formatting.None));
245+
if(reader.TokenType != JsonToken.Null)
246+
{
247+
return GmFruit.FromJson(JObject.Load(reader).ToString(Formatting.None));
248+
}
249+
return null;
246250
}
247251

248252
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient-net47/src/Org.OpenAPITools/Model/Mammal.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
311311
/// <returns>The object converted from the JSON string</returns>
312312
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
313313
{
314-
return Mammal.FromJson(JObject.Load(reader).ToString(Formatting.None));
314+
if(reader.TokenType != JsonToken.Null)
315+
{
316+
return Mammal.FromJson(JObject.Load(reader).ToString(Formatting.None));
317+
}
318+
return null;
315319
}
316320

317321
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient-net47/src/Org.OpenAPITools/Model/NullableShape.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
279279
/// <returns>The object converted from the JSON string</returns>
280280
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
281281
{
282-
return NullableShape.FromJson(JObject.Load(reader).ToString(Formatting.None));
282+
if(reader.TokenType != JsonToken.Null)
283+
{
284+
return NullableShape.FromJson(JObject.Load(reader).ToString(Formatting.None));
285+
}
286+
return null;
283287
}
284288

285289
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient-net47/src/Org.OpenAPITools/Model/Pig.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
270270
/// <returns>The object converted from the JSON string</returns>
271271
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
272272
{
273-
return Pig.FromJson(JObject.Load(reader).ToString(Formatting.None));
273+
if(reader.TokenType != JsonToken.Null)
274+
{
275+
return Pig.FromJson(JObject.Load(reader).ToString(Formatting.None));
276+
}
277+
return null;
274278
}
275279

276280
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient-net47/src/Org.OpenAPITools/Model/Quadrilateral.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
270270
/// <returns>The object converted from the JSON string</returns>
271271
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
272272
{
273-
return Quadrilateral.FromJson(JObject.Load(reader).ToString(Formatting.None));
273+
if(reader.TokenType != JsonToken.Null)
274+
{
275+
return Quadrilateral.FromJson(JObject.Load(reader).ToString(Formatting.None));
276+
}
277+
return null;
274278
}
275279

276280
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient-net47/src/Org.OpenAPITools/Model/Shape.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
270270
/// <returns>The object converted from the JSON string</returns>
271271
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
272272
{
273-
return Shape.FromJson(JObject.Load(reader).ToString(Formatting.None));
273+
if(reader.TokenType != JsonToken.Null)
274+
{
275+
return Shape.FromJson(JObject.Load(reader).ToString(Formatting.None));
276+
}
277+
return null;
274278
}
275279

276280
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient-net47/src/Org.OpenAPITools/Model/ShapeOrNull.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
279279
/// <returns>The object converted from the JSON string</returns>
280280
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
281281
{
282-
return ShapeOrNull.FromJson(JObject.Load(reader).ToString(Formatting.None));
282+
if(reader.TokenType != JsonToken.Null)
283+
{
284+
return ShapeOrNull.FromJson(JObject.Load(reader).ToString(Formatting.None));
285+
}
286+
return null;
283287
}
284288

285289
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient-net47/src/Org.OpenAPITools/Model/Triangle.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
311311
/// <returns>The object converted from the JSON string</returns>
312312
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
313313
{
314-
return Triangle.FromJson(JObject.Load(reader).ToString(Formatting.None));
314+
if(reader.TokenType != JsonToken.Null)
315+
{
316+
return Triangle.FromJson(JObject.Load(reader).ToString(Formatting.None));
317+
}
318+
return null;
315319
}
316320

317321
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools/Model/Fruit.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
254254
/// <returns>The object converted from the JSON string</returns>
255255
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
256256
{
257-
return Fruit.FromJson(JObject.Load(reader).ToString(Formatting.None));
257+
if(reader.TokenType != JsonToken.Null)
258+
{
259+
return Fruit.FromJson(JObject.Load(reader).ToString(Formatting.None));
260+
}
261+
return null;
258262
}
259263

260264
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools/Model/FruitReq.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
263263
/// <returns>The object converted from the JSON string</returns>
264264
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
265265
{
266-
return FruitReq.FromJson(JObject.Load(reader).ToString(Formatting.None));
266+
if(reader.TokenType != JsonToken.Null)
267+
{
268+
return FruitReq.FromJson(JObject.Load(reader).ToString(Formatting.None));
269+
}
270+
return null;
267271
}
268272

269273
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools/Model/GmFruit.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
242242
/// <returns>The object converted from the JSON string</returns>
243243
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
244244
{
245-
return GmFruit.FromJson(JObject.Load(reader).ToString(Formatting.None));
245+
if(reader.TokenType != JsonToken.Null)
246+
{
247+
return GmFruit.FromJson(JObject.Load(reader).ToString(Formatting.None));
248+
}
249+
return null;
246250
}
247251

248252
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools/Model/Mammal.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
311311
/// <returns>The object converted from the JSON string</returns>
312312
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
313313
{
314-
return Mammal.FromJson(JObject.Load(reader).ToString(Formatting.None));
314+
if(reader.TokenType != JsonToken.Null)
315+
{
316+
return Mammal.FromJson(JObject.Load(reader).ToString(Formatting.None));
317+
}
318+
return null;
315319
}
316320

317321
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools/Model/NullableShape.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
279279
/// <returns>The object converted from the JSON string</returns>
280280
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
281281
{
282-
return NullableShape.FromJson(JObject.Load(reader).ToString(Formatting.None));
282+
if(reader.TokenType != JsonToken.Null)
283+
{
284+
return NullableShape.FromJson(JObject.Load(reader).ToString(Formatting.None));
285+
}
286+
return null;
283287
}
284288

285289
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools/Model/Pig.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
270270
/// <returns>The object converted from the JSON string</returns>
271271
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
272272
{
273-
return Pig.FromJson(JObject.Load(reader).ToString(Formatting.None));
273+
if(reader.TokenType != JsonToken.Null)
274+
{
275+
return Pig.FromJson(JObject.Load(reader).ToString(Formatting.None));
276+
}
277+
return null;
274278
}
275279

276280
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools/Model/Quadrilateral.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
270270
/// <returns>The object converted from the JSON string</returns>
271271
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
272272
{
273-
return Quadrilateral.FromJson(JObject.Load(reader).ToString(Formatting.None));
273+
if(reader.TokenType != JsonToken.Null)
274+
{
275+
return Quadrilateral.FromJson(JObject.Load(reader).ToString(Formatting.None));
276+
}
277+
return null;
274278
}
275279

276280
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools/Model/Shape.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
270270
/// <returns>The object converted from the JSON string</returns>
271271
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
272272
{
273-
return Shape.FromJson(JObject.Load(reader).ToString(Formatting.None));
273+
if(reader.TokenType != JsonToken.Null)
274+
{
275+
return Shape.FromJson(JObject.Load(reader).ToString(Formatting.None));
276+
}
277+
return null;
274278
}
275279

276280
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools/Model/ShapeOrNull.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
279279
/// <returns>The object converted from the JSON string</returns>
280280
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
281281
{
282-
return ShapeOrNull.FromJson(JObject.Load(reader).ToString(Formatting.None));
282+
if(reader.TokenType != JsonToken.Null)
283+
{
284+
return ShapeOrNull.FromJson(JObject.Load(reader).ToString(Formatting.None));
285+
}
286+
return null;
283287
}
284288

285289
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClient/src/Org.OpenAPITools/Model/Triangle.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
311311
/// <returns>The object converted from the JSON string</returns>
312312
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
313313
{
314-
return Triangle.FromJson(JObject.Load(reader).ToString(Formatting.None));
314+
if(reader.TokenType != JsonToken.Null)
315+
{
316+
return Triangle.FromJson(JObject.Load(reader).ToString(Formatting.None));
317+
}
318+
return null;
315319
}
316320

317321
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClientCore/src/Org.OpenAPITools/Model/Fruit.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
254254
/// <returns>The object converted from the JSON string</returns>
255255
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
256256
{
257-
return Fruit.FromJson(JObject.Load(reader).ToString(Formatting.None));
257+
if(reader.TokenType != JsonToken.Null)
258+
{
259+
return Fruit.FromJson(JObject.Load(reader).ToString(Formatting.None));
260+
}
261+
return null;
258262
}
259263

260264
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClientCore/src/Org.OpenAPITools/Model/FruitReq.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
263263
/// <returns>The object converted from the JSON string</returns>
264264
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
265265
{
266-
return FruitReq.FromJson(JObject.Load(reader).ToString(Formatting.None));
266+
if(reader.TokenType != JsonToken.Null)
267+
{
268+
return FruitReq.FromJson(JObject.Load(reader).ToString(Formatting.None));
269+
}
270+
return null;
267271
}
268272

269273
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClientCore/src/Org.OpenAPITools/Model/GmFruit.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
242242
/// <returns>The object converted from the JSON string</returns>
243243
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
244244
{
245-
return GmFruit.FromJson(JObject.Load(reader).ToString(Formatting.None));
245+
if(reader.TokenType != JsonToken.Null)
246+
{
247+
return GmFruit.FromJson(JObject.Load(reader).ToString(Formatting.None));
248+
}
249+
return null;
246250
}
247251

248252
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClientCore/src/Org.OpenAPITools/Model/Mammal.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
293293
/// <returns>The object converted from the JSON string</returns>
294294
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
295295
{
296-
return Mammal.FromJson(JObject.Load(reader).ToString(Formatting.None));
296+
if(reader.TokenType != JsonToken.Null)
297+
{
298+
return Mammal.FromJson(JObject.Load(reader).ToString(Formatting.None));
299+
}
300+
return null;
297301
}
298302

299303
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClientCore/src/Org.OpenAPITools/Model/NullableShape.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
264264
/// <returns>The object converted from the JSON string</returns>
265265
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
266266
{
267-
return NullableShape.FromJson(JObject.Load(reader).ToString(Formatting.None));
267+
if(reader.TokenType != JsonToken.Null)
268+
{
269+
return NullableShape.FromJson(JObject.Load(reader).ToString(Formatting.None));
270+
}
271+
return null;
268272
}
269273

270274
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClientCore/src/Org.OpenAPITools/Model/Pig.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
255255
/// <returns>The object converted from the JSON string</returns>
256256
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
257257
{
258-
return Pig.FromJson(JObject.Load(reader).ToString(Formatting.None));
258+
if(reader.TokenType != JsonToken.Null)
259+
{
260+
return Pig.FromJson(JObject.Load(reader).ToString(Formatting.None));
261+
}
262+
return null;
259263
}
260264

261265
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClientCore/src/Org.OpenAPITools/Model/Quadrilateral.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
255255
/// <returns>The object converted from the JSON string</returns>
256256
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
257257
{
258-
return Quadrilateral.FromJson(JObject.Load(reader).ToString(Formatting.None));
258+
if(reader.TokenType != JsonToken.Null)
259+
{
260+
return Quadrilateral.FromJson(JObject.Load(reader).ToString(Formatting.None));
261+
}
262+
return null;
259263
}
260264

261265
/// <summary>

samples/client/petstore/csharp-netcore/OpenAPIClientCore/src/Org.OpenAPITools/Model/Shape.cs

+5-1
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,11 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
255255
/// <returns>The object converted from the JSON string</returns>
256256
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
257257
{
258-
return Shape.FromJson(JObject.Load(reader).ToString(Formatting.None));
258+
if(reader.TokenType != JsonToken.Null)
259+
{
260+
return Shape.FromJson(JObject.Load(reader).ToString(Formatting.None));
261+
}
262+
return null;
259263
}
260264

261265
/// <summary>

0 commit comments

Comments
 (0)