Skip to content

Commit 1607dfb

Browse files
committed
remove includeEndpointUrl
1 parent 94e8997 commit 1607dfb

File tree

59 files changed

+347
-11
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+347
-11
lines changed

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/TypeScriptAngularClientCodegen.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ public static enum PROVIDED_IN_LEVEL {none, root, any, platform}
8383
public static final String RXJS_VERSION = "rxjsVersion";
8484
public static final String NGPACKAGR_VERSION = "ngPackagrVersion";
8585
public static final String ZONEJS_VERSION = "zonejsVersion";
86-
public static final String INCLUDE_ENDPOINT_URL = "includeEndpointUrl";
8786

8887
protected String ngVersion = "20.0.0";
8988
@Getter @Setter
@@ -156,7 +155,6 @@ public TypeScriptAngularClientCodegen() {
156155
this.cliOptions.add(new CliOption(RXJS_VERSION, "The version of RxJS compatible with Angular (see ngVersion option)."));
157156
this.cliOptions.add(new CliOption(NGPACKAGR_VERSION, "The version of ng-packagr compatible with Angular (see ngVersion option)."));
158157
this.cliOptions.add(new CliOption(ZONEJS_VERSION, "The version of zone.js compatible with Angular (see ngVersion option)."));
159-
this.cliOptions.add(CliOption.newBoolean(INCLUDE_ENDPOINT_URL, "Include endpoint URL as comment in generated service methods.", false));
160158
}
161159

162160
@Override
@@ -311,11 +309,6 @@ public void processOpts() {
311309
additionalProperties.put("isQueryParamObjectFormatJson", getQueryParamObjectFormatJson());
312310
additionalProperties.put("isQueryParamObjectFormatKey", getQueryParamObjectFormatKey());
313311

314-
if (additionalProperties.containsKey(INCLUDE_ENDPOINT_URL)) {
315-
boolean includeEndpointUrl = Boolean.parseBoolean(additionalProperties.get(INCLUDE_ENDPOINT_URL).toString());
316-
additionalProperties.put(INCLUDE_ENDPOINT_URL, includeEndpointUrl);
317-
}
318-
319312
}
320313

321314
@Data

modules/openapi-generator/src/main/resources/typescript-angular/api.service.mustache

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,7 @@ export class {{classname}} extends BaseService {
7474
{{#notes}}
7575
* {{.}}
7676
{{/notes}}
77-
{{#includeEndpointUrl}}
7877
* @endpoint {{httpMethod}} {{{path}}}
79-
{{/includeEndpointUrl}}
8078
{{^useSingleRequestParameter}}
8179
{{#allParams}}
8280
* @param {{paramName}} {{description}}

modules/openapi-generator/src/main/resources/typescript-angular/apiInterface.mustache

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,7 @@ export interface {{classname}}Interface {
3838
/**
3939
* {{summary}}
4040
* {{notes}}
41-
{{#includeEndpointUrl}}
4241
* @endpoint {{httpMethod}} {{{path}}}
43-
{{/includeEndpointUrl}}
4442
{{^useSingleRequestParameter}}
4543
{{#allParams}}* @param {{paramName}} {{description}}
4644
{{/allParams}}{{/useSingleRequestParameter}}{{#useSingleRequestParameter}}{{#allParams.0}}* @param requestParameters

samples/client/others/typescript-angular/builds/composed-schemas-tagged-unions/api/pet.service.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export class PetService extends BaseService {
3636
}
3737

3838
/**
39+
* @endpoint get /pet/mapped
3940
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
4041
* @param reportProgress flag to report request and response progress.
4142
*/

samples/client/others/typescript-angular/builds/composed-schemas/api/pet.service.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export class PetService extends BaseService {
3636
}
3737

3838
/**
39+
* @endpoint get /pet/mapped
3940
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
4041
* @param reportProgress flag to report request and response progress.
4142
*/

samples/client/petstore/typescript-angular-v12-oneOf/builds/default/api/default.service.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export class DefaultService extends BaseService {
3636
}
3737

3838
/**
39+
* @endpoint get /
3940
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
4041
* @param reportProgress flag to report request and response progress.
4142
*/
@@ -82,6 +83,7 @@ export class DefaultService extends BaseService {
8283
}
8384

8485
/**
86+
* @endpoint put /
8587
* @param body
8688
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
8789
* @param reportProgress flag to report request and response progress.

samples/client/petstore/typescript-angular-v12-provided-in-any/builds/default/api/pet.service.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ export class PetService extends BaseService {
3939

4040
/**
4141
* Add a new pet to the store
42+
* @endpoint post /pet
4243
* @param body Pet object that needs to be added to the store
4344
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
4445
* @param reportProgress flag to report request and response progress.
@@ -103,6 +104,7 @@ export class PetService extends BaseService {
103104

104105
/**
105106
* Deletes a pet
107+
* @endpoint delete /pet/${this.configuration.encodeParam({name: "petId", value: petId, in: "path", style: "simple", explode: false, dataType: "number", dataFormat: "int64"})}
106108
* @param petId Pet id to delete
107109
* @param apiKey
108110
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
@@ -161,6 +163,7 @@ export class PetService extends BaseService {
161163
/**
162164
* Finds Pets by status
163165
* Multiple status values can be provided with comma separated strings
166+
* @endpoint get /pet/findByStatus
164167
* @param status Status values that need to be considered for filter
165168
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
166169
* @param reportProgress flag to report request and response progress.
@@ -224,6 +227,7 @@ export class PetService extends BaseService {
224227
/**
225228
* Finds Pets by tags
226229
* Multiple tags can be provided with comma separated strings. Use tag1, tag2, tag3 for testing.
230+
* @endpoint get /pet/findByTags
227231
* @param tags Tags to filter by
228232
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
229233
* @param reportProgress flag to report request and response progress.
@@ -288,6 +292,7 @@ export class PetService extends BaseService {
288292
/**
289293
* Find pet by ID
290294
* Returns a single pet
295+
* @endpoint get /pet/${this.configuration.encodeParam({name: "petId", value: petId, in: "path", style: "simple", explode: false, dataType: "number", dataFormat: "int64"})}
291296
* @param petId ID of pet to return
292297
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
293298
* @param reportProgress flag to report request and response progress.
@@ -343,6 +348,7 @@ export class PetService extends BaseService {
343348

344349
/**
345350
* Update an existing pet
351+
* @endpoint put /pet
346352
* @param body Pet object that needs to be added to the store
347353
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
348354
* @param reportProgress flag to report request and response progress.
@@ -407,6 +413,7 @@ export class PetService extends BaseService {
407413

408414
/**
409415
* Updates a pet in the store with form data
416+
* @endpoint post /pet/${this.configuration.encodeParam({name: "petId", value: petId, in: "path", style: "simple", explode: false, dataType: "number", dataFormat: "int64"})}
410417
* @param petId ID of pet that needs to be updated
411418
* @param name Updated name of the pet
412419
* @param status Updated status of the pet
@@ -485,6 +492,7 @@ export class PetService extends BaseService {
485492

486493
/**
487494
* uploads an image
495+
* @endpoint post /pet/${this.configuration.encodeParam({name: "petId", value: petId, in: "path", style: "simple", explode: false, dataType: "number", dataFormat: "int64"})}/uploadImage
488496
* @param petId ID of pet to update
489497
* @param additionalMetadata Additional data to pass to server
490498
* @param file file to upload

samples/client/petstore/typescript-angular-v12-provided-in-any/builds/default/api/store.service.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ export class StoreService extends BaseService {
3838
/**
3939
* Delete purchase order by ID
4040
* For valid response try integer IDs with value < 1000. Anything above 1000 or nonintegers will generate API errors
41+
* @endpoint delete /store/order/${this.configuration.encodeParam({name: "orderId", value: orderId, in: "path", style: "simple", explode: false, dataType: "string", dataFormat: undefined})}
4142
* @param orderId ID of the order that needs to be deleted
4243
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
4344
* @param reportProgress flag to report request and response progress.
@@ -89,6 +90,7 @@ export class StoreService extends BaseService {
8990
/**
9091
* Returns pet inventories by status
9192
* Returns a map of status codes to quantities
93+
* @endpoint get /store/inventory
9294
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
9395
* @param reportProgress flag to report request and response progress.
9496
*/
@@ -140,6 +142,7 @@ export class StoreService extends BaseService {
140142
/**
141143
* Find purchase order by ID
142144
* For valid response try integer IDs with value <= 5 or > 10. Other values will generate exceptions
145+
* @endpoint get /store/order/${this.configuration.encodeParam({name: "orderId", value: orderId, in: "path", style: "simple", explode: false, dataType: "number", dataFormat: "int64"})}
143146
* @param orderId ID of pet that needs to be fetched
144147
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
145148
* @param reportProgress flag to report request and response progress.
@@ -192,6 +195,7 @@ export class StoreService extends BaseService {
192195

193196
/**
194197
* Place an order for a pet
198+
* @endpoint post /store/order
195199
* @param body order placed for purchasing the pet
196200
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
197201
* @param reportProgress flag to report request and response progress.

samples/client/petstore/typescript-angular-v12-provided-in-any/builds/default/api/user.service.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ export class UserService extends BaseService {
3838
/**
3939
* Create user
4040
* This can only be done by the logged in user.
41+
* @endpoint post /user
4142
* @param body Created user object
4243
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
4344
* @param reportProgress flag to report request and response progress.
@@ -97,6 +98,7 @@ export class UserService extends BaseService {
9798

9899
/**
99100
* Creates list of users with given input array
101+
* @endpoint post /user/createWithArray
100102
* @param body List of user object
101103
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
102104
* @param reportProgress flag to report request and response progress.
@@ -156,6 +158,7 @@ export class UserService extends BaseService {
156158

157159
/**
158160
* Creates list of users with given input array
161+
* @endpoint post /user/createWithList
159162
* @param body List of user object
160163
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
161164
* @param reportProgress flag to report request and response progress.
@@ -216,6 +219,7 @@ export class UserService extends BaseService {
216219
/**
217220
* Delete user
218221
* This can only be done by the logged in user.
222+
* @endpoint delete /user/${this.configuration.encodeParam({name: "username", value: username, in: "path", style: "simple", explode: false, dataType: "string", dataFormat: undefined})}
219223
* @param username The name that needs to be deleted
220224
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
221225
* @param reportProgress flag to report request and response progress.
@@ -266,6 +270,7 @@ export class UserService extends BaseService {
266270

267271
/**
268272
* Get user by user name
273+
* @endpoint get /user/${this.configuration.encodeParam({name: "username", value: username, in: "path", style: "simple", explode: false, dataType: "string", dataFormat: undefined})}
269274
* @param username The name that needs to be fetched. Use user1 for testing.
270275
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
271276
* @param reportProgress flag to report request and response progress.
@@ -318,6 +323,7 @@ export class UserService extends BaseService {
318323

319324
/**
320325
* Logs user into the system
326+
* @endpoint get /user/login
321327
* @param username The user name for login
322328
* @param password The password for login in clear text
323329
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
@@ -381,6 +387,7 @@ export class UserService extends BaseService {
381387

382388
/**
383389
* Logs out current logged in user session
390+
* @endpoint get /user/logout
384391
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
385392
* @param reportProgress flag to report request and response progress.
386393
*/
@@ -428,6 +435,7 @@ export class UserService extends BaseService {
428435
/**
429436
* Updated user
430437
* This can only be done by the logged in user.
438+
* @endpoint put /user/${this.configuration.encodeParam({name: "username", value: username, in: "path", style: "simple", explode: false, dataType: "string", dataFormat: undefined})}
431439
* @param username name that need to be deleted
432440
* @param body Updated user object
433441
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.

samples/client/petstore/typescript-angular-v12-provided-in-root/builds/default/api/pet.service.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ export class PetService extends BaseService {
3939

4040
/**
4141
* Add a new pet to the store
42+
* @endpoint post /pet
4243
* @param body Pet object that needs to be added to the store
4344
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
4445
* @param reportProgress flag to report request and response progress.
@@ -103,6 +104,7 @@ export class PetService extends BaseService {
103104

104105
/**
105106
* Deletes a pet
107+
* @endpoint delete /pet/${this.configuration.encodeParam({name: "petId", value: petId, in: "path", style: "simple", explode: false, dataType: "number", dataFormat: "int64"})}
106108
* @param petId Pet id to delete
107109
* @param apiKey
108110
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
@@ -161,6 +163,7 @@ export class PetService extends BaseService {
161163
/**
162164
* Finds Pets by status
163165
* Multiple status values can be provided with comma separated strings
166+
* @endpoint get /pet/findByStatus
164167
* @param status Status values that need to be considered for filter
165168
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
166169
* @param reportProgress flag to report request and response progress.
@@ -224,6 +227,7 @@ export class PetService extends BaseService {
224227
/**
225228
* Finds Pets by tags
226229
* Multiple tags can be provided with comma separated strings. Use tag1, tag2, tag3 for testing.
230+
* @endpoint get /pet/findByTags
227231
* @param tags Tags to filter by
228232
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
229233
* @param reportProgress flag to report request and response progress.
@@ -288,6 +292,7 @@ export class PetService extends BaseService {
288292
/**
289293
* Find pet by ID
290294
* Returns a single pet
295+
* @endpoint get /pet/${this.configuration.encodeParam({name: "petId", value: petId, in: "path", style: "simple", explode: false, dataType: "number", dataFormat: "int64"})}
291296
* @param petId ID of pet to return
292297
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
293298
* @param reportProgress flag to report request and response progress.
@@ -343,6 +348,7 @@ export class PetService extends BaseService {
343348

344349
/**
345350
* Update an existing pet
351+
* @endpoint put /pet
346352
* @param body Pet object that needs to be added to the store
347353
* @param observe set whether or not to return the data Observable as the body, response or events. defaults to returning the body.
348354
* @param reportProgress flag to report request and response progress.
@@ -407,6 +413,7 @@ export class PetService extends BaseService {
407413

408414
/**
409415
* Updates a pet in the store with form data
416+
* @endpoint post /pet/${this.configuration.encodeParam({name: "petId", value: petId, in: "path", style: "simple", explode: false, dataType: "number", dataFormat: "int64"})}
410417
* @param petId ID of pet that needs to be updated
411418
* @param name Updated name of the pet
412419
* @param status Updated status of the pet
@@ -485,6 +492,7 @@ export class PetService extends BaseService {
485492

486493
/**
487494
* uploads an image
495+
* @endpoint post /pet/${this.configuration.encodeParam({name: "petId", value: petId, in: "path", style: "simple", explode: false, dataType: "number", dataFormat: "int64"})}/uploadImage
488496
* @param petId ID of pet to update
489497
* @param additionalMetadata Additional data to pass to server
490498
* @param file file to upload

0 commit comments

Comments
 (0)