[Spring] Remove unnecessary modifiers from API interface templates (#22132)

* public static final String PATH_

* regenerate samples

Author: daberni

modules/openapi-generator/src/main/resources/JavaSpring/api.mustache

@@ -132,7 +132,7 @@ public interface {{classname}} {
 {{/jdk8-default-interface}}
 {{#operation}}
 
-    public static final String PATH_{{#lambda.uppercase}}{{#lambda.snakecase}}{{{operationId}}}{{/lambda.snakecase}}{{/lambda.uppercase}} = "{{{path}}}";
+    String PATH_{{#lambda.uppercase}}{{#lambda.snakecase}}{{{operationId}}}{{/lambda.snakecase}}{{/lambda.uppercase}} = "{{{path}}}";
     /**
      * {{httpMethod}} {{{path}}}{{#summary}} : {{.}}{{/summary}}
     {{#notes}}

modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java

@@ -1171,7 +1171,7 @@ public void testRequestMappingAnnotation() throws IOException {
         // Check that the @RequestMapping annotation is generated in the Api file
         JavaFileAssert.assertThat(files.get("PetApi.java"))
                 .fileContains("@RequestMapping(\"${openapi.openAPIPetstore.base-path:/v2}\")",
-                        "public static final String PATH_ADD_PET = \"/pet\";",
+                        "String PATH_ADD_PET = \"/pet\";",
                         "value = PetApi.PATH_ADD_PET");
 
         // Check that the @RequestMapping annotation is not generated in the Controller file

samples/client/petstore/spring-cloud-auth/src/main/java/org/openapitools/api/SomeApi.java

@@ -21,7 +21,7 @@
 @Validated
 public interface SomeApi {
 
-    public static final String PATH_SOME_ENDPOINT_GET = "/some/endpoint";
+    String PATH_SOME_ENDPOINT_GET = "/some/endpoint";
     /**
      * GET /some/endpoint
      *

samples/client/petstore/spring-cloud-date-time/src/main/java/org/openapitools/api/DefaultApi.java

@@ -27,7 +27,7 @@
 @Api(value = "Default", description = "the Default API")
 public interface DefaultApi {
 
-    public static final String PATH_GET = "/thingy/{date}";
+    String PATH_GET = "/thingy/{date}";
     /**
      * GET /thingy/{date}
      *
@@ -57,7 +57,7 @@ ResponseEntity<Void> get(
     );
 
 
-    public static final String PATH_UPDATE_PET_WITH_FORM = "/thingy/{date}";
+    String PATH_UPDATE_PET_WITH_FORM = "/thingy/{date}";
     /**
      * POST /thingy/{date}
      * update with form data

samples/client/petstore/spring-cloud-deprecated/src/main/java/org/openapitools/api/PetApi.java

@@ -37,7 +37,7 @@
 @Tag(name = "pet", description = "Everything about your Pets")
 public interface PetApi {
 
-    public static final String PATH_ADD_PET = "/pet";
+    String PATH_ADD_PET = "/pet";
     /**
      * POST /pet : Add a new pet to the store
      * 
@@ -67,7 +67,7 @@ ResponseEntity<Void> addPet(
     );
 
 
-    public static final String PATH_DELETE_PET = "/pet/{petId}";
+    String PATH_DELETE_PET = "/pet/{petId}";
     /**
      * DELETE /pet/{petId} : Deletes a pet
      * 
@@ -98,7 +98,7 @@ ResponseEntity<Void> deletePet(
     );
 
 
-    public static final String PATH_FIND_PETS_BY_STATUS = "/pet/findByStatus";
+    String PATH_FIND_PETS_BY_STATUS = "/pet/findByStatus";
     /**
      * GET /pet/findByStatus : Finds Pets by status
      * Multiple status values can be provided with comma separated strings
@@ -133,7 +133,7 @@ ResponseEntity<List<Pet>> findPetsByStatus(
     );
 
 
-    public static final String PATH_FIND_PETS_BY_TAGS = "/pet/findByTags";
+    String PATH_FIND_PETS_BY_TAGS = "/pet/findByTags";
     /**
      * GET /pet/findByTags : Finds Pets by tags
      * Multiple tags can be provided with comma separated strings. Use tag1, tag2, tag3 for testing.
@@ -171,7 +171,7 @@ ResponseEntity<List<Pet>> findPetsByTags(
     );
 
 
-    public static final String PATH_GET_PET_BY_ID = "/pet/{petId}";
+    String PATH_GET_PET_BY_ID = "/pet/{petId}";
     /**
      * GET /pet/{petId} : Find pet by ID
      * Returns a single pet
@@ -208,7 +208,7 @@ ResponseEntity<Pet> getPetById(
     );
 
 
-    public static final String PATH_UPDATE_PET = "/pet";
+    String PATH_UPDATE_PET = "/pet";
     /**
      * PUT /pet : Update an existing pet
      * 
@@ -242,7 +242,7 @@ ResponseEntity<Void> updatePet(
     );
 
 
-    public static final String PATH_UPDATE_PET_WITH_FORM = "/pet/{petId}";
+    String PATH_UPDATE_PET_WITH_FORM = "/pet/{petId}";
     /**
      * POST /pet/{petId} : Updates a pet in the store with form data
      * 
@@ -276,7 +276,7 @@ ResponseEntity<Void> updatePetWithForm(
     );
 
 
-    public static final String PATH_UPLOAD_FILE = "/pet/{petId}/uploadImage";
+    String PATH_UPLOAD_FILE = "/pet/{petId}/uploadImage";
     /**
      * POST /pet/{petId}/uploadImage : uploads an image
      * 

samples/client/petstore/spring-cloud-deprecated/src/main/java/org/openapitools/api/StoreApi.java

@@ -36,7 +36,7 @@
 @Tag(name = "store", description = "Access to Petstore orders")
 public interface StoreApi {
 
-    public static final String PATH_DELETE_ORDER = "/store/order/{orderId}";
+    String PATH_DELETE_ORDER = "/store/order/{orderId}";
     /**
      * DELETE /store/order/{orderId} : Delete purchase order by ID
      * For valid response try integer IDs with value < 1000. Anything above 1000 or nonintegers will generate API errors
@@ -64,7 +64,7 @@ ResponseEntity<Void> deleteOrder(
     );
 
 
-    public static final String PATH_GET_INVENTORY = "/store/inventory";
+    String PATH_GET_INVENTORY = "/store/inventory";
     /**
      * GET /store/inventory : Returns pet inventories by status
      * Returns a map of status codes to quantities
@@ -95,7 +95,7 @@ ResponseEntity<Map<String, Integer>> getInventory(
     );
 
 
-    public static final String PATH_GET_ORDER_BY_ID = "/store/order/{orderId}";
+    String PATH_GET_ORDER_BY_ID = "/store/order/{orderId}";
     /**
      * GET /store/order/{orderId} : Find purchase order by ID
      * For valid response try integer IDs with value &lt;&#x3D; 5 or &gt; 10. Other values will generate exceptions
@@ -129,7 +129,7 @@ ResponseEntity<Order> getOrderById(
     );
 
 
-    public static final String PATH_PLACE_ORDER = "/store/order";
+    String PATH_PLACE_ORDER = "/store/order";
     /**
      * POST /store/order : Place an order for a pet
      * 

samples/client/petstore/spring-cloud-deprecated/src/main/java/org/openapitools/api/UserApi.java

@@ -36,7 +36,7 @@
 @Tag(name = "user", description = "Operations about user")
 public interface UserApi {
 
-    public static final String PATH_CREATE_USER = "/user";
+    String PATH_CREATE_USER = "/user";
     /**
      * POST /user : Create user
      * This can only be done by the logged in user.
@@ -66,7 +66,7 @@ ResponseEntity<Void> createUser(
     );
 
 
-    public static final String PATH_CREATE_USERS_WITH_ARRAY_INPUT = "/user/createWithArray";
+    String PATH_CREATE_USERS_WITH_ARRAY_INPUT = "/user/createWithArray";
     /**
      * POST /user/createWithArray : Creates list of users with given input array
      * 
@@ -96,7 +96,7 @@ ResponseEntity<Void> createUsersWithArrayInput(
     );
 
 
-    public static final String PATH_CREATE_USERS_WITH_LIST_INPUT = "/user/createWithList";
+    String PATH_CREATE_USERS_WITH_LIST_INPUT = "/user/createWithList";
     /**
      * POST /user/createWithList : Creates list of users with given input array
      * 
@@ -126,7 +126,7 @@ ResponseEntity<Void> createUsersWithListInput(
     );
 
 
-    public static final String PATH_DELETE_USER = "/user/{username}";
+    String PATH_DELETE_USER = "/user/{username}";
     /**
      * DELETE /user/{username} : Delete user
      * This can only be done by the logged in user.
@@ -157,7 +157,7 @@ ResponseEntity<Void> deleteUser(
     );
 
 
-    public static final String PATH_GET_USER_BY_NAME = "/user/{username}";
+    String PATH_GET_USER_BY_NAME = "/user/{username}";
     /**
      * GET /user/{username} : Get user by user name
      * 
@@ -191,7 +191,7 @@ ResponseEntity<User> getUserByName(
     );
 
 
-    public static final String PATH_LOGIN_USER = "/user/login";
+    String PATH_LOGIN_USER = "/user/login";
     /**
      * GET /user/login : Logs user into the system
      * 
@@ -225,7 +225,7 @@ ResponseEntity<String> loginUser(
     );
 
 
-    public static final String PATH_LOGOUT_USER = "/user/logout";
+    String PATH_LOGOUT_USER = "/user/logout";
     /**
      * GET /user/logout : Logs out current logged in user session
      * 
@@ -253,7 +253,7 @@ ResponseEntity<Void> logoutUser(
     );
 
 
-    public static final String PATH_UPDATE_USER = "/user/{username}";
+    String PATH_UPDATE_USER = "/user/{username}";
     /**
      * PUT /user/{username} : Updated user
      * This can only be done by the logged in user.

samples/client/petstore/spring-cloud-feign-without-url/src/main/java/org/openapitools/api/PetApi.java

@@ -26,7 +26,7 @@
 @Api(value = "pet", description = "Everything about your Pets")
 public interface PetApi {
 
-    public static final String PATH_ADD_PET = "/pet";
+    String PATH_ADD_PET = "/pet";
     /**
      * POST /pet : Add a new pet to the store
      * 
@@ -63,7 +63,7 @@ ResponseEntity<Pet> addPet(
     );
 
 
-    public static final String PATH_DELETE_PET = "/pet/{petId}";
+    String PATH_DELETE_PET = "/pet/{petId}";
     /**
      * DELETE /pet/{petId} : Deletes a pet
      * 
@@ -97,7 +97,7 @@ ResponseEntity<Void> deletePet(
     );
 
 
-    public static final String PATH_FIND_PETS_BY_STATUS = "/pet/findByStatus";
+    String PATH_FIND_PETS_BY_STATUS = "/pet/findByStatus";
     /**
      * GET /pet/findByStatus : Finds Pets by status
      * Multiple status values can be provided with comma separated strings
@@ -133,7 +133,7 @@ ResponseEntity<List<Pet>> findPetsByStatus(
     );
 
 
-    public static final String PATH_FIND_PETS_BY_TAGS = "/pet/findByTags";
+    String PATH_FIND_PETS_BY_TAGS = "/pet/findByTags";
     /**
      * GET /pet/findByTags : Finds Pets by tags
      * Multiple tags can be provided with comma separated strings. Use tag1, tag2, tag3 for testing.
@@ -171,7 +171,7 @@ ResponseEntity<List<Pet>> findPetsByTags(
     );
 
 
-    public static final String PATH_GET_PET_BY_ID = "/pet/{petId}";
+    String PATH_GET_PET_BY_ID = "/pet/{petId}";
     /**
      * GET /pet/{petId} : Find pet by ID
      * Returns a single pet
@@ -206,7 +206,7 @@ ResponseEntity<Pet> getPetById(
     );
 
 
-    public static final String PATH_UPDATE_PET = "/pet";
+    String PATH_UPDATE_PET = "/pet";
     /**
      * PUT /pet : Update an existing pet
      * 
@@ -249,7 +249,7 @@ ResponseEntity<Pet> updatePet(
     );
 
 
-    public static final String PATH_UPDATE_PET_WITH_FORM = "/pet/{petId}";
+    String PATH_UPDATE_PET_WITH_FORM = "/pet/{petId}";
     /**
      * POST /pet/{petId} : Updates a pet in the store with form data
      * 
@@ -286,7 +286,7 @@ ResponseEntity<Void> updatePetWithForm(
     );
 
 
-    public static final String PATH_UPLOAD_FILE = "/pet/{petId}/uploadImage";
+    String PATH_UPLOAD_FILE = "/pet/{petId}/uploadImage";
     /**
      * POST /pet/{petId}/uploadImage : uploads an image
      * 

samples/client/petstore/spring-cloud-feign-without-url/src/main/java/org/openapitools/api/StoreApi.java

@@ -25,7 +25,7 @@
 @Api(value = "store", description = "Access to Petstore orders")
 public interface StoreApi {
 
-    public static final String PATH_DELETE_ORDER = "/store/order/{orderId}";
+    String PATH_DELETE_ORDER = "/store/order/{orderId}";
     /**
      * DELETE /store/order/{orderId} : Delete purchase order by ID
      * For valid response try integer IDs with value < 1000. Anything above 1000 or nonintegers will generate API errors
@@ -53,7 +53,7 @@ ResponseEntity<Void> deleteOrder(
     );
 
 
-    public static final String PATH_GET_INVENTORY = "/store/inventory";
+    String PATH_GET_INVENTORY = "/store/inventory";
     /**
      * GET /store/inventory : Returns pet inventories by status
      * Returns a map of status codes to quantities
@@ -84,7 +84,7 @@ ResponseEntity<Map<String, Integer>> getInventory(
     );
 
 
-    public static final String PATH_GET_ORDER_BY_ID = "/store/order/{orderId}";
+    String PATH_GET_ORDER_BY_ID = "/store/order/{orderId}";
     /**
      * GET /store/order/{orderId} : Find purchase order by ID
      * For valid response try integer IDs with value &lt;&#x3D; 5 or &gt; 10. Other values will generate exceptions
@@ -116,7 +116,7 @@ ResponseEntity<Order> getOrderById(
     );
 
 
-    public static final String PATH_PLACE_ORDER = "/store/order";
+    String PATH_PLACE_ORDER = "/store/order";
     /**
      * POST /store/order : Place an order for a pet
      *