Skip to content

Commit babb3e2

Browse files
joschijoschi
authored
[Java] Add missing Locale to String.format() invocations (#21871)
* [Java] Add missing Locale to String.format() invocations * chore: ./bin/generate-samples.sh ./bin/configs/*.yaml
1 parent d1df75c commit babb3e2

File tree

2,539 files changed

+5392
-2392
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

2,539 files changed

+5392
-2392
lines changed

‎modules/openapi-generator/src/main/resources/Java/ApiClient.mustache‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ import java.util.Arrays;
4141
import java.util.ArrayList;
4242
import java.util.Date;
4343
import java.util.TimeZone;
44+
import java.util.Locale;
4445

4546
import java.net.URLEncoder;
4647

@@ -694,6 +695,7 @@ public class ApiClient{{#jsr310}} extends JavaTimeFormatter{{/jsr310}} {
694695
if (serverIndex != null) {
695696
if (serverIndex < 0 || serverIndex >= servers.size()) {
696697
throw new ArrayIndexOutOfBoundsException(String.format(
698+
Locale.ROOT,
697699
"Invalid index %d when selecting the host settings. Must be less than %d", serverIndex, servers.size()
698700
));
699701
}

‎modules/openapi-generator/src/main/resources/Java/libraries/apache-httpclient/ApiClient.mustache‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ import java.util.ArrayList;
5050
import java.util.Date;
5151
import java.util.function.Supplier;
5252
import java.util.TimeZone;
53+
import java.util.Locale;
5354
import java.util.regex.Matcher;
5455
import java.util.regex.Pattern;
5556

@@ -929,6 +930,7 @@ public class ApiClient{{#jsr310}} extends JavaTimeFormatter{{/jsr310}} {
929930
if (serverIndex != null) {
930931
if (serverIndex < 0 || serverIndex >= servers.size()) {
931932
throw new ArrayIndexOutOfBoundsException(String.format(
933+
Locale.ROOT,
932934
"Invalid index %d when selecting the host settings. Must be less than %d", serverIndex, servers.size()
933935
));
934936
}

‎modules/openapi-generator/src/main/resources/Java/libraries/apache-httpclient/api.mustache‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import java.util.ArrayList;
2020
import java.util.Collections;
2121
import java.util.HashMap;
2222
import java.util.List;
23+
import java.util.Locale;
2324
import java.util.Map;
2425
import java.util.StringJoiner;
2526

@@ -115,7 +116,7 @@ public class {{classname}} extends BaseApi {
115116
localVarQueryParameterBaseName = "{{{baseName}}}";
116117
{{#isArray}}
117118
for (int i=0; i < {{paramName}}.size(); i++) {
118-
localVarQueryStringJoiner.add({{paramName}}.get(i).toUrlQueryString(String.format("{{baseName}}[%d]", i)));
119+
localVarQueryStringJoiner.add({{paramName}}.get(i).toUrlQueryString(String.format(Locale.ROOT, "{{baseName}}[%d]", i)));
119120
}
120121
{{/isArray}}
121122
{{^isArray}}

‎modules/openapi-generator/src/main/resources/Java/libraries/feign/auth/ApiKeyAuth.mustache‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ package {{invokerPackage}}.auth;
44

55
import feign.RequestInterceptor;
66
import feign.RequestTemplate;
7+
import java.util.Locale;
78

89
public class ApiKeyAuth implements RequestInterceptor {
910
private final String location;
@@ -39,7 +40,7 @@ public class ApiKeyAuth implements RequestInterceptor {
3940
} else if ("header".equals(location)) {
4041
template.header(paramName, apiKey);
4142
} else if ("cookie".equals(location)) {
42-
template.header("Cookie", String.format("%s=%s", paramName, apiKey));
43+
template.header("Cookie", String.format(Locale.ROOT, "%s=%s", paramName, apiKey));
4344
}
4445
}
4546
}

‎modules/openapi-generator/src/main/resources/Java/libraries/feign/model.mustache‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import com.fasterxml.jackson.annotation.JsonAnySetter;
1818
{{/models}}
1919
import java.util.Objects;
2020
import java.util.Arrays;
21+
import java.util.Locale;
2122
{{#imports}}
2223
import {{import}};
2324
{{/imports}}

‎modules/openapi-generator/src/main/resources/Java/libraries/feign/pojo.mustache‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -366,8 +366,8 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
366366
int i = 0;
367367
for ({{items.dataType}} _item : {{getter}}()) {
368368
try {
369-
joiner.add(String.format("%s{{baseName}}%s%s=%s", prefix, suffix,
370-
"".equals(suffix) ? "" : String.format("%s%d%s", containerPrefix, i, containerSuffix),
369+
joiner.add(String.format(Locale.ROOT, "%s{{baseName}}%s%s=%s", prefix, suffix,
370+
"".equals(suffix) ? "" : String.format(Locale.ROOT, "%s%d%s", containerPrefix, i, containerSuffix),
371371
URLEncoder.encode(String.valueOf(_item), "UTF-8").replaceAll("\\+", "%20")));
372372
} catch (UnsupportedEncodingException e) {
373373
// Should never happen, UTF-8 is always supported
@@ -381,8 +381,8 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
381381
if ({{getter}}() != null) {
382382
for (int i = 0; i < {{getter}}().size(); i++) {
383383
try {
384-
joiner.add(String.format("%s{{baseName}}%s%s=%s", prefix, suffix,
385-
"".equals(suffix) ? "" : String.format("%s%d%s", containerPrefix, i, containerSuffix),
384+
joiner.add(String.format(Locale.ROOT, "%s{{baseName}}%s%s=%s", prefix, suffix,
385+
"".equals(suffix) ? "" : String.format(Locale.ROOT, "%s%d%s", containerPrefix, i, containerSuffix),
386386
URLEncoder.encode(String.valueOf({{getter}}().get(i)), "UTF-8").replaceAll("\\+", "%20")));
387387
} catch (UnsupportedEncodingException e) {
388388
// Should never happen, UTF-8 is always supported
@@ -399,8 +399,8 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
399399
int i = 0;
400400
for ({{items.dataType}} _item : {{getter}}()) {
401401
if (_item != null) {
402-
joiner.add(_item.toUrlQueryString(String.format("%s{{baseName}}%s%s", prefix, suffix,
403-
"".equals(suffix) ? "" : String.format("%s%d%s", containerPrefix, i, containerSuffix))));
402+
joiner.add(_item.toUrlQueryString(String.format(Locale.ROOT, "%s{{baseName}}%s%s", prefix, suffix,
403+
"".equals(suffix) ? "" : String.format(Locale.ROOT, "%s%d%s", containerPrefix, i, containerSuffix))));
404404
}
405405
}
406406
i++;
@@ -410,8 +410,8 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
410410
if ({{getter}}() != null) {
411411
for (int i = 0; i < {{getter}}().size(); i++) {
412412
if ({{getter}}().get(i) != null) {
413-
joiner.add({{getter}}().get(i).toUrlQueryString(String.format("%s{{baseName}}%s%s", prefix, suffix,
414-
"".equals(suffix) ? "" : String.format("%s%d%s", containerPrefix, i, containerSuffix))));
413+
joiner.add({{getter}}().get(i).toUrlQueryString(String.format(Locale.ROOT, "%s{{baseName}}%s%s", prefix, suffix,
414+
"".equals(suffix) ? "" : String.format(Locale.ROOT, "%s%d%s", containerPrefix, i, containerSuffix))));
415415
}
416416
}
417417
}
@@ -424,8 +424,8 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
424424
for ({{items.dataType}} _item : {{getter}}()) {
425425
if (_item != null) {
426426
try {
427-
joiner.add(String.format("%s{{baseName}}%s%s=%s", prefix, suffix,
428-
"".equals(suffix) ? "" : String.format("%s%d%s", containerPrefix, i, containerSuffix),
427+
joiner.add(String.format(Locale.ROOT, "%s{{baseName}}%s%s=%s", prefix, suffix,
428+
"".equals(suffix) ? "" : String.format(Locale.ROOT, "%s%d%s", containerPrefix, i, containerSuffix),
429429
URLEncoder.encode(String.valueOf(_item), "UTF-8").replaceAll("\\+", "%20")));
430430
} catch (UnsupportedEncodingException e) {
431431
// Should never happen, UTF-8 is always supported
@@ -441,8 +441,8 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
441441
for (int i = 0; i < {{getter}}().size(); i++) {
442442
if ({{getter}}().get(i) != null) {
443443
try {
444-
joiner.add(String.format("%s{{baseName}}%s%s=%s", prefix, suffix,
445-
"".equals(suffix) ? "" : String.format("%s%d%s", containerPrefix, i, containerSuffix),
444+
joiner.add(String.format(Locale.ROOT, "%s{{baseName}}%s%s=%s", prefix, suffix,
445+
"".equals(suffix) ? "" : String.format(Locale.ROOT, "%s%d%s", containerPrefix, i, containerSuffix),
446446
URLEncoder.encode(String.valueOf({{getter}}().get(i)), "UTF-8").replaceAll("\\+", "%20")));
447447
} catch (UnsupportedEncodingException e) {
448448
// Should never happen, UTF-8 is always supported
@@ -461,8 +461,8 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
461461
if ({{getter}}() != null) {
462462
for (String _key : {{getter}}().keySet()) {
463463
try {
464-
joiner.add(String.format("%s{{baseName}}%s%s=%s", prefix, suffix,
465-
"".equals(suffix) ? "" : String.format("%s%d%s", containerPrefix, _key, containerSuffix),
464+
joiner.add(String.format(Locale.ROOT, "%s{{baseName}}%s%s=%s", prefix, suffix,
465+
"".equals(suffix) ? "" : String.format(Locale.ROOT, "%s%d%s", containerPrefix, _key, containerSuffix),
466466
{{getter}}().get(_key), URLEncoder.encode(String.valueOf({{getter}}().get(_key)), "UTF-8").replaceAll("\\+", "%20")));
467467
} catch (UnsupportedEncodingException e) {
468468
// Should never happen, UTF-8 is always supported
@@ -475,8 +475,8 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
475475
if ({{getter}}() != null) {
476476
for (String _key : {{getter}}().keySet()) {
477477
if ({{getter}}().get(_key) != null) {
478-
joiner.add({{getter}}().get(_key).toUrlQueryString(String.format("%s{{baseName}}%s%s", prefix, suffix,
479-
"".equals(suffix) ? "" : String.format("%s%d%s", containerPrefix, _key, containerSuffix))));
478+
joiner.add({{getter}}().get(_key).toUrlQueryString(String.format(Locale.ROOT, "%s{{baseName}}%s%s", prefix, suffix,
479+
"".equals(suffix) ? "" : String.format(Locale.ROOT, "%s%d%s", containerPrefix, _key, containerSuffix))));
480480
}
481481
}
482482
}
@@ -486,7 +486,7 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
486486
{{#isPrimitiveType}}
487487
if ({{getter}}() != null) {
488488
try {
489-
joiner.add(String.format("%s{{{baseName}}}%s=%s", prefix, suffix, URLEncoder.encode(String.valueOf({{{getter}}}()), "UTF-8").replaceAll("\\+", "%20")));
489+
joiner.add(String.format(Locale.ROOT, "%s{{{baseName}}}%s=%s", prefix, suffix, URLEncoder.encode(String.valueOf({{{getter}}}()), "UTF-8").replaceAll("\\+", "%20")));
490490
} catch (UnsupportedEncodingException e) {
491491
// Should never happen, UTF-8 is always supported
492492
throw new RuntimeException(e);
@@ -502,7 +502,7 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
502502
{{^isModel}}
503503
if ({{getter}}() != null) {
504504
try {
505-
joiner.add(String.format("%s{{{baseName}}}%s=%s", prefix, suffix, URLEncoder.encode(String.valueOf({{{getter}}}()), "UTF-8").replaceAll("\\+", "%20")));
505+
joiner.add(String.format(Locale.ROOT, "%s{{{baseName}}}%s=%s", prefix, suffix, URLEncoder.encode(String.valueOf({{{getter}}}()), "UTF-8").replaceAll("\\+", "%20")));
506506
} catch (UnsupportedEncodingException e) {
507507
// Should never happen, UTF-8 is always supported
508508
throw new RuntimeException(e);

‎modules/openapi-generator/src/main/resources/Java/libraries/jersey2/ApiClient.mustache‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ import java.util.List;
5454
import java.util.Arrays;
5555
import java.util.ArrayList;
5656
import java.util.Date;
57+
import java.util.Locale;
5758
import java.util.stream.Collectors;
5859
import java.util.stream.Stream;
5960
{{#jsr310}}
@@ -1223,6 +1224,7 @@ public class ApiClient{{#jsr310}} extends JavaTimeFormatter{{/jsr310}} {
12231224
if (index < 0 || index >= serverConfigurations.size()) {
12241225
throw new ArrayIndexOutOfBoundsException(
12251226
String.format(
1227+
Locale.ROOT,
12261228
"Invalid index %d when selecting the host settings. Must be less than %d",
12271229
index, serverConfigurations.size()));
12281230
}

‎modules/openapi-generator/src/main/resources/Java/libraries/jersey2/model.mustache‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import com.fasterxml.jackson.annotation.JsonAnySetter;
1919
import java.util.Objects;
2020
import java.util.Map;
2121
import java.util.HashMap;
22+
import java.util.Locale;
2223
{{#imports}}
2324
import {{import}};
2425
{{/imports}}

‎modules/openapi-generator/src/main/resources/Java/libraries/jersey2/oneof_model.mustache‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import java.util.logging.Logger;
66
import java.util.ArrayList;
77
import java.util.Collections;
88
import java.util.HashSet;
9+
import java.util.Locale;
910

1011
import com.fasterxml.jackson.core.JsonGenerator;
1112
import com.fasterxml.jackson.core.JsonParser;
@@ -70,7 +71,7 @@ public class {{classname}} extends AbstractOpenApiSchema{{#vendorExtensions.x-im
7071
return new{{classname}};
7172
{{/mappedModels}}
7273
default:
73-
log.log(Level.WARNING, String.format("Failed to lookup discriminator value `%s` for {{classname}}. Possible values:{{#mappedModels}} {{{mappingName}}}{{/mappedModels}}", discriminatorValue));
74+
log.log(Level.WARNING, String.format(Locale.ROOT, "Failed to lookup discriminator value `%s` for {{classname}}. Possible values:{{#mappedModels}} {{{mappingName}}}{{/mappedModels}}", discriminatorValue));
7475
}
7576

7677
{{/discriminator}}
@@ -157,7 +158,7 @@ public class {{classname}} extends AbstractOpenApiSchema{{#vendorExtensions.x-im
157158
ret.setActualInstance(deserialized);
158159
return ret;
159160
}
160-
throw new IOException(String.format("Failed deserialization for {{classname}}: %d classes match result, expected 1", match));
161+
throw new IOException(String.format(Locale.ROOT, "Failed deserialization for {{classname}}: %d classes match result, expected 1", match));
161162
}
162163

163164
/**

‎modules/openapi-generator/src/main/resources/Java/libraries/jersey3/ApiClient.mustache‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ import java.util.List;
5454
import java.util.Arrays;
5555
import java.util.ArrayList;
5656
import java.util.Date;
57+
import java.util.Locale;
5758
import java.util.stream.Collectors;
5859
import java.util.stream.Stream;
5960
{{#jsr310}}
@@ -1223,6 +1224,7 @@ public class ApiClient{{#jsr310}} extends JavaTimeFormatter{{/jsr310}} {
12231224
if (index < 0 || index >= serverConfigurations.size()) {
12241225
throw new ArrayIndexOutOfBoundsException(
12251226
String.format(
1227+
Locale.ROOT,
12261228
"Invalid index %d when selecting the host settings. Must be less than %d",
12271229
index, serverConfigurations.size()));
12281230
}

0 commit comments

Comments
 (0)