Better camelization: removed duplication, replace also spaces #5693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Is there anything that hinders the PR to get merged? |
|
By the way, I don't understand why the Circle CI build fails. I hope it's not my fault. I'm wondering why the rust server tests are failing. It seems that some spaces where removed. From the log: I can't say whether this is my fault or not, but it shouldn't be mine because there shouldn't be any camelization involved. |
# Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/utils/StringUtils.java # samples/client/petstore/typescript-angular-v6-not-provided-in-root/builds/default/.openapi-generator/FILES # samples/client/petstore/typescript-angular-v6-not-provided-in-root/builds/with-npm/.openapi-generator/FILES # samples/client/petstore/typescript-angular-v6-provided-in-root/builds/default/.openapi-generator/FILES # samples/client/petstore/typescript-angular-v6-provided-in-root/builds/with-npm/.openapi-generator/FILES # samples/client/petstore/typescript-angular-v7-not-provided-in-root/builds/default/.openapi-generator/FILES # samples/client/petstore/typescript-angular-v7-not-provided-in-root/builds/with-npm/.openapi-generator/FILES # samples/client/petstore/typescript-angular-v7-provided-in-root/builds/default/.openapi-generator/FILES # samples/client/petstore/typescript-angular-v7-provided-in-root/builds/with-npm/.openapi-generator/FILES # samples/client/petstore/typescript-angular-v8-provided-in-root/builds/single-request-parameter/.openapi-generator/FILES # samples/client/petstore/typescript-angular-v8-provided-in-root/builds/with-npm/.openapi-generator/FILES # samples/client/petstore/typescript-angular-v8-provided-in-root/builds/with-prefixed-module-name/.openapi-generator/FILES # samples/client/petstore/typescript-node/default/.openapi-generator/FILES # samples/client/petstore/typescript-node/npm/.openapi-generator/FILES # samples/server/petstore/php-symfony/SymfonyBundle-php/.openapi-generator/FILES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.I hope nothing is missing. If not, please tell me.
This PR fixes #5627 and fixes #311 (I think). It removes also the duplication with removing _ and - and adds removing of spaces. I added also tests.