refactor: migrate plugin-import to plugin-import-x

also `import-resolver-oxc` to the new `import-resolver-typescript`

Author: JounQin

openbas-front/builder/dev/dev.js

@@ -1,4 +1,4 @@
-/* eslint import/no-extraneous-dependencies: 0 */
+/* eslint import-x/no-extraneous-dependencies: 0 */
 
 import { readFileSync } from 'node:fs';
 import path from 'node:path';

openbas-front/builder/prod/prod.js

@@ -1,4 +1,4 @@
-/* eslint import/no-extraneous-dependencies: 0 */
+/* eslint import-x/no-extraneous-dependencies: 0 */
 
 import fs from 'node:fs';
 

openbas-front/eslint.config.js

@@ -1,14 +1,12 @@
-/* eslint import/no-extraneous-dependencies: 0 */
-
-// imports to not let tools report them as unused
-import 'eslint-import-resolver-oxc';
+/* eslint import-x/no-extraneous-dependencies: 0 */
 
 import js from '@eslint/js';
 import stylistic from '@stylistic/eslint-plugin';
 import vitest from '@vitest/eslint-plugin';
+import { createTypeScriptImportResolver } from 'eslint-import-resolver-typescript';
 import customRules from 'eslint-plugin-custom-rules';
 import i18next from 'eslint-plugin-i18next';
-import importPlugin from 'eslint-plugin-import';
+import * as importXPlugin from 'eslint-plugin-import-x';
 import playwright from 'eslint-plugin-playwright';
 import react from 'eslint-plugin-react';
 import reactRefresh from 'eslint-plugin-react-refresh';
@@ -29,12 +27,12 @@ export default [
   { settings: { react: { version: 'detect' } } },
 
   // rules recommended by eslint-plugin-import
-  importPlugin.flatConfigs.recommended,
-  importPlugin.flatConfigs.typescript,
+  importXPlugin.flatConfigs.recommended,
+  importXPlugin.flatConfigs.typescript,
   {
     settings: {
-      'import/resolver': 'oxc',
-      'import/ignore': [
+      'import-x/resolver-next': [createTypeScriptImportResolver()],
+      'import-x/ignore': [
         'react-apexcharts', // ignore react-apexcharts as the default export is broken
       ],
     },
@@ -102,11 +100,11 @@ export default [
       '@stylistic/object-property-newline': ['error', { allowAllPropertiesOnSameLine: false }],
 
       // eslint-plugin-import rules
-      'import/no-named-as-default-member': 'off',
-      'import/prefer-default-export': 'error',
-      'import/no-mutable-exports': 'error',
-      'import/namespace': 'off', // off to reduce computing time for one file, on when doing yarn lint
-      'import/no-extraneous-dependencies': [
+      'import-x/no-named-as-default-member': 'off',
+      'import-x/prefer-default-export': 'error',
+      'import-x/no-mutable-exports': 'error',
+      'import-x/namespace': 'off', // off to reduce computing time for one file, on when doing yarn lint
+      'import-x/no-extraneous-dependencies': [
         'error',
         {
           devDependencies: [
@@ -183,7 +181,7 @@ export default [
     plugins: { vitest },
     rules: {
       ...vitest.configs.recommended.rules,
-      'import/no-extraneous-dependencies': [
+      'import-x/no-extraneous-dependencies': [
         'error',
         {
           devDependencies: [
@@ -202,7 +200,7 @@ export default [
     ...playwright.configs['flat/recommended'],
     rules: {
       ...playwright.configs['flat/recommended'].rules,
-      'import/no-extraneous-dependencies': [
+      'import-x/no-extraneous-dependencies': [
         'error',
         {
           devDependencies: [

openbas-front/package.json

@@ -94,10 +94,10 @@
     "cross-env": "7.0.3",
     "esbuild": "0.25.1",
     "eslint": "9.23.0",
-    "eslint-import-resolver-oxc": "0.13.1",
+    "eslint-import-resolver-typescript": "4.3.2",
     "eslint-plugin-custom-rules": "link:packages/eslint-plugin-custom-rules",
     "eslint-plugin-i18next": "6.1.1",
-    "eslint-plugin-import": "2.31.0",
+    "eslint-plugin-import-x": "4.10.2",
     "eslint-plugin-playwright": "2.2.0",
     "eslint-plugin-react": "7.37.4",
     "eslint-plugin-react-refresh": "0.4.19",
@@ -130,7 +130,7 @@
     "start": "vite",
     "deprecated-start": "node builder/dev/dev.js",
     "build": "node builder/prod/prod.js",
-    "lint": "cross-env DEBUG=eslint:eslint TIMING=1 eslint --max-warnings 0 --cache --rule \"{'import/namespace': 'error', 'import/no-cycle': ['error', {'ignoreExternal': true, 'disableScc': true}]}\" .",
+    "lint": "cross-env DEBUG=eslint:eslint TIMING=1 eslint --max-warnings 0 --cache --rule \"{'import-x/namespace': 'error', 'import-x/no-cycle': ['error', {'ignoreExternal': true}]}\" .",
     "control": "yarn audit --groups dependencies --summary",
     "check-ts": "tsc",
     "generate-types-from-api": "swagger-typescript-api generate --no-client -p http://localhost:8080/api-docs -o src/utils -n api-types.d.ts --sort-types",

openbas-front/src/actions/findings/finding-actions.ts

@@ -3,7 +3,7 @@ import { type SearchPaginationInput } from '../../utils/api-types';
 
 const FINDING_URI = '/api/findings';
 
-// eslint-disable-next-line import/prefer-default-export
+// eslint-disable-next-line import-x/prefer-default-export
 export const searchFindings = (searchPaginationInput: SearchPaginationInput) => {
   const data = searchPaginationInput;
   const uri = `${FINDING_URI}/search`;

openbas-front/src/actions/players/player-actions.ts

@@ -3,7 +3,7 @@ import { type SearchPaginationInput } from '../../utils/api-types';
 
 const PLAYER_URI = '/api/players';
 
-// eslint-disable-next-line import/prefer-default-export
+// eslint-disable-next-line import-x/prefer-default-export
 export const searchPlayers = (searchPaginationInput: SearchPaginationInput) => {
   const data = searchPaginationInput;
   const uri = `${PLAYER_URI}/search`;

openbas-front/src/admin/components/common/form/TextFieldAskAI.tsx

@@ -19,10 +19,10 @@ import { useTheme } from '@mui/material/styles';
 import { type FunctionComponent, type MouseEvent as ReactMouseEvent, useState } from 'react';
 
 import { aiChangeTone, aiExplain, aiFixSpelling, aiGenMedia, aiGenMessage, aiGenSubject, aiMakeLonger, aiMakeShorter, aiSummarize } from '../../../../actions/AskAI';
-// eslint-disable-next-line import/no-cycle
+// eslint-disable-next-line import-x/no-cycle
 import SimpleRichTextField from '../../../../components/fields/SimpleRichTextField';
 import { useFormatter } from '../../../../components/i18n';
-// eslint-disable-next-line import/no-cycle
+// eslint-disable-next-line import-x/no-cycle
 import ResponseDialog from '../../../../utils/ai/ResponseDialog';
 import useAI from '../../../../utils/hooks/useAI';
 import useEnterpriseEdition from '../../../../utils/hooks/useEnterpriseEdition';

openbas-front/src/admin/components/common/injects/teams/utils.ts

@@ -4,7 +4,7 @@ import * as R from 'ramda';
 import { type Team } from '../../../../../utils/api-types';
 import { colors } from '../../../../../utils/Charts';
 
-// eslint-disable-next-line import/prefer-default-export
+// eslint-disable-next-line import-x/prefer-default-export
 export const getTeamsColors: (teams: Team[]) => Record<string, string> = (teams: Team[]) => {
   const theme = useTheme();
 

openbas-front/src/admin/components/scenarios/constants.ts

@@ -1,4 +1,4 @@
-// eslint-disable-next-line import/prefer-default-export
+// eslint-disable-next-line import-x/prefer-default-export
 export const scenarioCategories = new Map([
   ['global-crisis', 'Global Crisis'],
   ['attack-scenario', 'Attack Scenario'],

openbas-front/src/components/AppIntlProvider.tsx

@@ -37,7 +37,7 @@ const momentMap = {
 };
 
 // Export LANG to be used in non-React code
-// eslint-disable-next-line import/no-mutable-exports
+// eslint-disable-next-line import-x/no-mutable-exports
 export let LANG = DEFAULT_LANG;
 
 const AppIntlProvider: FunctionComponent<{ children: ReactElement }> = ({ children }) => {

openbas-front/src/components/CKEditor.tsx

@@ -56,15 +56,15 @@ import {
 } from 'ckeditor5';
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
-// eslint-disable-next-line import/extensions
+// eslint-disable-next-line import-x/extensions
 import en from 'ckeditor5/translations/en.js';
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
-// eslint-disable-next-line import/extensions
+// eslint-disable-next-line import-x/extensions
 import fr from 'ckeditor5/translations/fr.js';
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
-// eslint-disable-next-line import/extensions
+// eslint-disable-next-line import-x/extensions
 import zh from 'ckeditor5/translations/zh.js';
 import { useEffect } from 'react';
 import { useIntl } from 'react-intl';

openbas-front/src/components/fields/OldRichTextField.jsx

@@ -2,7 +2,7 @@ import { FormHelperText, InputLabel } from '@mui/material';
 import { Field } from 'react-final-form';
 import { makeStyles } from 'tss-react/mui';
 
-// eslint-disable-next-line import/no-cycle
+// eslint-disable-next-line import-x/no-cycle
 import TextFieldAskAI from '../../admin/components/common/form/TextFieldAskAI';
 import CKEditor from '../CKEditor';
 import { useFormatter } from '../i18n';

openbas-front/src/components/fields/SimpleRichTextField.jsx

@@ -1,6 +1,6 @@
 import { InputLabel } from '@mui/material';
 
-// eslint-disable-next-line import/no-cycle
+// eslint-disable-next-line import-x/no-cycle
 import TextFieldAskAI from '../../admin/components/common/form/TextFieldAskAI';
 import CKEditor from '../CKEditor';
 

openbas-front/src/network.js

@@ -1,7 +1,7 @@
 import axios from 'axios';
 import { normalize } from 'normalizr';
 
-// eslint-disable-next-line import/prefer-default-export
+// eslint-disable-next-line import-x/prefer-default-export
 export const api = (schema) => {
   const instance = axios.create({ headers: { responseType: 'json' } });
   // Intercept to apply schema and test unauthorized users

openbas-front/src/public/components/systembanners/utils.ts

@@ -2,7 +2,7 @@ import { type PlatformSettings } from '../../../utils/api-types';
 import { isNotEmptyField, recordEntries, recordKeys } from '../../../utils/utils';
 import { SYSTEM_BANNER_HEIGHT_PER_MESSAGE } from './SystemBanners';
 
-// eslint-disable-next-line import/prefer-default-export
+// eslint-disable-next-line import-x/prefer-default-export
 export const computeBannerSettings = (settings: PlatformSettings) => {
   const bannerByLevel = settings.platform_banner_by_level;
   const isBannerActivated = bannerByLevel !== undefined && isNotEmptyField(recordKeys(bannerByLevel));

openbas-front/src/utils/ai/ResponseDialog.tsx

@@ -2,13 +2,13 @@ import { LoadingButton } from '@mui/lab';
 import { Alert, Button, Dialog, DialogActions, DialogContent, DialogTitle, TextField } from '@mui/material';
 // As we can ask AI after and follow up, there is a dependency lifecycle here that can be accepted
 // TODO: Cleanup a bit in upcoming version
-// eslint-disable-next-line import/no-cycle
+// eslint-disable-next-line import-x/no-cycle
 import MDEditor, { commands } from '@uiw/react-md-editor/nohighlight';
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
 import { type FunctionComponent, useEffect, useRef } from 'react';
 
-// eslint-disable-next-line import/no-cycle
+// eslint-disable-next-line import-x/no-cycle
 import TextFieldAskAI from '../../admin/components/common/form/TextFieldAskAI';
 import CKEditor from '../../components/CKEditor';
 import { useFormatter } from '../../components/i18n';

openbas-front/src/utils/hooks.ts

@@ -1,5 +1,5 @@
 import { useDispatch } from 'react-redux';
 
 // TODO upgrade redux to make it correctly work https://redux.js.org/usage/usage-with-typescript
-// eslint-disable-next-line @typescript-eslint/no-explicit-any,import/prefer-default-export
+// eslint-disable-next-line @typescript-eslint/no-explicit-any,import-x/prefer-default-export
 export const useAppDispatch: any = useDispatch;

openbas-front/src/utils/technical.ts

@@ -1,4 +1,4 @@
-// eslint-disable-next-line import/prefer-default-export
+// eslint-disable-next-line import-x/prefer-default-export
 export enum TechnicalScenarioSimulationEnum {
   Scenario = 'SCENARIO',
   Simulation = 'SIMULATION',

openbas-front/tests_e2e/fixtures/baseFixtures.ts

@@ -39,5 +39,5 @@ const test = testBase.extend<{ autoTestFixture: string }>({
   }],
 });
 
-// eslint-disable-next-line import/prefer-default-export
+// eslint-disable-next-line import-x/prefer-default-export
 export { test };