fix(mcp): kill entire process group when closing StdioClientTransport#170
Open
hernandez42 wants to merge 1 commit into
Open
fix(mcp): kill entire process group when closing StdioClientTransport#170hernandez42 wants to merge 1 commit into
hernandez42 wants to merge 1 commit into
Conversation
Root cause: tsx wrapper does NOT forward SIGTERM to its child node process. When McpClient.close() was called, only the tsx process received SIGTERM, leaving the playwright-mcp node and Chromium grandchild processes orphaned. Fix: capture the tsx PID and use kill(-pid, SIGKILL) in close() to atomically wipe the entire process tree (tsx → node → Chromium). This permanently fixes the playwright browser leak issue where sessions accumulated 30+ orphaned Chromium processes over time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause: When is called, it sends to the wrapper process. However, does NOT forward to its child process running . The process in turn spawns a browser grandchild. Result: a session ends → tsx dies → + keep running → process leak.
Fix: Capture the PID at transport creation time, and use in to atomically wipe the entire process tree (tsx → node → Chromium).
Changes
Impact
Test: 0 should stay at 0 during idle.