getting rid of hardcoded url and localhost fallback

Author: simonredfern

apps/api-manager/src/hooks.server.ts

@@ -17,6 +17,12 @@ import { createOpeyNotebookDynamicEntityIfNeeded } from "$lib/server/opey/opeyNo
 
 declare const process: { env: Record<string, string | undefined>; argv: string[] };
 
+if (!publicEnv.PUBLIC_OBP_BASE_URL) {
+  throw new Error(
+    'PUBLIC_OBP_BASE_URL is not set. Configure it on the running container before starting api-manager.'
+  );
+}
+
 // Constants
 const DEFAULT_PORT = 3003;
 

apps/api-manager/src/lib/components/OpeyChat.svelte

@@ -50,9 +50,15 @@
 		splash?: Snippet; // If set, will render the splash screen snippet until the first message is sent
 		// upon which the splash screen will dissapear
 	}
+	if (!env.PUBLIC_OPEY_BASE_URL) {
+		throw new Error(
+			'PUBLIC_OPEY_BASE_URL is not set. Configure it on the running container so the Opey chat can reach the backend.'
+		);
+	}
+
 	// Default chat options
 	const defaultChatOptions: OpeyChatOptions = {
-		baseUrl: env.PUBLIC_OPEY_BASE_URL || 'http://localhost:5000',
+		baseUrl: env.PUBLIC_OPEY_BASE_URL,
 		displayHeader: true,
 		currentlyActiveUserName: 'Guest',
 		displayConnectionPips: true,

apps/portal/src/hooks.server.ts

@@ -17,6 +17,12 @@ import { healthCheckRegistry, OIDCHealthCheckService } from '@obp/shared/health-
 import { redisService } from '$lib/redis/services/RedisService';
 import { RedisHealthCheckService } from '$lib/health-check/services/RedisHealthCheckService';
 
+if (!publicEnv.PUBLIC_OBP_BASE_URL) {
+	throw new Error(
+		'PUBLIC_OBP_BASE_URL is not set. Configure it on the running container before starting the portal.'
+	);
+}
+
 // Constants
 const DEFAULT_PORT = 5174;
 

apps/portal/src/lib/components/OpeyChat.svelte

@@ -50,9 +50,15 @@
 		splash?: Snippet; // If set, will render the splash screen snippet until the first message is sent
 		// upon which the splash screen will dissapear
 	}
+	if (!env.PUBLIC_OPEY_BASE_URL) {
+		throw new Error(
+			'PUBLIC_OPEY_BASE_URL is not set. Configure it on the running container so the Opey chat can reach the backend.'
+		);
+	}
+
 	// Default chat options
 	const defaultChatOptions: OpeyChatOptions = {
-		baseUrl: env.PUBLIC_OPEY_BASE_URL || 'http://localhost:5000',
+		baseUrl: env.PUBLIC_OPEY_BASE_URL,
 		displayHeader: true,
 		currentlyActiveUserName: 'Guest',
 		displayConnectionPips: true,

packages/shared/src/lib/components/OpeyChat.svelte

@@ -50,9 +50,8 @@
 		splash?: Snippet; // If set, will render the splash screen snippet until the first message is sent
 		// upon which the splash screen will dissapear
 	}
-	// Default chat options
-	const defaultChatOptions: OpeyChatOptions = {
-		baseUrl: 'http://localhost:5000',
+	// Default chat options (baseUrl must be supplied by the consuming app)
+	const defaultChatOptions: Omit<OpeyChatOptions, 'baseUrl'> = {
 		displayHeader: true,
 		currentlyActiveUserName: 'Guest',
 		displayConnectionPips: true,
@@ -61,7 +60,13 @@
 
 	let { opeyChatOptions, userAuthenticated = false, splash }: Props = $props();
 	// Merge default options with the provided options
-	const options = { ...defaultChatOptions, ...opeyChatOptions };
+	const options = { ...defaultChatOptions, ...opeyChatOptions } as OpeyChatOptions;
+
+	if (!options.baseUrl) {
+		throw new Error(
+			'OpeyChat: opeyChatOptions.baseUrl is required. Pass the Opey backend URL from the consuming app.'
+		);
+	}
 
 	// Initialize session state and services