Skip to content

Commit 6f89318

Browse files
akarivclaude
andcommitted
Fix stale cache-header assertion in test_server
'select *' is invalid SQL, so /api/query returns 200 with success=false. The test asserted that error response got max-age=3600, which stopped being true once we stopped caching errors. Assert both cases instead: a valid query is cached, a failed one isn't. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 203cf4d commit 6f89318

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

tests/test_server.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,16 @@ def test_server_init():
2929
assert resp.status_code == 403
3030
assert resp.headers.get('Cache-Control') == 'no-cache'
3131

32-
resp = client.get('/api/query?query=select *')
32+
resp = client.get('/api/query?query=select 1 as x')
3333
assert resp.status_code == 200
3434
assert resp.headers['Cache-Control'] == 'max-age=3600'
3535

36+
# A failed query is reported as a 200 with success=false - it must not be cached
37+
resp = client.get('/api/query?query=select *')
38+
assert resp.status_code == 200
39+
assert resp.get_json()['success'] is False
40+
assert resp.headers['Cache-Control'] == 'no-cache'
41+
3642
resp = client.get('/wait/1')
3743
assert resp.status_code == 200
3844

0 commit comments

Comments
 (0)