Skip to content

Commit 50e5337

Browse files
Jinyu XuJinyu Xu
authored andcommitted
feat: improve mobile trading safety and UX
1 parent 96a59d4 commit 50e5337

42 files changed

Lines changed: 1766 additions & 776 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
49.6 KB
Loading

design-qa-assets/ai-compact.png

51.1 KB
Loading

design-qa-assets/chart-compact.png

37.1 KB
Loading
11 KB
Loading
30.5 KB
Loading
19.4 KB
Loading

design-qa.md

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
1+
# Mobile Density Design QA
2+
3+
## Comparison target
4+
5+
- Source visual truth:
6+
- `/var/folders/bb/zttk5zmj1bqgl_7fy42dnjfm0000gn/T/codex-clipboard-1b800bf2-9f62-43a9-88ad-2d36b6d28928.png`
7+
- `/var/folders/bb/zttk5zmj1bqgl_7fy42dnjfm0000gn/T/codex-clipboard-92691e80-6add-4900-b290-6edeaec02c51.png`
8+
- Rendered implementation:
9+
- `design-qa-assets/ai-compact.png`
10+
- `design-qa-assets/chart-compact.png`
11+
- Additional route evidence:
12+
- `design-qa-assets/market-compact.png`
13+
- `design-qa-assets/strategy-compact.png`
14+
- `design-qa-assets/profile-compact.png`
15+
- CSS viewport: 390 × 844, device scale factor 1.
16+
- Source pixels: 774 × 1178 and 760 × 1178. These are higher-density/cropped mobile captures; comparison was normalized to the app-owned content width and focused on horizontal gutters rather than browser/device chrome or vertical crop.
17+
- State: authenticated dark-theme mobile web app. The AI comparison uses the same saved BTC/USDT analysis conversation; the chart comparison uses Trend Reversal Toolkit on BTC/USDT 1H.
18+
19+
## Full-view comparison evidence
20+
21+
- AI: the reference loses substantial width to page padding, message-list padding, and two avatar columns. The implementation removes both avatar columns and expands the assistant response to the full content width while preserving right alignment for user messages.
22+
- Chart: the reference uses visibly wide outer card gutters. The implementation reduces the shared page gutter to 10px and reduces the chart card's inner horizontal padding without clipping controls, labels, candles, signals, or the bottom navigation.
23+
- Market, strategy, profile, credits, notification, credential, security and analysis surfaces now consume the same 10px outer-gutter token where they previously used 14–18px page margins.
24+
25+
## Focused region comparison evidence
26+
27+
- AI message column: avatar elements are absent from the rendered accessibility tree and visible screenshot. Assistant bubbles occupy 100% of the content column; user bubbles may occupy up to 94% and remain right-aligned.
28+
- Chart card edges: outer margins are 10px and chart content padding is 10px. The selector chevrons, timeframe controls, price header and plot remain inside the card without overflow.
29+
30+
## Required fidelity surfaces
31+
32+
- Fonts and typography: existing font family, sizes, weights, line heights and financial number treatment are preserved. Wider content reduces unnecessary wrapping.
33+
- Spacing and layout rhythm: the shared outer gutter is now 10px; large nested AI/avatar gutters are removed. Card rhythm and bottom-navigation clearance remain intact.
34+
- Colors and visual tokens: no palette or semantic-state color changes.
35+
- Image quality and asset fidelity: no raster assets were added, removed or degraded. The requested avatar removal applies only to AI chat message affordances, not the user's profile identity screen.
36+
- Copy and content: unchanged.
37+
38+
## Comparison history
39+
40+
1. Initial P1: AI content width was materially reduced by user/AI avatar placeholders and nested side padding. Fix: removed avatar markup and styles; widened assistant and user message containers.
41+
2. Initial P2: chart and other primary screens used inconsistent 14–18px outer gutters. Fix: introduced `--page-gutter: 10px` and applied it to primary page shells and outer cards.
42+
3. Post-fix evidence: `ai-compact.png`, `chart-compact.png`, `market-compact.png`, `strategy-compact.png`, and `profile-compact.png` show no remaining P0/P1/P2 spacing or clipping issue.
43+
44+
## Verification
45+
46+
- Primary interactions tested: AI history drawer, loading a prior conversation, and navigation across AI, chart, market, strategy and profile routes.
47+
- Browser console: no application errors; only Vite connection debug messages.
48+
- Unit checks: 15/15 passed.
49+
- Production build: passed.
50+
- No backtest, purchase, order, or live-trading mutation was executed.
51+
52+
## Findings
53+
54+
No actionable P0/P1/P2 findings remain for the requested density change.
55+
56+
## Follow-up polish
57+
58+
- P3: verify the 10px gutter on a physical iPhone with a non-zero safe-area inset and on a 320px-wide Android device.
59+
60+
final result: passed

pnpm-workspace.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
allowBuilds:
2+
esbuild: set this to true or false

0 commit comments

Comments
 (0)