Move logic for getting all packet items to backend

Author: ryan-pratt

openc3-cosmos-init/plugins/packages/openc3-js-common/src/services/openc3Api.js

@@ -287,6 +287,10 @@ export default class OpenC3Api {
     return this.exec('get_all_tlm_names', [target_name])
   }
 
+  get_all_tlm_items_metadata(target_name) {
+    return this.exec('get_all_tlm_items_metadata', [target_name])
+  }
+
   async get_tlm_packet(target_name, packet_name, value_type, stale_time = 30) {
     const data = await this.exec('get_tlm_packet', [target_name, packet_name], {
       type: value_type,

openc3-cosmos-init/plugins/packages/openc3-vue-common/src/components/TargetPacketItemChooser.vue

@@ -412,62 +412,57 @@ export default {
         return
       }
       this.internalDisabled = true
-      this.itemNames = []
-      const packetsToGet =
-        this.selectedPacketName === 'LATEST'
-          ? this.packetNames.map((packet) => packet.value)
-          : [this.selectedPacketName]
-      const cmd = this.mode === 'tlm' ? 'get_tlm' : 'get_cmd'
-      const getPacketItemPromises = packetsToGet.map((packetName) =>
-        this.api[cmd](this.selectedTargetName, packetName),
-      )
-      Promise.all(getPacketItemPromises)
-        .then((packets) => {
-          const theseItems = []
-          packets.forEach((packet) => {
-            const itemsToAdd = packet.items
-              .map((item) => {
-                let label = item.name
-                if (item.data_type == 'DERIVED') {
-                  label += ' *'
-                }
-                return [
-                  {
-                    label: label,
-                    value: item.name,
-                    description: item.description,
-                    array: item.array_size / item.bit_size,
-                  },
-                ]
-              })
-              .reduce((result, item) => {
-                return result.concat(item)
-              }, [])
-            theseItems.unshift(...itemsToAdd)
-          })
-          theseItems.sort((a, b) => (a.label > b.label ? 1 : -1))
-          if (this.allowAll) {
-            theseItems.unshift(this.ALL)
-          }
-          if (!this.selectedItemName) {
-            this.selectedItemName = theseItems[0].value
-          }
-          this.description = theseItems[0].description
-          return theseItems
-        })
-        .then((itemNames) => {
-          this.itemNames = itemNames
-          this.itemIsArray()
-          this.$emit('on-set', {
-            targetName: this.selectedTargetName,
-            packetName: this.selectedPacketName,
-            itemName: this.selectedItemNameWIndex,
-            valueType: this.selectedValueType,
-            reduced: this.selectedReduced,
-            reducedType: this.selectedReducedType,
+
+      let getItemsPromise
+      if (this.selectedPacketName === 'LATEST') {
+        getItemsPromise = this.api.get_all_tlm_items_metadata(
+          this.selectedTargetName,
+        )
+      } else {
+        const cmd = this.mode === 'tlm' ? 'get_tlm' : 'get_cmd'
+        getItemsPromise = this.api[cmd](
+          this.selectedTargetName,
+          this.selectedPacketName,
+        ).then((packet) => packet.items)
+      }
+      getItemsPromise.then((items) => {
+        this.itemNames = items
+          .map((item) => {
+            let label = item.name
+            if (item.data_type == 'DERIVED') {
+              label += ' *'
+            }
+            return [
+              {
+                label: label,
+                value: item.name,
+                description: item.description,
+                array: item.array_size / item.bit_size,
+              },
+            ]
           })
-          this.internalDisabled = false
+          .reduce((result, item) => {
+            return result.concat(item)
+          }, [])
+        this.itemNames.sort((a, b) => (a.label > b.label ? 1 : -1))
+        if (this.allowAll) {
+          this.itemNames.unshift(this.ALL)
+        }
+        if (!this.selectedItemName) {
+          this.selectedItemName = this.itemNames[0].value
+        }
+        this.description = this.itemNames[0].description
+        this.itemIsArray()
+        this.$emit('on-set', {
+          targetName: this.selectedTargetName,
+          packetName: this.selectedPacketName,
+          itemName: this.selectedItemNameWIndex,
+          valueType: this.selectedValueType,
+          reduced: this.selectedReduced,
+          reducedType: this.selectedReducedType,
         })
+        this.internalDisabled = false
+      })
     },
     itemIsArray: function () {
       let i = this.itemNames.findIndex(

openc3/lib/openc3/api/tlm_api.rb

@@ -48,6 +48,7 @@ module Api
                        'get_all_telemetry', # DEPRECATED
                        'get_all_tlm_names',
                        'get_all_telemetry_names', # DEPRECATED
+                       'get_all_tlm_items_metadata',
                        'get_tlm',
                        'get_telemetry', # DEPRECATED
                        'get_item',
@@ -314,6 +315,14 @@ def get_all_tlm_names(target_name, hidden: false, manual: false, scope: $openc3_
     end
     alias get_all_telemetry_names get_all_tlm_names
 
+    # Returns an array of all the item hashes for every packet in a target
+    #
+    # @param target_name [String] Name of the taret
+    # @return [Array<String>] Array of all telemetry item names
+    def get_all_tlm_items_metadata(target_name, manual: false, scope: $openc3_scope, token: $openc3_token)
+      TargetModel.all_items_metadata(target_name, scope: scope)
+    end
+
     # Returns a telemetry packet hash
     #
     # @since 5.0.0

openc3/lib/openc3/models/target_model.rb

@@ -204,7 +204,7 @@ def self.packet(target_name, packet_name, type: :TLM, scope:)
       JSON.parse(json, :allow_nan => true, :create_additions => true)
     end
 
-    # @return [Array>Hash>] All packet hashes under the target_name
+    # @return [Array<Hash>] All packet hashes under the target_name
     def self.packets(target_name, type: :TLM, scope:)
       raise "Unknown type #{type} for #{target_name}" unless VALID_TYPES.include?(type)
       raise "Target '#{target_name}' does not exist for scope: #{scope}" unless get(name: target_name, scope: scope)
@@ -217,7 +217,7 @@ def self.packets(target_name, type: :TLM, scope:)
       result
     end
 
-    # @return [Array>Hash>] All packet hashes under the target_name
+    # @return [Array<Hash>] All packet hashes under the target_name
     def self.all_packet_name_descriptions(target_name, type: :TLM, scope:)
       self.packets(target_name, type: type, scope: scope).map! { |hash| hash.slice("packet_name", "description") }
     end
@@ -257,6 +257,20 @@ def self.packet_items(target_name, packet_name, items, type: :TLM, scope:)
       found
     end
 
+    # @return [Array<Hash>] All the item hashes for every packet in a target
+    def self.all_items_metadata(target_name, type: :TLM, scope:)
+      items = []
+      packets = packets(target_name, type: type, scope: scope)
+      items += packets.flat_map do |packet|
+        packet['items'].map do |item|
+          item.slice('name', 'description', 'data_type', 'array_size', 'bit_size')
+        end
+      end
+      items.uniq! { |i| i['name'] } # since this would be used by `<target_name> LATEST <item_name>`
+      items.sort_by! { |i| i['name'] }
+      items
+    end
+
     # @return [Hash{String => Array<Array<String, String, String>>}]
     def self.limits_groups(scope:)
       groups = Store.hgetall("#{scope}__limits_groups")