Add validity check around check eval

so the script doesn't crash on undefined tlm

Author: ryan-pratt

openc3/lib/openc3/script/api_shared.rb

@@ -864,7 +864,18 @@ def _check_eval(target_name, packet_name, item_name, comparison_to_eval, value)
       # Note: We have to preserve the original 'value' variable because we're going to eval against it
       value_str = value.is_a?(String) ? "'#{value}'" : value
       with_value = "with value == #{value_str}"
-      if eval(string)
+
+      eval_is_valid = _check_eval_validity(value, comparison_to_eval)
+      unless eval_is_valid
+        message = "Invalid comparison for types"
+        if $disconnect
+          puts "ERROR: #{message}"
+        else
+          raise CheckError, message
+        end
+      end
+
+      if eval_is_valid && eval(string)
         puts "#{check_str} success #{with_value}"
       else
         message = "#{check_str} failed #{with_value}"
@@ -883,5 +894,17 @@ def _check_eval(target_name, packet_name, item_name, comparison_to_eval, value)
         raise e
       end
     end
+
+    def _check_eval_validity(value, comparison)
+      return true if comparison.nil? || comparison.empty?
+
+      operator, operand = extract_operator_and_operand_from_comparison(comparison)
+
+      if [">=", "<=", ">", "<"].include?(operator)
+        return false if value.nil? || operand.nil? || value.is_a?(Array) || operand.is_a?(Array)
+      end
+
+      return true
+    end
   end
 end

openc3/python/openc3/api/api_shared.py

@@ -19,6 +19,7 @@
 from openc3.utilities.extract import (
     extract_fields_from_check_text,
     extract_fields_from_tlm_text,
+    extract_operator_and_operand_from_comparison,
 )
 
 
@@ -965,8 +966,12 @@ def _check_eval(target_name, packet_name, item_name, comparison_to_eval, value):
     else:
         value_str = value
     with_value = f"with value == {value_str}"
+
+    eval_is_valid = _check_eval_validity(value, comaparison_to_eval)
+    if not eval_is_valid:
+        raise CheckError("ERROR: Invalid comparison for types")
     try:
-        if eval(string):
+        if eval_is_valid and eval(string):
             print(f"{check_str} success {with_value}")
         else:
             message = f"{check_str} failed {with_value}"
@@ -986,6 +991,25 @@ def _frange(value):
         return value
 
 
+def _check_eval_validity(value, comparison):
+    if not comparison:
+        return True
+
+    operator, operand = extract_operator_and_operand_from_comparison(comparison)
+
+    if operator in [">=", "<=", ">", "<"]:
+        if value is None or operand is None or isinstance(value, list) or isinstance(operand, list):
+            return False
+
+    if operator == "in": # Ruby doesn't have this operator
+        if isinstance(operand, str) and not isinstance(value, str):
+            return False
+        elif not isinstance(operand, list):
+            return False
+
+    return True
+
+
 # Interesting formatter to a specific number of significant digits:
 # https://stackoverflow.com/questions/3410976/how-to-round-a-number-to-significant-figures-in-python?rq=3
 # def format(value, sigfigs=9):

openc3/python/openc3/script/api_shared.py

@@ -19,6 +19,7 @@
 from openc3.utilities.extract import (
     extract_fields_from_check_text,
     extract_fields_from_tlm_text,
+    extract_operator_and_operand_from_comparison,
 )
 
 from .exceptions import CheckError
@@ -1046,8 +1047,16 @@ def _check_eval(target_name, packet_name, item_name, comparison_to_eval, value):
     else:
         value_str = value
     with_value = f"with value == {value_str}"
+
+    eval_is_valid = _check_eval_validity(value, comparison_to_eval)
+    if not eval_is_valid:
+        message = "Invalid comparison for types"
+        if openc3.script.DISCONNECT:
+            print(f"ERROR: {message}")
+        else:
+            raise CheckError(message)
     try:
-        if eval(string):
+        if eval_is_valid and eval(string):
             print(f"{check_str} success {with_value}")
         else:
             message = f"{check_str} failed {with_value}"
@@ -1070,6 +1079,25 @@ def _frange(value):
         return value
 
 
+def _check_eval_validity(value, comparison):
+    if not comparison:
+        return True
+
+    operator, operand = extract_operator_and_operand_from_comparison(comparison)
+
+    if operator in [">=", "<=", ">", "<"]:
+        if value is None or operand is None or isinstance(value, list) or isinstance(operand, list):
+            return False
+
+    if operator == "in": # Ruby doesn't have this operator
+        if isinstance(operand, str) and not isinstance(value, str):
+            return False
+        elif not isinstance(operand, list):
+            return False
+
+    return True
+
+
 # Interesting formatter to a specific number of significant digits:
 # https://stackoverflow.com/questions/3410976/how-to-round-a-number-to-significant-figures-in-python?rq=3
 # def format(value, sigfigs=9):