Fix array of strings

Author: jmthomas

openc3-cosmos-init/plugins/packages/openc3-cosmos-demo/targets/INST/cmd_tlm/inst_tlm.txt

@@ -169,7 +169,7 @@ TELEMETRY <%= target_name %> MECH BIG_ENDIAN "Mechanism status ©®"
     UNITS DEGREES DEG
   APPEND_ITEM CURRENT       32 FLOAT    "Device current"
     UNITS micro-Ampères µA
-  APPEND_ITEM STRING       0 STRING     "String"
+  APPEND_ARRAY_ITEM STRINGS 2048 STRING 0 "Array of strings"
   ITEM PACKET_TIME 0 0 DERIVED "Ruby time based on TIMESEC and TIMEUS"
     READ_CONVERSION unix_time_conversion.rb TIMESEC TIMEUS
 

openc3-cosmos-init/plugins/packages/openc3-cosmos-demo/targets/INST/lib/sim_inst.rb

@@ -428,6 +428,8 @@ def read(count_100hz, time)
           packet.slrpnl4 = @solar_panel_positions[3]
           packet.slrpnl5 = @solar_panel_positions[4]
           packet.current = 0.5
+          packet.strings = ['STRING1'.ljust(256, "\x00"), 'STRING2'.ljust(256, "\x00"), 'STRING3'.ljust(256, "\x00")]
+          packet.CcsdsLength = packet.buffer.length - 7
 
         when 'HIDDEN'
           packet.timesec = time.tv_sec - @time_offset

openc3-cosmos-init/plugins/packages/openc3-cosmos-demo/targets/INST/screens/array.txt

@@ -17,6 +17,5 @@ VERTICAL
   ARRAY <%= target_name %> HEALTH_STATUS ARY2 300 65 nil 5 WITH_UNITS
   TEXTBOX <%= target_name %> HEALTH_STATUS ARY 200 65
   TEXTBOX <%= target_name %> HEALTH_STATUS ARY2 300 65
-  ARRAY <%= target_name %> HEALTH_STATUS GROUND1STATUS 300 65 nil 8 FORMATTED
-  ARRAY <%= target_name %> HEALTH_STATUS GROUND2STATUS 300 65 nil 5 WITH_UNITS
+  ARRAY <%= target_name %> MECH STRINGS 300
 END

openc3-cosmos-init/plugins/packages/openc3-cosmos-demo/targets/INST2/cmd_tlm/inst_tlm.txt

@@ -163,7 +163,7 @@ TELEMETRY <%= target_name %> MECH BIG_ENDIAN "Mechanism status ©®"
     UNITS DEGREES DEG
   APPEND_ITEM CURRENT       32 FLOAT    "Device current"
     UNITS micro-Ampères µA
-  APPEND_ITEM STRING       0 STRING     "String"
+  APPEND_ARRAY_ITEM STRINGS 2048 STRING 0 "Array of strings"
   ITEM PACKET_TIME 0 0 DERIVED "Python time based on TIMESEC and TIMEUS"
     READ_CONVERSION openc3/conversions/unix_time_conversion.py TIMESEC TIMEUS
 

openc3-cosmos-init/plugins/packages/openc3-cosmos-demo/targets/INST2/lib/sim_inst.py

@@ -157,11 +157,11 @@ def set_rates(self):
         self.set_rate("PARAMS.PKT", 100)
         self.set_rate("IMAGE", 100)
         self.set_rate("MECH", 10)
-        self.set_rate('JSONTLM', 500)
-        self.set_rate('CBORTLM', 500)
-        self.set_rate('XMLTLM', 500)
-        self.set_rate('HTMLTLM', 500)
-        self.set_rate('HYBRIDTLM', 500)
+        self.set_rate("JSONTLM", 500)
+        self.set_rate("CBORTLM", 500)
+        self.set_rate("XMLTLM", 500)
+        self.set_rate("HTMLTLM", 500)
+        self.set_rate("HYBRIDTLM", 500)
 
     def tick_period_seconds(self):
         return 0.1  # Override this method to optimize
@@ -430,7 +430,15 @@ def read(self, count_100hz, time):
                     packet.write("slrpnl4", self.solar_panel_positions[3])
                     packet.write("slrpnl5", self.solar_panel_positions[4])
                     packet.write("current", 0.5)
-                    packet.write("string", f"Time is {time}")
+                    packet.write(
+                        "strings",
+                        [
+                            "STRING1".ljust(256, "\x00"),
+                            "STRING2".ljust(256, "\x00"),
+                            "STRING3".ljust(256, "\x00"),
+                        ],
+                    )
+                    packet.write("CcsdsLength", len(packet.buffer) - 7)
 
         # Every 10s throw an unknown packet at the server just to demo that
         if count_100hz % 1000 == 900:

openc3-cosmos-init/plugins/packages/openc3-cosmos-demo/targets/INST2/screens/array.txt

@@ -17,6 +17,5 @@ VERTICAL
   ARRAY <%= target_name %> HEALTH_STATUS ARY2 300 65 nil 5 WITH_UNITS
   TEXTBOX <%= target_name %> HEALTH_STATUS ARY 200 65
   TEXTBOX <%= target_name %> HEALTH_STATUS ARY2 300 65
-  ARRAY <%= target_name %> HEALTH_STATUS GROUND1STATUS 300 65 nil 8 FORMATTED
-  ARRAY <%= target_name %> HEALTH_STATUS GROUND2STATUS 300 65 nil 5 WITH_UNITS
+  ARRAY <%= target_name %> MECH STRINGS 300
 END

openc3/lib/openc3/api/tlm_api.rb

@@ -284,13 +284,8 @@ def get_tlm_available(items, manual: false, scope: $openc3_scope, token: $openc3
             value_type = 'RAW' # Must request the raw value when dealing with the reserved items
           end
 
-          # QuestDB 9.0.0 only supports DOUBLE arrays: https://questdb.com/docs/concept/array/
+          # Arrays must be accessed as RAW since there's no conversion
           if item['array_size']
-            # TODO: This needs work ... we're JSON encoding non numeric array values
-            if item['data_type'] == 'STRING' or item['data_type'] == 'BLOCK'
-              results << nil
-              next
-            end
             value_type = 'RAW'
           end
 

openc3/python/openc3/api/tlm_api.py

@@ -306,12 +306,8 @@ def get_tlm_available(items, manual=False, scope=OPENC3_SCOPE):
             if item_name in Packet.RESERVED_ITEM_NAMES:
                 value_type = 'RAW'  # Must request the raw value when dealing with the reserved items
 
-            # QuestDB 9.0.0 only supports DOUBLE arrays: https://questdb.com/docs/concept/array/
-            if item_config.get('array_size'):
-                # TODO: This needs work ... we're JSON encoding non numeric array values
-                if item_config.get('data_type') in ['STRING', 'BLOCK']:
-                    results.append(None)
-                    continue
+            # Arrays must be accessed as RAW since there's no conversion
+            if item_config.get('array_size') is not None:
                 value_type = 'RAW'
 
             # Determine the best available value type based on item configuration