Skip to content

Commit aea1f35

Browse files
youngbeom-shin申永范-UX
andauthored
feat(evaluations): add validation for datasets (#1230)
* feat(evaluations): add validation for datasets * feat(evaluations): add validation for datasets --------- Co-authored-by: 申永范-UX <[email protected]>
1 parent 72fd8d3 commit aea1f35

File tree

4 files changed

+48
-14
lines changed

4 files changed

+48
-14
lines changed

frontend/src/components/evaluations/NewEvaluation.vue

Lines changed: 39 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,20 +96,20 @@
9696
>
9797
<el-radio-group v-model="datasetCheck" class="w-full flex">
9898
<div class="flex-1">
99-
<el-radio value="1" size="large" class="ext-slate-700 text-sm font-normal">{{ t('evaluation.new.systemRecommendedDataset') }}</el-radio>
99+
<el-radio value="1" size="large" class="text-gray-700 text-sm font-normal">{{ t('evaluation.new.systemRecommendedDataset') }}</el-radio>
100100
<div class="self-stretch justify-start pl-6">
101-
<span class="text-slate-600 text-sm font-light">
101+
<span class="text-gray-600 text-sm font-light">
102102
{{ t('evaluation.new.systemRecommendedDatasetTip') }}
103103
</span>
104104
</div>
105105
</div>
106106
<div>
107-
<el-radio value="2" size="large" class="flex-1 text-slate-700 text-sm font-normal">{{ t('evaluation.new.customDataset') }}</el-radio>
107+
<el-radio value="2" size="large" class="flex-1 text-gray-700 text-sm font-normal">{{ t('evaluation.new.customDataset') }}</el-radio>
108108
<div class="self-stretch justify-start pl-6">
109-
<span class="text-slate-600 text-sm font-light">
109+
<span class="text-gray-600 text-sm font-light">
110110
{{ t('evaluation.new.customDatasetTip') }}
111111
</span>
112-
<span class="text-blue-800 text-sm font-light leading-snug cursor-pointer pl-1">
112+
<span class="text-brand-600 text-sm font-light leading-snug cursor-pointer pl-1">
113113
<a
114114
class="text-brand-600 hover:text-brand-700 hover:underline"
115115
target="_blank"
@@ -425,6 +425,40 @@
425425
}
426426
}
427427
}
428+
],
429+
evaluation_dataset: [
430+
{
431+
required: true,
432+
validator: (rule, value, callback) => {
433+
if (datasetCheck.value === '1') {
434+
if (!value || (Array.isArray(value) && value.length === 0)) {
435+
callback(new Error(t('all.pleaseSelect', { value: t('evaluation.new.dataset') })))
436+
} else {
437+
callback()
438+
}
439+
} else {
440+
callback()
441+
}
442+
},
443+
trigger: 'change'
444+
}
445+
],
446+
evaluation_custom_dataset: [
447+
{
448+
required: true,
449+
validator: (rule, value, callback) => {
450+
if (datasetCheck.value === '2') {
451+
if (!value || (Array.isArray(value) && value.length === 0)) {
452+
callback(new Error(t('all.pleaseSelect', { value: t('evaluation.new.customdataset') })))
453+
} else {
454+
callback()
455+
}
456+
} else {
457+
callback()
458+
}
459+
},
460+
trigger: 'change'
461+
}
428462
]
429463
})
430464

frontend/src/locales/en_js/evaluation.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ export const evaluation = {
1111
frameworkTip1: "Learn about the",
1212
frameworkTip2: "differences of evaluation frameworks",
1313
systemRecommendedDataset: "System Recommended Dataset",
14-
systemRecommendedDatasetTip: "Use the dataset preset and recommended by the system, ready to use out of the box",
14+
systemRecommendedDatasetTip: "Use the dataset preset and recommended by the system",
1515
customDataset: "Custom Dataset",
1616
customDatasetTip: "Select any available dataset from the platform for configuration",
1717
customDatasetDocumentation: "Documentation",
18-
dataset: "Dataset Selection",
19-
customDataset: "Custom Dataset Selection",
18+
dataset: "Evaluation Dataset",
19+
customDataset: "Custom Dataset",
2020
resourceType: "Resource Type",
2121
sharedResource: "Shared Resource",
2222
sharedResourceTip: "Shared resources may cause congestion, queueing, and longer wait times.",

frontend/src/locales/zh_hant_js/evaluation.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ export const evaluation = {
1111
frameworkTip1: "了解評測框架的",
1212
frameworkTip2: "區別與適用場景",
1313
systemRecommendedDataset: "系統推薦數據集",
14-
systemRecommendedDatasetTip: "採用系統預置並推薦的數據集,開箱即用",
14+
systemRecommendedDatasetTip: "採用系統預置並推薦的數據集",
1515
customDataset: "自選數據集",
1616
customDatasetTip: "自行選擇平台中任意可用數據集進行配置",
1717
customDatasetDocumentation: "文件",
18-
dataset: "資料集選擇",
19-
customdataset: "自選數據集選擇",
18+
dataset: "評測數據集",
19+
customdataset: "自選數據集",
2020
resourceType: "資源類型",
2121
sharedResource: "共享資源",
2222
sharedResourceTip: "共享資源可能會產生擁堵,排隊的現象,等待時長較長",

frontend/src/locales/zh_js/evaluation.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ export const evaluation = {
1111
frameworkTip1: "了解评测框架的",
1212
frameworkTip2: "区别与适用场景",
1313
systemRecommendedDataset: "系统推荐数据集",
14-
systemRecommendedDatasetTip: "采用系统预置并推荐的数据集,开箱即用",
14+
systemRecommendedDatasetTip: "采用系统预置并推荐的数据集",
1515
customDataset: "自选数据集",
1616
customDatasetTip: "自行选择平台中任意可用数据集进行配置",
1717
customDatasetDocumentation: "文档",
18-
dataset: "数据集选择",
19-
customdataset: "自选数据集选择",
18+
dataset: "评测数据集",
19+
customdataset: "自选数据集",
2020
resourceType: "资源类型",
2121
sharedResource: "共享资源",
2222
sharedResourceTip: "共享资源可能会产生拥堵,排队的现象,等待时长较长",

0 commit comments

Comments
 (0)