Skip to content

Commit cab157f

Browse files
zhendizhendi.wang
andauthored
feat(router): improve logging setup (#1289)
* feat(router): improve logging setup * feat(config): add AppEnv configuration option - Add AppEnv to Config struct - Remove CacheControlMiddleware from router * feat(middleware): add CacheControlMiddleware usage - Integrate CacheControlMiddleware - Enhance response caching capabilities --------- Co-authored-by: zhendi.wang <[email protected]>
1 parent 97f0aad commit cab157f

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

config/config.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ const (
1212
)
1313

1414
type Config struct {
15+
AppEnv string `envconfig:"CSGHUB_PORTAL_APP_ENV" default:"development"`
1516
ServerPort int `envconfig:"CSGHUB_PORTAL_SERVER_PORT" default:"8090"`
1617
SuperUsers string `envconfig:"CSGHUB_PORTAL_SUPER_USERS" default:""`
1718
OnPremise bool `envconfig:"CSGHUB_PORTAL_ON_PREMISE" default:"true"`

internal/routes/router.go

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,18 +39,22 @@ func Initialize(svcCtx *svc.ServiceContext) (*gin.Engine, error) {
3939
log.Fatalf("failed to create server: %v", err)
4040
}
4141

42-
logFilePath := "./log/app.log"
43-
err = os.MkdirAll(filepath.Dir(logFilePath), os.ModePerm)
44-
if err != nil {
45-
log.Fatalf("Failed to create directory: %v", err)
46-
}
42+
writer := os.Stdout
43+
if svcCtx.Config.AppEnv == "development" {
44+
logFilePath := "./log/app.log"
45+
err = os.MkdirAll(filepath.Dir(logFilePath), os.ModePerm)
46+
if err != nil {
47+
log.Fatalf("Failed to create directory: %v", err)
48+
}
4749

48-
f, err := os.OpenFile(logFilePath, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0666)
49-
if err != nil {
50-
log.Fatalf("Can not open log file:%v", err)
50+
f, err := os.OpenFile(logFilePath, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0666)
51+
if err != nil {
52+
log.Fatalf("Can not open log file:%v", err)
53+
}
54+
writer = f
5155
}
5256

53-
lh := slog.NewJSONHandler(f, &slog.HandlerOptions{
57+
lh := slog.NewJSONHandler(writer, &slog.HandlerOptions{
5458
AddSource: false,
5559
Level: slog.LevelInfo,
5660
})

0 commit comments

Comments
 (0)