Merge pull request #511 from OpenConext/feature/issues-433_fix-invalid_logentry

johanib · web-flow · commit ab62a72ce881 · 2025-12-18T15:32:26.000+01:00
Fix premature log entry
diff --git a/src/Surfnet/StepupGateway/GatewayBundle/Controller/SecondFactorController.php b/src/Surfnet/StepupGateway/GatewayBundle/Controller/SecondFactorController.php
@@ -408,8 +408,8 @@ public function gssfVerified(Request $request, string $authenticationMode): Resp
             );
         }
 
-        $this->getAuthenticationLogger()->logSecondFactorAuthentication($originalRequestId, $authenticationMode);
         $context->markSecondFactorVerified();
+        $this->getAuthenticationLogger()->logSecondFactorAuthentication($originalRequestId, $authenticationMode);
 
         $logger->info(sprintf(
             'Marked GSSF "%s" as verified, forwarding to Gateway controller to respond',

Original file line number	Diff line number	Diff line change
`@@ -408,8 +408,8 @@ public function gssfVerified(Request $request, string $authenticationMode): Resp`
`408`	`408`	`);`
`409`	`409`	`}`
`410`	`410`
`411`		`- $this->getAuthenticationLogger()->logSecondFactorAuthentication($originalRequestId, $authenticationMode);`
`412`	`411`	`$context->markSecondFactorVerified();`
	`412`	`+ $this->getAuthenticationLogger()->logSecondFactorAuthentication($originalRequestId, $authenticationMode);`
`413`	`413`
`414`	`414`	`$logger->info(sprintf(`
`415`	`415`	`'Marked GSSF "%s" as verified, forwarding to Gateway controller to respond',`