Fix and also run functional tests

Author: pablothedude

.github/workflows/test-integration.yml

@@ -26,5 +26,13 @@ jobs:
             - name: Run CI tests
               run: |
                   cd ci/docker && docker compose exec -T gateway bash -c '
+                      ls -lah /var/www/html/var/cache && \
+                      ls -lah /var/www/html/var/cache/smoketest && \
                       composer check
                   '
+
+            - name: Output logs on failure
+              if: failure()
+              run: |
+                cd ci/docker
+                docker compose logs

ci/docker/init.sh

@@ -1,9 +1,9 @@
 #!/usr/bin/env bash
 cp ../../devconf/stepup/gateway/surfnet_yubikey.yaml.dist ../../devconf/stepup/gateway/surfnet_yubikey.yaml
 echo "pulling the images"
-docker compose pull gateway selenium haproxy ssp mariadb
+docker compose pull gateway selenium haproxy ssp mariadb chrome
 echo "starting the images"
-docker compose up gateway selenium haproxy ssp mariadb -d
+docker compose up gateway selenium haproxy ssp mariadb chrome -d
 echo "intialising the environment"
 docker compose exec -T gateway bash -c '
   cp /var/www/html/devconf/stepup/gateway/surfnet_yubikey.yaml.dist /var/www/html/devconf/stepup/gateway/surfnet_yubikey.yaml && \
@@ -14,5 +14,5 @@ docker compose exec -T gateway bash -c '
   composer frontend-install && \global_view_parameters.yaml.dist
   ./bin/console assets:install --env=smoketest --verbose && \
   ./bin/console cache:clear --env=smoketest && \
-  chown -R www-data:www-data /var/www/html/var/
+  chown -R www-data /var/www/html/var/
 '

composer.json

@@ -104,7 +104,8 @@
             "@phpcs",
             "@phpmd",
             "@test",
-            "@behat"
+            "@behat",
+            "@behat-functional"
         ],
         "phplint": "./ci/qa/phplint",
         "validate-lockfile": "./ci/qa/validate",

tests/features/bootstrap/ServiceProviderContext.php

@@ -314,21 +314,6 @@ public function iAuthenticateAtTheIdp($username): void
         }
     }
 
-    /**
-     * @return IdentityProvider
-     */
-    public function getIdentityProvider()
-    {
-        /** @var RequestStack $stack */
-
-        $stack = $this->kernel->getContainer()->get('request_stack');
-        $stack->push(Request::create('https://gateway.dev.openconext.local'));
-        $ip = $this->kernel->getContainer()->get('surfnet_saml.hosted.identity_provider');
-        $stack->pop();
-
-        return $ip;
-    }
-
     private static function loadPrivateKey(PrivateKey $key)
     {
         $keyLoader = new PrivateKeyLoader();