Add AzureMFA for functional tests

This is done for the functional testing setup

Author: pablothedude

ci/docker/compose.override.yml

@@ -1,4 +1,18 @@
 services:
+    haproxy:
+      networks:
+        openconextdev:
+          aliases:
+            - ra.dev.openconext.local
+            - ssp.dev.openconext.local
+            - selfservice.dev.openconext.local
+            - middleware.dev.openconext.local
+            - gateway.dev.openconext.local
+            - demogssp.dev.openconext.local
+            - webauthn.dev.openconext.local
+            - tiqr.dev.openconext.local
+            - azuremfa.dev.openconext.local
+            - mailcatcher.dev.openconext.local
     gateway:
       image: ghcr.io/openconext/openconext-basecontainers/php82-apache2-node20-composer2:latest
       container_name: gateway
@@ -14,3 +28,9 @@ services:
     mariadb: 
        volumes:
           - ../../devconf/stepup/dbschema/:/docker-entrypoint-initdb.d/
+    azuremfa:
+      image: ghcr.io/openconext/stepup-azuremfa/stepup-azuremfa:test
+      environment:
+        APP_ENV: smoketest
+      volumes:
+        - ../../devconf/stepup/:/config

ci/docker/init.sh

@@ -1,9 +1,9 @@
 #!/usr/bin/env bash
 cp ../../devconf/stepup/gateway/surfnet_yubikey.yaml.dist ../../devconf/stepup/gateway/surfnet_yubikey.yaml
 echo "pulling the images"
-docker compose pull gateway selenium haproxy ssp mariadb chrome
+docker compose pull gateway selenium haproxy ssp mariadb azuremfa chrome
 echo "starting the images"
-docker compose up gateway selenium haproxy ssp mariadb chrome -d
+docker compose up gateway selenium haproxy ssp mariadb azuremfa chrome -d
 echo "intialising the environment"
 docker compose exec -T gateway bash -c '
   cp /var/www/html/devconf/stepup/gateway/surfnet_yubikey.yaml.dist /var/www/html/devconf/stepup/gateway/surfnet_yubikey.yaml && \

src/Surfnet/StepupGateway/GatewayBundle/Sso2fa/CookieService.php

@@ -149,7 +149,7 @@ public function maySkipAuthentication(
             return false;
         }
 
-        if (!$this->secondFactorService->findByUuid($ssoCookie->secondFactorId(),)) {
+        if (!$this->secondFactorService->findByUuid($ssoCookie->secondFactorId())) {
             $this->logger->notice(
                 'The second factor stored in the SSO cookie was revoked or has otherwise became unknown to Gateway',
                 [