Skip to content

Commit a5f3ce3

Browse files
authored
Merge pull request #1635 from knutfrode/dev
[run-ex] Remove unused variables from OceanDrift.required_variables
2 parents 16bcf54 + dbd1252 commit a5f3ce3

3 files changed

Lines changed: 3 additions & 12 deletions

File tree

examples/example_2d.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
o.set_config('environment:fallback:x_sea_water_velocity', .1)
1717
o.set_config('environment:fallback:sea_surface_wave_stokes_drift_x_velocity', .2)
1818
o.set_config('environment:fallback:sea_surface_wave_significant_height', 2)
19-
o.set_config('environment:fallback:sea_surface_wave_period_at_variance_spectral_density_maximum', 8)
2019

2120
#%%
2221
# Seed elements between surface and 5m depth

opendrift/models/oceandrift.py

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -83,16 +83,8 @@ class OceanDrift(OpenDriftSimulation):
8383
'skip_if': ['drift:stokes_drift', 'is', False]},
8484
'sea_surface_wave_stokes_drift_y_velocity': {'fallback': 0,
8585
'skip_if': ['drift:stokes_drift', 'is', False]},
86-
'sea_surface_wave_period_at_variance_spectral_density_maximum':
87-
{'fallback': 0},
88-
'sea_surface_wave_mean_period_from_variance_spectral_density_second_frequency_moment': {'fallback': 0},
89-
'sea_surface_swell_wave_to_direction': {'fallback': 0, 'important': False},
90-
'sea_surface_swell_wave_peak_period_from_variance_spectral_density': {'fallback': 0, 'important': False},
91-
'sea_surface_swell_wave_significant_height': {'fallback': 0, 'important': False},
92-
'sea_surface_wind_wave_to_direction': {'fallback': 0, 'important': False},
93-
'sea_surface_wind_wave_mean_period': {'fallback': 0, 'important': False},
94-
'sea_surface_wind_wave_significant_height': {'fallback': 0, 'important': False},
95-
'ocean_mixed_layer_thickness': {'fallback': 50},
86+
'ocean_mixed_layer_thickness': {
87+
'fallback': 50, 'skip_if': ['drift:vertical_mixing', 'is', False]},
9688
'sea_floor_depth_below_sea_level': {'fallback': 10000},
9789
'land_binary_mask': {'fallback': None},
9890
}

tests/models/test_basemodel.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
def test_logging(tmpdir, capsys):
1111
# Accepting small variations in log output,
1212
# depending on machine, and from which folder test is run
13-
accepted = (262, 265)
13+
accepted = (219, 222)
1414

1515
# Logging to console
1616
logfile = None

0 commit comments

Comments
 (0)